linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs: kernfs: Corrected spelling mistake
@ 2019-04-02 11:44 Christina Quast
  2019-04-02 11:58 ` Mukesh Ojha
  2019-04-02 12:00 ` Greg Kroah-Hartman
  0 siblings, 2 replies; 7+ messages in thread
From: Christina Quast @ 2019-04-02 11:44 UTC (permalink / raw)
  Cc: trivial, Christina Quast, Greg Kroah-Hartman, Tejun Heo, linux-kernel

Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
---
 include/linux/kernfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index c8893f663470..e446ab97ee0c 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -64,7 +64,7 @@ enum kernfs_root_flag {
 	KERNFS_ROOT_CREATE_DEACTIVATED		= 0x0001,
 
 	/*
-	 * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
+	 * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
 	 * succeeds regardless of the RW permissions.  sysfs had an extra
 	 * layer of enforcement where open(2) fails with -EACCES regardless
 	 * of CAP_DAC_OVERRIDE if the permission doesn't have the
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] fs: kernfs: Corrected spelling mistake
  2019-04-02 11:44 [PATCH] fs: kernfs: Corrected spelling mistake Christina Quast
@ 2019-04-02 11:58 ` Mukesh Ojha
  2019-04-02 12:00 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 7+ messages in thread
From: Mukesh Ojha @ 2019-04-02 11:58 UTC (permalink / raw)
  To: Christina Quast; +Cc: trivial, Greg Kroah-Hartman, Tejun Heo, linux-kernel

flies => files

On 4/2/2019 5:14 PM, Christina Quast wrote:
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh
> ---
>   include/linux/kernfs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
> index c8893f663470..e446ab97ee0c 100644
> --- a/include/linux/kernfs.h
> +++ b/include/linux/kernfs.h
> @@ -64,7 +64,7 @@ enum kernfs_root_flag {
>   	KERNFS_ROOT_CREATE_DEACTIVATED		= 0x0001,
>   
>   	/*
> -	 * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
> +	 * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
>   	 * succeeds regardless of the RW permissions.  sysfs had an extra
>   	 * layer of enforcement where open(2) fails with -EACCES regardless
>   	 * of CAP_DAC_OVERRIDE if the permission doesn't have the

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] fs: kernfs: Corrected spelling mistake
  2019-04-02 11:44 [PATCH] fs: kernfs: Corrected spelling mistake Christina Quast
  2019-04-02 11:58 ` Mukesh Ojha
@ 2019-04-02 12:00 ` Greg Kroah-Hartman
  2019-04-02 12:27   ` [PATCH v2] " Christina Quast
  1 sibling, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-04-02 12:00 UTC (permalink / raw)
  To: Christina Quast; +Cc: trivial, Tejun Heo, linux-kernel

On Tue, Apr 02, 2019 at 01:44:14PM +0200, Christina Quast wrote:
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>

I can't take patches without any changelog text at all, sorry.

Please fix up and resend.

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2] fs: kernfs: Corrected spelling mistake
  2019-04-02 12:00 ` Greg Kroah-Hartman
@ 2019-04-02 12:27   ` Christina Quast
  2019-04-02 13:08     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 7+ messages in thread
From: Christina Quast @ 2019-04-02 12:27 UTC (permalink / raw)
  Cc: trivial, Christina Quast, Greg Kroah-Hartman, Tejun Heo, linux-kernel

flies => files

Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
---
 include/linux/kernfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index c8893f663470..e446ab97ee0c 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -64,7 +64,7 @@ enum kernfs_root_flag {
 	KERNFS_ROOT_CREATE_DEACTIVATED		= 0x0001,
 
 	/*
-	 * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
+	 * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
 	 * succeeds regardless of the RW permissions.  sysfs had an extra
 	 * layer of enforcement where open(2) fails with -EACCES regardless
 	 * of CAP_DAC_OVERRIDE if the permission doesn't have the
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] fs: kernfs: Corrected spelling mistake
  2019-04-02 12:27   ` [PATCH v2] " Christina Quast
@ 2019-04-02 13:08     ` Greg Kroah-Hartman
  2019-04-02 14:01       ` Christina Quast
  2019-04-02 15:45       ` Joe Perches
  0 siblings, 2 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-04-02 13:08 UTC (permalink / raw)
  To: Christina Quast; +Cc: trivial, Tejun Heo, linux-kernel

On Tue, Apr 02, 2019 at 02:27:06PM +0200, Christina Quast wrote:
> flies => files
> 
> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
> ---
>  include/linux/kernfs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v1?

That always goes below the --- line.

Remember, kernel maintainers have the short term memory of a squirrel :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2] fs: kernfs: Corrected spelling mistake
  2019-04-02 13:08     ` Greg Kroah-Hartman
@ 2019-04-02 14:01       ` Christina Quast
  2019-04-02 15:45       ` Joe Perches
  1 sibling, 0 replies; 7+ messages in thread
From: Christina Quast @ 2019-04-02 14:01 UTC (permalink / raw)
  To: gregkh; +Cc: trivial, Christina Quast, Tejun Heo, linux-kernel

flies => files

Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
---

Changes since v1:
	* Added changelog text

 include/linux/kernfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index c8893f663470..e446ab97ee0c 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -64,7 +64,7 @@ enum kernfs_root_flag {
 	KERNFS_ROOT_CREATE_DEACTIVATED		= 0x0001,
 
 	/*
-	 * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
+	 * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
 	 * succeeds regardless of the RW permissions.  sysfs had an extra
 	 * layer of enforcement where open(2) fails with -EACCES regardless
 	 * of CAP_DAC_OVERRIDE if the permission doesn't have the
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2] fs: kernfs: Corrected spelling mistake
  2019-04-02 13:08     ` Greg Kroah-Hartman
  2019-04-02 14:01       ` Christina Quast
@ 2019-04-02 15:45       ` Joe Perches
  1 sibling, 0 replies; 7+ messages in thread
From: Joe Perches @ 2019-04-02 15:45 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Christina Quast; +Cc: trivial, Tejun Heo, linux-kernel

On Tue, 2019-04-02 at 15:08 +0200, Greg Kroah-Hartman wrote:
> Remember, kernel maintainers have the short term memory of a squirrel :)
           ^ some



^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-02 15:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 11:44 [PATCH] fs: kernfs: Corrected spelling mistake Christina Quast
2019-04-02 11:58 ` Mukesh Ojha
2019-04-02 12:00 ` Greg Kroah-Hartman
2019-04-02 12:27   ` [PATCH v2] " Christina Quast
2019-04-02 13:08     ` Greg Kroah-Hartman
2019-04-02 14:01       ` Christina Quast
2019-04-02 15:45       ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).