linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi: spi-gpio: Remove spi->controller_data comment
@ 2019-04-03 14:46 Geert Uytterhoeven
  2019-04-04  6:04 ` Applied "spi: spi-gpio: Remove spi->controller_data comment" to the spi tree Mark Brown
  2019-04-08 11:11 ` [PATCH] spi: spi-gpio: Remove spi->controller_data comment Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-04-03 14:46 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linus Walleij, linux-spi, linux-kernel, Geert Uytterhoeven

The conversion from GPIO numbers to GPIO descriptors removed the use of
spi->controller_data, but forgot to update a comment referring to it.

Fixes: 9b00bc7b901ff672 ("spi: spi-gpio: Rewrite to use GPIO descriptors")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/spi/spi-gpio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index 53b35c56a557ae8a..f22db00b51e453b8 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -35,7 +35,6 @@
  * platform_device->driver_data ... points to spi_gpio
  *
  * spi->controller_state ... reserved for bitbang framework code
- * spi->controller_data ... holds chipselect GPIO
  *
  * spi->master->dev.driver_data ... points to spi_gpio->bitbang
  */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Applied "spi: spi-gpio: Remove spi->controller_data comment" to the spi tree
  2019-04-03 14:46 [PATCH] spi: spi-gpio: Remove spi->controller_data comment Geert Uytterhoeven
@ 2019-04-04  6:04 ` Mark Brown
  2019-04-08 11:11 ` [PATCH] spi: spi-gpio: Remove spi->controller_data comment Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-04-04  6:04 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Mark Brown, Mark Brown, Linus Walleij, linux-spi, linux-kernel,
	linux-spi

The patch

   spi: spi-gpio: Remove spi->controller_data comment

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 807195f2103f8662f8c0f9baf71dd7bc1a6b745b Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Wed, 3 Apr 2019 16:46:02 +0200
Subject: [PATCH] spi: spi-gpio: Remove spi->controller_data comment

The conversion from GPIO numbers to GPIO descriptors removed the use of
spi->controller_data, but forgot to update a comment referring to it.

Fixes: 9b00bc7b901ff672 ("spi: spi-gpio: Rewrite to use GPIO descriptors")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-gpio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index 3e98c1a0ba6d..e89348d95817 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -35,7 +35,6 @@
  * platform_device->driver_data ... points to spi_gpio
  *
  * spi->controller_state ... reserved for bitbang framework code
- * spi->controller_data ... holds chipselect GPIO
  *
  * spi->master->dev.driver_data ... points to spi_gpio->bitbang
  */
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: spi-gpio: Remove spi->controller_data comment
  2019-04-03 14:46 [PATCH] spi: spi-gpio: Remove spi->controller_data comment Geert Uytterhoeven
  2019-04-04  6:04 ` Applied "spi: spi-gpio: Remove spi->controller_data comment" to the spi tree Mark Brown
@ 2019-04-08 11:11 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-04-08 11:11 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Mark Brown, linux-spi, linux-kernel

On Wed, Apr 3, 2019 at 4:46 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The conversion from GPIO numbers to GPIO descriptors removed the use of
> spi->controller_data, but forgot to update a comment referring to it.
>
> Fixes: 9b00bc7b901ff672 ("spi: spi-gpio: Rewrite to use GPIO descriptors")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-08 11:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 14:46 [PATCH] spi: spi-gpio: Remove spi->controller_data comment Geert Uytterhoeven
2019-04-04  6:04 ` Applied "spi: spi-gpio: Remove spi->controller_data comment" to the spi tree Mark Brown
2019-04-08 11:11 ` [PATCH] spi: spi-gpio: Remove spi->controller_data comment Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).