* [PATCH] clocksource: timer-ti-dm: Remove unused omap_dm_timer_set_load_start
@ 2019-04-04 6:35 Keerthy
2019-04-04 14:15 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Keerthy @ 2019-04-04 6:35 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: tony, t-kristo, linux-omap, linux-kernel, j-keerthy
omap_dm_timer_set_load_start is no longer used hence delete the
function and remove the below warning.
drivers/clocksource/timer-ti-dm.c:589:12:
warning: ‘omap_dm_timer_set_load_start’ defined but not used
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/clocksource/timer-ti-dm.c | 28 ----------------------------
1 file changed, 28 deletions(-)
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index 3352da6ed61f..ee8ec5a8cb16 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer *timer, int autoreload,
return 0;
}
-/* Optimized set_load which removes costly spin wait in timer_start */
-static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
- int autoreload, unsigned int load)
-{
- u32 l;
-
- if (unlikely(!timer))
- return -EINVAL;
-
- omap_dm_timer_enable(timer);
-
- l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
- if (autoreload) {
- l |= OMAP_TIMER_CTRL_AR;
- omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
- } else {
- l &= ~OMAP_TIMER_CTRL_AR;
- }
- l |= OMAP_TIMER_CTRL_ST;
-
- __omap_dm_timer_load_start(timer, l, load, timer->posted);
-
- /* Save the context */
- timer->context.tclr = l;
- timer->context.tldr = load;
- timer->context.tcrr = load;
- return 0;
-}
static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
unsigned int match)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clocksource: timer-ti-dm: Remove unused omap_dm_timer_set_load_start
2019-04-04 6:35 [PATCH] clocksource: timer-ti-dm: Remove unused omap_dm_timer_set_load_start Keerthy
@ 2019-04-04 14:15 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2019-04-04 14:15 UTC (permalink / raw)
To: Keerthy; +Cc: daniel.lezcano, tglx, t-kristo, linux-omap, linux-kernel
* Keerthy <j-keerthy@ti.com> [190404 06:35]:
> omap_dm_timer_set_load_start is no longer used hence delete the
> function and remove the below warning.
>
> drivers/clocksource/timer-ti-dm.c:589:12:
> warning: ‘omap_dm_timer_set_load_start’ defined but not used
Hmm see earlier "[PATCH] clocksource/drivers/timer-ti-dm: Remove
omap_dm_timer_set_load_start", I think this is a duplicate.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-04 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 6:35 [PATCH] clocksource: timer-ti-dm: Remove unused omap_dm_timer_set_load_start Keerthy
2019-04-04 14:15 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).