From: Oscar Salvador <osalvador@suse.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
akpm@linux-foundation.org, will.deacon@arm.com,
catalin.marinas@arm.com, mhocko@suse.com,
mgorman@techsingularity.net, james.morse@arm.com,
mark.rutland@arm.com, cpandya@codeaurora.org,
arunks@codeaurora.org, dan.j.williams@intel.com,
logang@deltatee.com, pasha.tatashin@oracle.com, david@redhat.com,
cai@lca.pw, Steven Price <steven.price@arm.com>
Subject: Re: [PATCH 2/6] arm64/mm: Enable memory hot remove
Date: Thu, 4 Apr 2019 13:58:18 +0200 [thread overview]
Message-ID: <20190404115815.gzk3sgg34eofyxfv@d104.suse.de> (raw)
In-Reply-To: <55278a57-39bc-be27-5999-81d0da37b746@arm.com>
On Thu, Apr 04, 2019 at 11:09:22AM +0530, Anshuman Khandual wrote:
> > Do these need to be __meminit? AFAICS it's effectively redundant with the containing #ifdef, and removal feels like it's inherently a later-than-init thing anyway.
>
> I was confused here a bit but even X86 does exactly the same. All these functions
> are still labeled __meminit and all wrapped under CONFIG_MEMORY_HOTPLUG. Is there
> any concern to have __meminit here ?
We do not really need it as long as the code is within #ifdef CONFIG_MEMORY_HOTPLUG.
__meminit is being used when functions that are going to be need for hotplug need
to stay around.
/* Used for MEMORY_HOTPLUG */
#define __meminit __section(.meminit.text) __cold notrace \
__latent_entropy
#if defined(CONFIG_MEMORY_HOTPLUG)
#define MEM_KEEP(sec) *(.mem##sec)
#define MEM_DISCARD(sec)
#else
#define MEM_KEEP(sec)
#define MEM_DISCARD(sec) *(.mem##sec)
#endif
So it is kind of redundant to have both.
I will clean it up when reposting [1] and [2].
[1] https://patchwork.kernel.org/patch/10875019/
[2] https://patchwork.kernel.org/patch/10875021/
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-04-04 11:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 4:30 [PATCH 0/6] arm64/mm: Enable memory hot remove and ZONE_DEVICE Anshuman Khandual
2019-04-03 4:30 ` [PATCH 1/6] arm64/mm: Enable sysfs based memory hot add interface Anshuman Khandual
2019-04-03 8:20 ` David Hildenbrand
2019-04-03 13:12 ` Robin Murphy
2019-04-04 5:21 ` Anshuman Khandual
2019-04-04 5:25 ` Anshuman Khandual
2019-04-04 8:49 ` David Hildenbrand
2019-04-03 4:30 ` [PATCH 2/6] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-04-03 12:37 ` Robin Murphy
2019-04-03 13:15 ` Steven Price
2019-04-04 6:51 ` Anshuman Khandual
2019-04-04 5:39 ` Anshuman Khandual
2019-04-04 11:58 ` Oscar Salvador [this message]
2019-04-04 13:03 ` Anshuman Khandual
2019-04-04 15:19 ` Oscar Salvador
2019-04-03 17:32 ` Logan Gunthorpe
2019-04-03 17:57 ` Robin Murphy
2019-04-04 8:23 ` Anshuman Khandual
2019-04-04 7:07 ` Anshuman Khandual
2019-04-04 9:16 ` Steven Price
2019-04-03 4:30 ` [PATCH 3/6] arm64/mm: Enable struct page allocation from device memory Anshuman Khandual
2019-04-03 4:30 ` [PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory() Anshuman Khandual
2019-04-03 8:45 ` Oscar Salvador
2019-04-03 9:17 ` Michal Hocko
2019-04-04 8:32 ` Anshuman Khandual
2019-04-03 9:30 ` David Hildenbrand
2019-04-03 4:30 ` [PATCH 5/6] mm/memremap: Rename and consolidate SECTION_SIZE Anshuman Khandual
2019-04-03 9:26 ` Michal Hocko
2019-04-03 9:30 ` David Hildenbrand
2019-04-03 4:30 ` [PATCH 6/6] arm64/mm: Enable ZONE_DEVICE Anshuman Khandual
2019-04-03 13:58 ` Robin Murphy
2019-04-03 16:07 ` Jerome Glisse
2019-04-04 5:03 ` Anshuman Khandual
2019-04-04 4:42 ` Anshuman Khandual
2019-04-04 5:04 ` Dan Williams
2019-04-04 9:46 ` Robin Murphy
2019-04-07 22:11 ` Dan Williams
2019-04-08 4:03 ` Ira Weiny
2019-04-08 6:03 ` Anshuman Khandual
2019-04-03 18:08 ` [PATCH 0/6] arm64/mm: Enable memory hot remove and ZONE_DEVICE Dan Williams
2019-04-04 13:11 ` Anshuman Khandual
2019-04-04 9:46 ` [RFC 1/2] mm/vmemmap: Enable vmem_altmap based base page mapping for vmemmap Anshuman Khandual
2019-04-04 9:46 ` [RFC 2/2] arm64/mm: Enable ZONE_DEVICE for all page configs Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404115815.gzk3sgg34eofyxfv@d104.suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arunks@codeaurora.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@oracle.com \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).