From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Robin Murphy <robin.murphy@arm.com>,
David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
akpm@linux-foundation.org, will.deacon@arm.com,
catalin.marinas@arm.com
Cc: mhocko@suse.com, mgorman@techsingularity.net,
james.morse@arm.com, mark.rutland@arm.com,
cpandya@codeaurora.org, arunks@codeaurora.org,
dan.j.williams@intel.com, osalvador@suse.de, logang@deltatee.com,
cai@lca.pw
Subject: Re: [PATCH 1/6] arm64/mm: Enable sysfs based memory hot add interface
Date: Thu, 4 Apr 2019 10:51:03 +0530 [thread overview]
Message-ID: <514d246d-2619-08a9-bd1d-92d6b70b5a01@arm.com> (raw)
In-Reply-To: <e5665673-60ab-eee8-bc05-53dafb941039@arm.com>
On 04/03/2019 06:42 PM, Robin Murphy wrote:
> On 03/04/2019 09:20, David Hildenbrand wrote:
>> On 03.04.19 06:30, Anshuman Khandual wrote:
>>> Sysfs memory probe interface (/sys/devices/system/memory/probe) can accept
>>> starting physical address of an entire memory block to be hot added into
>>> the kernel. This is in addition to the existing ACPI based interface. This
>>> just enables it with the required config CONFIG_ARCH_MEMORY_PROBE.
>>>
>>
>> We recently discussed that the similar interface for removal should
>> rather be moved to a debug/test module
>>
>> I wonder if we should try to do the same for the sysfs probing
>> interface. Rather try to get rid of it than open the doors for more users.
>
> Agreed - if this option even exists in a released kernel, there's a risk that distros will turn it on for the sake of it, and at that point arm64 is stuck carrying the same ABI baggage as well.
True. Only if we really dont like that interface.
>
> If users turn up in future with a desperate and unavoidable need for the legacy half-an-API on arm64, we can always reconsider adding it at that point. It was very much deliberate that my original hot-add support did not include a patch like this one.
Sure. Will drop this one next time around.
next prev parent reply other threads:[~2019-04-04 5:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 4:30 [PATCH 0/6] arm64/mm: Enable memory hot remove and ZONE_DEVICE Anshuman Khandual
2019-04-03 4:30 ` [PATCH 1/6] arm64/mm: Enable sysfs based memory hot add interface Anshuman Khandual
2019-04-03 8:20 ` David Hildenbrand
2019-04-03 13:12 ` Robin Murphy
2019-04-04 5:21 ` Anshuman Khandual [this message]
2019-04-04 5:25 ` Anshuman Khandual
2019-04-04 8:49 ` David Hildenbrand
2019-04-03 4:30 ` [PATCH 2/6] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-04-03 12:37 ` Robin Murphy
2019-04-03 13:15 ` Steven Price
2019-04-04 6:51 ` Anshuman Khandual
2019-04-04 5:39 ` Anshuman Khandual
2019-04-04 11:58 ` Oscar Salvador
2019-04-04 13:03 ` Anshuman Khandual
2019-04-04 15:19 ` Oscar Salvador
2019-04-03 17:32 ` Logan Gunthorpe
2019-04-03 17:57 ` Robin Murphy
2019-04-04 8:23 ` Anshuman Khandual
2019-04-04 7:07 ` Anshuman Khandual
2019-04-04 9:16 ` Steven Price
2019-04-03 4:30 ` [PATCH 3/6] arm64/mm: Enable struct page allocation from device memory Anshuman Khandual
2019-04-03 4:30 ` [PATCH 4/6] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory() Anshuman Khandual
2019-04-03 8:45 ` Oscar Salvador
2019-04-03 9:17 ` Michal Hocko
2019-04-04 8:32 ` Anshuman Khandual
2019-04-03 9:30 ` David Hildenbrand
2019-04-03 4:30 ` [PATCH 5/6] mm/memremap: Rename and consolidate SECTION_SIZE Anshuman Khandual
2019-04-03 9:26 ` Michal Hocko
2019-04-03 9:30 ` David Hildenbrand
2019-04-03 4:30 ` [PATCH 6/6] arm64/mm: Enable ZONE_DEVICE Anshuman Khandual
2019-04-03 13:58 ` Robin Murphy
2019-04-03 16:07 ` Jerome Glisse
2019-04-04 5:03 ` Anshuman Khandual
2019-04-04 4:42 ` Anshuman Khandual
2019-04-04 5:04 ` Dan Williams
2019-04-04 9:46 ` Robin Murphy
2019-04-07 22:11 ` Dan Williams
2019-04-08 4:03 ` Ira Weiny
2019-04-08 6:03 ` Anshuman Khandual
2019-04-03 18:08 ` [PATCH 0/6] arm64/mm: Enable memory hot remove and ZONE_DEVICE Dan Williams
2019-04-04 13:11 ` Anshuman Khandual
2019-04-04 9:46 ` [RFC 1/2] mm/vmemmap: Enable vmem_altmap based base page mapping for vmemmap Anshuman Khandual
2019-04-04 9:46 ` [RFC 2/2] arm64/mm: Enable ZONE_DEVICE for all page configs Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514d246d-2619-08a9-bd1d-92d6b70b5a01@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arunks@codeaurora.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).