* [PATCH v2 1/5] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer
2019-04-01 11:56 [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 megous
@ 2019-04-01 11:56 ` megous
2019-04-01 12:54 ` Maxime Ripard
2019-04-01 11:56 ` [PATCH v2 2/5] ARM: dts: sun8i: a83t: Add UART2 PB pins megous
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: megous @ 2019-04-01 11:56 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland
Cc: Ondrej Jirman, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
From: Ondrej Jirman <megous@megous.com>
A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable
both the I2C1 bus and add the accelerometer device to it.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
index 1e840ab5a541..d70fe04b66f0 100644
--- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -156,6 +156,19 @@
status = "okay";
};
+&i2c1 {
+ clock-frequency = <400000>;
+ status = "okay";
+
+ /* Accelerometer */
+ accelerometer@18 {
+ compatible = "bosch,bma250";
+ reg = <0x18>;
+ interrupt-parent = <&pio>;
+ interrupts = <7 10 IRQ_TYPE_EDGE_RISING>; /* PH10 / EINT10 */
+ };
+};
+
&mmc0 {
vmmc-supply = <®_dcdc1>;
pinctrl-names = "default";
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/5] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer
2019-04-01 11:56 ` [PATCH v2 1/5] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer megous
@ 2019-04-01 12:54 ` Maxime Ripard
0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-04-01 12:54 UTC (permalink / raw)
To: megous
Cc: wens, robh, johan, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
Hi,
On Mon, Apr 01, 2019 at 01:56:12PM +0200, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable
> both the I2C1 bus and add the accelerometer device to it.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index 1e840ab5a541..d70fe04b66f0 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -156,6 +156,19 @@
> status = "okay";
> };
>
> +&i2c1 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + /* Accelerometer */
> + accelerometer@18 {
> + compatible = "bosch,bma250";
> + reg = <0x18>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 10 IRQ_TYPE_EDGE_RISING>; /* PH10 / EINT10 */
> + };
> +};
I've dropped the comment, since it's pretty obvious now, and applied, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 2/5] ARM: dts: sun8i: a83t: Add UART2 PB pins
2019-04-01 11:56 [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 megous
2019-04-01 11:56 ` [PATCH v2 1/5] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer megous
@ 2019-04-01 11:56 ` megous
2019-04-01 12:53 ` Maxime Ripard
2019-04-01 11:56 ` [PATCH v2 3/5] gnss: Add u-blox,neo-6m compatible megous
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: megous @ 2019-04-01 11:56 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland
Cc: Ondrej Jirman, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
From: Ondrej Jirman <megous@megous.com>
Add pin definitions for UART2 PB pins. These are used on TBS-A711
tablet.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index fcb7ef5ce2df..0176049d9815 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -768,6 +768,12 @@
pins = "PG8", "PG9";
function = "uart1";
};
+
+ /omit-if-no-ref/
+ uart2_pb_pins: uart2-pb-pins {
+ pins = "PB0", "PB1";
+ function = "uart2";
+ };
};
timer@1c20c00 {
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/5] ARM: dts: sun8i: a83t: Add UART2 PB pins
2019-04-01 11:56 ` [PATCH v2 2/5] ARM: dts: sun8i: a83t: Add UART2 PB pins megous
@ 2019-04-01 12:53 ` Maxime Ripard
0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-04-01 12:53 UTC (permalink / raw)
To: megous
Cc: wens, robh, johan, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
On Mon, Apr 01, 2019 at 01:56:13PM +0200, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Add pin definitions for UART2 PB pins. These are used on TBS-A711
> tablet.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 3/5] gnss: Add u-blox,neo-6m compatible
2019-04-01 11:56 [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 megous
2019-04-01 11:56 ` [PATCH v2 1/5] ARM: dts: sun8i: tbs-a711: Add node for BMA250 accelerometer megous
2019-04-01 11:56 ` [PATCH v2 2/5] ARM: dts: sun8i: a83t: Add UART2 PB pins megous
@ 2019-04-01 11:56 ` megous
2019-04-01 11:56 ` [PATCH v2 4/5] dt-bindings: " megous
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: megous @ 2019-04-01 11:56 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland
Cc: Ondrej Jirman, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
From: Ondrej Jirman <megous@megous.com>
Add compatible for u-blox NEO-6M GPS module.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
drivers/gnss/ubx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gnss/ubx.c b/drivers/gnss/ubx.c
index 12568aebb7f6..1ada2fad1d4e 100644
--- a/drivers/gnss/ubx.c
+++ b/drivers/gnss/ubx.c
@@ -132,6 +132,7 @@ static void ubx_remove(struct serdev_device *serdev)
static const struct of_device_id ubx_of_match[] = {
{ .compatible = "u-blox,neo-8" },
{ .compatible = "u-blox,neo-m8" },
+ { .compatible = "u-blox,neo-6m" },
{},
};
MODULE_DEVICE_TABLE(of, ubx_of_match);
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 4/5] dt-bindings: gnss: Add u-blox,neo-6m compatible
2019-04-01 11:56 [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 megous
` (2 preceding siblings ...)
2019-04-01 11:56 ` [PATCH v2 3/5] gnss: Add u-blox,neo-6m compatible megous
@ 2019-04-01 11:56 ` megous
2019-04-01 12:02 ` [linux-sunxi] " Ondřej Jirman
2019-04-01 11:56 ` [PATCH v2 5/5] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module) megous
2019-04-02 8:28 ` [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 Johan Hovold
5 siblings, 1 reply; 13+ messages in thread
From: megous @ 2019-04-01 11:56 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland
Cc: Ondrej Jirman, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
From: Ondrej Jirman <megous@megous.com>
Add compatible for u-blox NEO-6M GPS module.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
Documentation/devicetree/bindings/gnss/u-blox.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/gnss/u-blox.txt b/Documentation/devicetree/bindings/gnss/u-blox.txt
index e475659cb85f..7cdefd058fe0 100644
--- a/Documentation/devicetree/bindings/gnss/u-blox.txt
+++ b/Documentation/devicetree/bindings/gnss/u-blox.txt
@@ -9,6 +9,7 @@ Required properties:
- compatible : Must be one of
+ "u-blox,neo-6m"
"u-blox,neo-8"
"u-blox,neo-m8"
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [linux-sunxi] [PATCH v2 4/5] dt-bindings: gnss: Add u-blox,neo-6m compatible
2019-04-01 11:56 ` [PATCH v2 4/5] dt-bindings: " megous
@ 2019-04-01 12:02 ` Ondřej Jirman
2019-04-04 10:45 ` Johan Hovold
0 siblings, 1 reply; 13+ messages in thread
From: Ondřej Jirman @ 2019-04-01 12:02 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
On Mon, Apr 01, 2019 at 01:56:15PM +0200, megous via linux-sunxi wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Add compatible for u-blox NEO-6M GPS module.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
Ouch, I forgot to add:
Reviewed-by: Rob Herring <robh@kernel.org>
I'll do v3 if necessary, for this.
regards,
Ondrej
> ---
> Documentation/devicetree/bindings/gnss/u-blox.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox.txt b/Documentation/devicetree/bindings/gnss/u-blox.txt
> index e475659cb85f..7cdefd058fe0 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox.txt
> +++ b/Documentation/devicetree/bindings/gnss/u-blox.txt
> @@ -9,6 +9,7 @@ Required properties:
>
> - compatible : Must be one of
>
> + "u-blox,neo-6m"
> "u-blox,neo-8"
> "u-blox,neo-m8"
>
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [linux-sunxi] [PATCH v2 4/5] dt-bindings: gnss: Add u-blox,neo-6m compatible
2019-04-01 12:02 ` [linux-sunxi] " Ondřej Jirman
@ 2019-04-04 10:45 ` Johan Hovold
0 siblings, 0 replies; 13+ messages in thread
From: Johan Hovold @ 2019-04-04 10:45 UTC (permalink / raw)
To: Ondřej Jirman
Cc: maxime.ripard, wens, robh, johan, mark.rutland, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
On Mon, Apr 01, 2019 at 02:02:09PM +0200, Ondřej Jirman wrote:
> On Mon, Apr 01, 2019 at 01:56:15PM +0200, megous via linux-sunxi wrote:
> > From: Ondrej Jirman <megous@megous.com>
> >
> > Add compatible for u-blox NEO-6M GPS module.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
>
> Ouch, I forgot to add:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> I'll do v3 if necessary, for this.
Looks good to me too.
Now applied with Robs ack along with the ubx-driver patch.
Thanks,
Johan
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 5/5] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module)
2019-04-01 11:56 [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 megous
` (3 preceding siblings ...)
2019-04-01 11:56 ` [PATCH v2 4/5] dt-bindings: " megous
@ 2019-04-01 11:56 ` megous
2019-04-04 12:43 ` [linux-sunxi] " Ondřej Jirman
2019-04-02 8:28 ` [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 Johan Hovold
5 siblings, 1 reply; 13+ messages in thread
From: megous @ 2019-04-01 11:56 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland
Cc: Ondrej Jirman, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi
From: Ondrej Jirman <megous@megous.com>
TBS A711 tablet contains u-blox NEO-6M module connected to UART2.
Enable UART2 to gain access to the module from userspace.
Signed-off-by: Ondrej Jirman <megous@megous.com>
---
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
index d70fe04b66f0..fd170bc45927 100644
--- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -98,6 +98,13 @@
};
};
+ reg_gps: reg-gps {
+ compatible = "regulator-fixed";
+ regulator-name = "gps";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
reg_vbat: reg-vbat {
compatible = "regulator-fixed";
regulator-name = "vbat";
@@ -422,6 +429,20 @@
status = "okay";
};
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pb_pins>;
+ status = "okay";
+
+ gnss {
+ compatible = "u-blox,neo-6m";
+
+ v-bckp-supply = <®_rtc_ldo>;
+ vcc-supply = <®_gps>;
+ current-speed = <9600>;
+ };
+};
+
&usb_otg {
dr_mode = "otg";
status = "okay";
--
2.21.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [linux-sunxi] [PATCH v2 5/5] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module)
2019-04-01 11:56 ` [PATCH v2 5/5] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module) megous
@ 2019-04-04 12:43 ` Ondřej Jirman
2019-04-05 15:07 ` Maxime Ripard
0 siblings, 1 reply; 13+ messages in thread
From: Ondřej Jirman @ 2019-04-04 12:43 UTC (permalink / raw)
To: maxime.ripard, wens, robh, johan, mark.rutland, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Hello Maxime,
On Mon, Apr 01, 2019 at 01:56:16PM +0200, megous via linux-sunxi wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> TBS A711 tablet contains u-blox NEO-6M module connected to UART2.
> Enable UART2 to gain access to the module from userspace.
Other GPS bits are now applied (thank you, Johan), so if this last bit
can go in too via a sunxi tree, the series will be complete.
thank you,
Ondrej
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
> arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index d70fe04b66f0..fd170bc45927 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> @@ -98,6 +98,13 @@
> };
> };
>
> + reg_gps: reg-gps {
> + compatible = "regulator-fixed";
> + regulator-name = "gps";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + };
> +
> reg_vbat: reg-vbat {
> compatible = "regulator-fixed";
> regulator-name = "vbat";
> @@ -422,6 +429,20 @@
> status = "okay";
> };
>
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pb_pins>;
> + status = "okay";
> +
> + gnss {
> + compatible = "u-blox,neo-6m";
> +
> + v-bckp-supply = <®_rtc_ldo>;
> + vcc-supply = <®_gps>;
> + current-speed = <9600>;
> + };
> +};
> +
> &usb_otg {
> dr_mode = "otg";
> status = "okay";
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [linux-sunxi] [PATCH v2 5/5] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module)
2019-04-04 12:43 ` [linux-sunxi] " Ondřej Jirman
@ 2019-04-05 15:07 ` Maxime Ripard
0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-04-05 15:07 UTC (permalink / raw)
To: wens, robh, johan, mark.rutland, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
On Thu, Apr 04, 2019 at 02:43:22PM +0200, Ondřej Jirman wrote:
> Hello Maxime,
>
> On Mon, Apr 01, 2019 at 01:56:16PM +0200, megous via linux-sunxi wrote:
> > From: Ondrej Jirman <megous@megous.com>
> >
> > TBS A711 tablet contains u-blox NEO-6M module connected to UART2.
> > Enable UART2 to gain access to the module from userspace.
>
> Other GPS bits are now applied (thank you, Johan), so if this last bit
> can go in too via a sunxi tree, the series will be complete.
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711
2019-04-01 11:56 [PATCH v2 0/5] Add bluetooth, gps and accelerometer to TBS A711 megous
` (4 preceding siblings ...)
2019-04-01 11:56 ` [PATCH v2 5/5] ARM: dts: sun8i: tbs-a711: Enable UART2 (for NEO-6M GPS module) megous
@ 2019-04-02 8:28 ` Johan Hovold
5 siblings, 0 replies; 13+ messages in thread
From: Johan Hovold @ 2019-04-02 8:28 UTC (permalink / raw)
To: megous
Cc: maxime.ripard, wens, robh, johan, mark.rutland, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
On Mon, Apr 01, 2019 at 01:56:11PM +0200, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> This series enables some peripherals on TBS A711 tablet that already
> have mainline drivers:
>
> - GPS u-blox neo-6m (via gnss u-blox driver)
> - Bluetooth (via recently added OF support in the Broadcom
> bluetooth driver)
> - Accelermomter BMA-250 (hooked to the I2C bus)
>
> It also modifies A83T DTSI and adds missing UART interfaces.
>
> I've added additional compatible to the gnss/u-blox driver for NEO-6M,
> because this board uses this module, and I don't think I can use
> the existing compatible for u-blox,neo-m8, even as a fallback.
>
> Please take a look, and apply the patches if you have no objections.
>
> Many of the patches will go through the sunxi tree, but I'm not
> sure who will want to take the GPS patches.
I'll take the GPS patches through my tree once I've had a chance to
review them. Perhaps easiest to resend the corresponding dts change once
that is done.
Johan
^ permalink raw reply [flat|nested] 13+ messages in thread