linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org,
	vkoul@kernel.org, gregkh@linuxfoundation.org,
	liam.r.girdwood@linux.intel.com, jank@cadence.com,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 0/3] soundwire: code cleanup
Date: Thu,  4 Apr 2019 13:22:01 -0500	[thread overview]
Message-ID: <20190404182204.31262-1-pierre-louis.bossart@linux.intel.com> (raw)

SoundWire support will be provided in Linux with the Sound Open
Firmware (SOF) on Intel platforms. Before we start adding the missing
pieces, there are a number of warnings and style issues reported by
checkpatch, cppcheck and Coccinelle that need to be cleaned-up.

While I am at it, I could use feedback from maintainers. We are ready
to release a number of required patches that were not provided
earlier, but the initial contributors have either left Intel or moved
on to other domains. While I'd like to give them credit for their
work, I don't think leaving the email addresses as is is a good
solution (email bounces, etc). I also don't think providing a
non-Intel address is correct since the work was funded by Intel. Is
there a recommended practice here?

Pierre-Louis Bossart (3):
  soundwire: fix style issues
  soundwire: bus: remove useless initializations
  soundwire: stream: remove useless initialization of local variable

 drivers/soundwire/Kconfig          |   2 +-
 drivers/soundwire/bus.c            |  89 ++++++++--------
 drivers/soundwire/bus.h            |  16 +--
 drivers/soundwire/bus_type.c       |   4 +-
 drivers/soundwire/cadence_master.c |  87 +++++++--------
 drivers/soundwire/cadence_master.h |  22 ++--
 drivers/soundwire/intel.c          |  89 ++++++++--------
 drivers/soundwire/intel.h          |   4 +-
 drivers/soundwire/intel_init.c     |  12 +--
 drivers/soundwire/mipi_disco.c     | 116 +++++++++++---------
 drivers/soundwire/slave.c          |  10 +-
 drivers/soundwire/stream.c         | 163 +++++++++++++++--------------
 12 files changed, 315 insertions(+), 299 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-04-04 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 18:22 Pierre-Louis Bossart [this message]
2019-04-04 18:22 ` [PATCH 1/3] soundwire: fix style issues Pierre-Louis Bossart
2019-04-04 19:28   ` Joe Perches
2019-04-04 19:37     ` [alsa-devel] " Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 2/3] soundwire: bus: remove useless initializations Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 3/3] soundwire: stream: remove useless initialization of local variable Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404182204.31262-1-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).