From: Joe Perches <joe@perches.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org,
liam.r.girdwood@linux.intel.com, jank@cadence.com,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH 1/3] soundwire: fix style issues
Date: Thu, 04 Apr 2019 12:28:28 -0700 [thread overview]
Message-ID: <98050a8abfdd9ec015d4de846b276cf046115e3f.camel@perches.com> (raw)
In-Reply-To: <20190404182204.31262-2-pierre-louis.bossart@linux.intel.com>
On Thu, 2019-04-04 at 13:22 -0500, Pierre-Louis Bossart wrote:
> Visual inspections confirmed by checkpatch.pl --strict expose a number
> of style issues, specifically parameter alignment is inconsistent as
> if different contributors used different styles. Before we restart
> support for SoundWire with Sound Open Firmware on Intel platforms,
> let's clean all this.
>
> Fix Kconfig help, spelling, SPDX format, alignment, spurious
> parentheses, bool comparisons to true/false, macro argument
> protection.
>
> No new functionality added.
[]
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
[]
> @@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave *slave)
> mutex_unlock(&slave->bus->bus_lock);
> if (dev_num < 0) {
> dev_err(slave->bus->dev, "Get dev_num failed: %d",
> - dev_num);
> + dev_num);
You could also add the missing terminating '\n' to these formats like:
dev_err(slave->bus->dev, "Get dev_num failed: %d\n",
> return dev_num;
> }
> } else {
> dev_info(slave->bus->dev,
> - "Slave already registered dev_num:%d",
> - slave->dev_num);
> + "Slave already registered dev_num:%d",
> + slave->dev_num);
etc...
next prev parent reply other threads:[~2019-04-04 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 18:22 [PATCH 0/3] soundwire: code cleanup Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 1/3] soundwire: fix style issues Pierre-Louis Bossart
2019-04-04 19:28 ` Joe Perches [this message]
2019-04-04 19:37 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 2/3] soundwire: bus: remove useless initializations Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 3/3] soundwire: stream: remove useless initialization of local variable Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98050a8abfdd9ec015d4de846b276cf046115e3f.camel@perches.com \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).