* [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators
@ 2019-04-05 12:24 Clément Péron
2019-04-05 12:24 ` [PATCH v2 2/5] arm64: dts: allwinner: h6: pine64: " Clément Péron
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 12:24 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi,
Clément Péron
OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
Add this in the common device tree.
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
index b2526dac2fcf..fd2af5095425 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
@@ -72,6 +72,12 @@
status = "okay";
};
+&pio {
+ vcc-pc-supply = <®_bldo2>;
+ vcc-pd-supply = <®_cldo1>;
+ vcc-pg-supply = <®_bldo3>;
+};
+
&r_i2c {
status = "okay";
@@ -191,6 +197,11 @@
};
};
+&r_pio {
+ vcc-pl-supply = <®_aldo1>;
+ vcc-pm-supply = <®_bldo3>;
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_ph_pins>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 2/5] arm64: dts: allwinner: h6: pine64: Add PIO regulators
2019-04-05 12:24 [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Clément Péron
@ 2019-04-05 12:24 ` Clément Péron
2019-04-05 12:24 ` [PATCH v2 3/5] arm64: dts: allwinner: h6: move MMC pinctrl to dtsi Clément Péron
` (3 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 12:24 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi,
Clément Péron
Add PIO regulators for Pine64 board.
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index bdb8470fc8dc..8b0b7675a53c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -131,6 +131,12 @@
status = "okay";
};
+&pio {
+ vcc-pc-supply = <®_bldo2>;
+ vcc-pd-supply = <®_cldo1>;
+ vcc-pg-supply = <®_bldo2>;
+};
+
&r_i2c {
status = "okay";
@@ -251,6 +257,11 @@
};
};
+&r_pio {
+ vcc-pl-supply = <®_aldo1>;
+ vcc-pm-supply = <®_bldo2>;
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_ph_pins>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 3/5] arm64: dts: allwinner: h6: move MMC pinctrl to dtsi
2019-04-05 12:24 [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Clément Péron
2019-04-05 12:24 ` [PATCH v2 2/5] arm64: dts: allwinner: h6: pine64: " Clément Péron
@ 2019-04-05 12:24 ` Clément Péron
2019-04-05 12:24 ` [PATCH v2 4/5] dt-bindings: vendor-prefixes: add AZW Clément Péron
` (2 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 12:24 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi,
Clément Péron
There is only one pinmuxing available for each MMC controller.
Move the pinctrl to the SOC
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 2 --
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 4 ----
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
index fd2af5095425..88b3a13f2360 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
@@ -56,8 +56,6 @@
};
&mmc0 {
- pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins>;
vmmc-supply = <®_cldo1>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
bus-width = <4>;
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index 8b0b7675a53c..d8b0138be3d6 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -104,8 +104,6 @@
};
&mmc0 {
- pinctrl-names = "default";
- pinctrl-0 = <&mmc0_pins>;
vmmc-supply = <®_cldo1>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
bus-width = <4>;
@@ -113,8 +111,6 @@
};
&mmc2 {
- pinctrl-names = "default";
- pinctrl-0 = <&mmc2_pins>;
vmmc-supply = <®_cldo1>;
vqmmc-supply = <®_bldo2>;
non-removable;
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 91fecab58836..93ad756c0c95 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
@@ -273,6 +273,8 @@
resets = <&ccu RST_BUS_MMC0>;
reset-names = "ahb";
interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc0_pins>;
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
@@ -301,6 +303,8 @@
resets = <&ccu RST_BUS_MMC2>;
reset-names = "ahb";
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc0_pins>;
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 4/5] dt-bindings: vendor-prefixes: add AZW
2019-04-05 12:24 [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Clément Péron
2019-04-05 12:24 ` [PATCH v2 2/5] arm64: dts: allwinner: h6: pine64: " Clément Péron
2019-04-05 12:24 ` [PATCH v2 3/5] arm64: dts: allwinner: h6: move MMC pinctrl to dtsi Clément Péron
@ 2019-04-05 12:24 ` Clément Péron
2019-04-05 12:42 ` Robin Murphy
2019-04-05 12:24 ` [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board Clément Péron
2019-04-05 15:08 ` [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Maxime Ripard
4 siblings, 1 reply; 13+ messages in thread
From: Clément Péron @ 2019-04-05 12:24 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi,
Clément Péron
Shenzhen AZW Technology Co. Ltd. is a manufacturer specialized in Android
smart TV boxes, Intel mini PCs and home cloud TV boxes with NAS.
Add the vendor prefix for AZW.
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 8b4ae37629b2..8313edbaf52e 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -54,6 +54,7 @@ avic Shanghai AVIC Optoelectronics Co., Ltd.
avnet Avnet, Inc.
axentia Axentia Technologies AB
axis Axis Communications AB
+azw Shenzhen AZW Technology Co., Ltd.
bananapi BIPAI KEJI LIMITED
bhf Beckhoff Automation GmbH & Co. KG
bitmain Bitmain Technologies
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board
2019-04-05 12:24 [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Clément Péron
` (2 preceding siblings ...)
2019-04-05 12:24 ` [PATCH v2 4/5] dt-bindings: vendor-prefixes: add AZW Clément Péron
@ 2019-04-05 12:24 ` Clément Péron
2019-04-05 12:53 ` Clément Péron
2019-04-05 15:10 ` Maxime Ripard
2019-04-05 15:08 ` [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Maxime Ripard
4 siblings, 2 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 12:24 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi,
Clément Péron
Beelink GS1 is an Allwinner H6 based TV box,
which support:
- Allwinner H6 Quad-core 64-bit ARM Cortex-A53
- GPU Mali-T720
- 2GB LPDDR3 RAM
- AXP805 PMIC
- 1Gbps GMAC via RTL8211E
- FN-Link 6222B-SRB Wifi/BT
- 1x USB 2.0 Host and 1x USB 3.0 Host
- HDMI port
- S/PDIF Tx
- IR receiver
- 5V/2A DC power supply
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on
the OrangePi One Plus and Pine H64.
Changes in v2 (Thanks to Maxime Ripard):
- move MMC pinctrl to SOC dtsi
- add board to Sunxi YAML file
- add PIO/R_PIO regulators
- remove always_on from SDIO regulators
.../devicetree/bindings/arm/sunxi.yaml | 5 +
arch/arm64/boot/dts/allwinner/Makefile | 1 +
.../dts/allwinner/sun50i-h6-beelink-gs1.dts | 256 ++++++++++++++++++
3 files changed, 262 insertions(+)
create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 11563d3f7c65..9ab9b266881d 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -136,6 +136,11 @@ properties:
- const: lemaker,bananapro
- const: allwinner,sun7i-a20
+ - description: Beelink GS1
+ items:
+ - const: azw,beelink-gs1
+ - const: allwinner,sun50i-h6
+
- description: Beelink X2
items:
- const: roofull,beelink-x2
diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
index e4dce2f6fa3a..2dd806a3d5c9 100644
--- a/arch/arm64/boot/dts/allwinner/Makefile
+++ b/arch/arm64/boot/dts/allwinner/Makefile
@@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-beelink-gs1.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
new file mode 100644
index 000000000000..d820a138522b
--- /dev/null
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
@@ -0,0 +1,256 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2019 Clément Péron <peron.clem@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "sun50i-h6.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+ model = "Beelink GS1";
+ compatible = "azw,beelink-gs1", "allwinner,sun50i-h6";
+
+ aliases {
+ ethernet0 = &emac;
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ connector {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ power {
+ label = "beelink:white:power";
+ gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
+ default-state = "on";
+ };
+ };
+
+ reg_vcc5v: vcc5v {
+ /* board wide 5V supply directly from the DC jack */
+ compatible = "regulator-fixed";
+ regulator-name = "vcc-5v";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ };
+};
+
+&de {
+ status = "okay";
+};
+
+&ehci0 {
+ status = "okay";
+};
+
+&emac {
+ pinctrl-names = "default";
+ pinctrl-0 = <&ext_rgmii_pins>;
+ phy-mode = "rgmii";
+ phy-handle = <&ext_rgmii_phy>;
+ phy-supply = <®_aldo2>;
+ allwinner,rx-delay-ps = <0>;
+ allwinner,tx-delay-ps = <0>;
+ status = "okay";
+};
+
+&hdmi {
+ status = "okay";
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&mdio {
+ ext_rgmii_phy: ethernet-phy@1 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <1>;
+ };
+};
+
+&mmc0 {
+ vmmc-supply = <®_cldo1>;
+ cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
+ bus-width = <4>;
+ status = "okay";
+};
+
+&mmc2 {
+ vmmc-supply = <®_cldo1>;
+ vqmmc-supply = <®_bldo2>;
+ non-removable;
+ cap-mmc-hw-reset;
+ bus-width = <8>;
+ status = "okay";
+};
+
+&ohci0 {
+ status = "okay";
+};
+
+&pio {
+ vcc-pd-supply = <®_cldo1>;
+ vcc-pg-supply = <®_aldo1>;
+};
+
+&r_i2c {
+ status = "okay";
+
+ axp805: pmic@36 {
+ compatible = "x-powers,axp805", "x-powers,axp806";
+ reg = <0x36>;
+ interrupt-parent = <&r_intc>;
+ interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ x-powers,self-working-mode;
+ vina-supply = <®_vcc5v>;
+ vinb-supply = <®_vcc5v>;
+ vinc-supply = <®_vcc5v>;
+ vind-supply = <®_vcc5v>;
+ vine-supply = <®_vcc5v>;
+ aldoin-supply = <®_vcc5v>;
+ bldoin-supply = <®_vcc5v>;
+ cldoin-supply = <®_vcc5v>;
+
+ regulators {
+ reg_aldo1: aldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc-pl";
+ };
+
+ reg_aldo2: aldo2 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc-ac200";
+ regulator-enable-ramp-delay = <100000>;
+ };
+
+ reg_aldo3: aldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc25-dram";
+ };
+
+ reg_bldo1: bldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc-bias-pll";
+ };
+
+ reg_bldo2: bldo2 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc-efuse-pcie-hdmi-io";
+ };
+
+ reg_bldo3: bldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc-dcxoio";
+ };
+
+ bldo4 {
+ /* unused */
+ };
+
+ reg_cldo1: cldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc-3v3";
+ };
+
+ reg_cldo2: cldo2 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc-wifi-1";
+ };
+
+ reg_cldo3: cldo3 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc-wifi-2";
+ };
+
+ reg_dcdca: dcdca {
+ regulator-always-on;
+ regulator-min-microvolt = <810000>;
+ regulator-max-microvolt = <1080000>;
+ regulator-name = "vdd-cpu";
+ };
+
+ reg_dcdcc: dcdcc {
+ regulator-min-microvolt = <810000>;
+ regulator-max-microvolt = <1080000>;
+ regulator-name = "vdd-gpu";
+ };
+
+ reg_dcdcd: dcdcd {
+ regulator-always-on;
+ regulator-min-microvolt = <960000>;
+ regulator-max-microvolt = <960000>;
+ regulator-name = "vdd-sys";
+ };
+
+ reg_dcdce: dcdce {
+ regulator-always-on;
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-name = "vcc-dram";
+ };
+
+ sw {
+ /* unused */
+ };
+ };
+ };
+};
+
+&r_pio {
+ vcc-pl-supply = <®_aldo1>;
+ vcc-pm-supply = <®_aldo1>;
+};
+
+&uart0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart0_ph_pins>;
+ status = "okay";
+};
+
+&usb2otg {
+ dr_mode = "host";
+ status = "okay";
+};
+
+&usb2phy {
+ usb0_vbus-supply = <®_vcc5v>;
+ status = "okay";
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 4/5] dt-bindings: vendor-prefixes: add AZW
2019-04-05 12:24 ` [PATCH v2 4/5] dt-bindings: vendor-prefixes: add AZW Clément Péron
@ 2019-04-05 12:42 ` Robin Murphy
0 siblings, 0 replies; 13+ messages in thread
From: Robin Murphy @ 2019-04-05 12:42 UTC (permalink / raw)
To: Clément Péron, Rob Herring, Maxime Ripard,
Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-sunxi, linux-kernel, linux-arm-kernel
On 05/04/2019 13:24, Clément Péron wrote:
> Shenzhen AZW Technology Co. Ltd. is a manufacturer specialized in Android
> smart TV boxes, Intel mini PCs and home cloud TV boxes with NAS.
>
> Add the vendor prefix for AZW.
Yay, I've been hacking on a Beelink A1 so this will be one less patch to
worry about if I ever get it finished enough to upstream :)
(I had picked "beelink" as a prefix, but I guess "azw" does seem more
appropriate to cover their OEM stuff as well, so there's no good reason
to treat the in-house brand specially)
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 8b4ae37629b2..8313edbaf52e 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -54,6 +54,7 @@ avic Shanghai AVIC Optoelectronics Co., Ltd.
> avnet Avnet, Inc.
> axentia Axentia Technologies AB
> axis Axis Communications AB
> +azw Shenzhen AZW Technology Co., Ltd.
> bananapi BIPAI KEJI LIMITED
> bhf Beckhoff Automation GmbH & Co. KG
> bitmain Bitmain Technologies
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board
2019-04-05 12:24 ` [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board Clément Péron
@ 2019-04-05 12:53 ` Clément Péron
2019-04-05 13:07 ` Clément Péron
2019-04-05 15:11 ` Maxime Ripard
2019-04-05 15:10 ` Maxime Ripard
1 sibling, 2 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 12:53 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi
Hi,
Adding this r_pio regulators make a new error in the bootlog :
[ 0.346843] sun50i-h6-r-pinctrl 7022000.pinctrl: Couldn't get bank
PL regulator
[ 0.346853] sun50i-h6-r-pinctrl 7022000.pinctrl: request() failed for pin 352
[ 0.346862] sun50i-h6-r-pinctrl 7022000.pinctrl: pin-352
(7081400.i2c) status -517
[ 0.346871] sun50i-h6-r-pinctrl 7022000.pinctrl: could not request
pin 352 (PL0) from group PL0 on device 7022000.pinctrl
[ 0.346878] mv64xxx_i2c 7081400.i2c: Error applying setting,
reverse things back
PL0 and PL1 are SCK/SDA for the PMIC :(
Clement
On Fri, 5 Apr 2019 at 14:21, Clément Péron <peron.clem@gmail.com> wrote:
>
> Beelink GS1 is an Allwinner H6 based TV box,
> which support:
> - Allwinner H6 Quad-core 64-bit ARM Cortex-A53
> - GPU Mali-T720
> - 2GB LPDDR3 RAM
> - AXP805 PMIC
> - 1Gbps GMAC via RTL8211E
> - FN-Link 6222B-SRB Wifi/BT
> - 1x USB 2.0 Host and 1x USB 3.0 Host
> - HDMI port
> - S/PDIF Tx
> - IR receiver
> - 5V/2A DC power supply
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>
> Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on
> the OrangePi One Plus and Pine H64.
>
> Changes in v2 (Thanks to Maxime Ripard):
> - move MMC pinctrl to SOC dtsi
> - add board to Sunxi YAML file
> - add PIO/R_PIO regulators
> - remove always_on from SDIO regulators
>
>
> .../devicetree/bindings/arm/sunxi.yaml | 5 +
> arch/arm64/boot/dts/allwinner/Makefile | 1 +
> .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 256 ++++++++++++++++++
> 3 files changed, 262 insertions(+)
> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 11563d3f7c65..9ab9b266881d 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -136,6 +136,11 @@ properties:
> - const: lemaker,bananapro
> - const: allwinner,sun7i-a20
>
> + - description: Beelink GS1
> + items:
> + - const: azw,beelink-gs1
> + - const: allwinner,sun50i-h6
> +
> - description: Beelink X2
> items:
> - const: roofull,beelink-x2
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> index e4dce2f6fa3a..2dd806a3d5c9 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-beelink-gs1.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> new file mode 100644
> index 000000000000..d820a138522b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -0,0 +1,256 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2019 Clément Péron <peron.clem@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h6.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "Beelink GS1";
> + compatible = "azw,beelink-gs1", "allwinner,sun50i-h6";
> +
> + aliases {
> + ethernet0 = &emac;
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + connector {
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi_con_in: endpoint {
> + remote-endpoint = <&hdmi_out_con>;
> + };
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + power {
> + label = "beelink:white:power";
> + gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
> + default-state = "on";
> + };
> + };
> +
> + reg_vcc5v: vcc5v {
> + /* board wide 5V supply directly from the DC jack */
> + compatible = "regulator-fixed";
> + regulator-name = "vcc-5v";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> +};
> +
> +&de {
> + status = "okay";
> +};
> +
> +&ehci0 {
> + status = "okay";
> +};
> +
> +&emac {
> + pinctrl-names = "default";
> + pinctrl-0 = <&ext_rgmii_pins>;
> + phy-mode = "rgmii";
> + phy-handle = <&ext_rgmii_phy>;
> + phy-supply = <®_aldo2>;
> + allwinner,rx-delay-ps = <0>;
> + allwinner,tx-delay-ps = <0>;
> + status = "okay";
> +};
> +
> +&hdmi {
> + status = "okay";
> +};
> +
> +&hdmi_out {
> + hdmi_out_con: endpoint {
> + remote-endpoint = <&hdmi_con_in>;
> + };
> +};
> +
> +&mdio {
> + ext_rgmii_phy: ethernet-phy@1 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <1>;
> + };
> +};
> +
> +&mmc0 {
> + vmmc-supply = <®_cldo1>;
> + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
> + bus-width = <4>;
> + status = "okay";
> +};
> +
> +&mmc2 {
> + vmmc-supply = <®_cldo1>;
> + vqmmc-supply = <®_bldo2>;
> + non-removable;
> + cap-mmc-hw-reset;
> + bus-width = <8>;
> + status = "okay";
> +};
> +
> +&ohci0 {
> + status = "okay";
> +};
> +
> +&pio {
> + vcc-pd-supply = <®_cldo1>;
> + vcc-pg-supply = <®_aldo1>;
> +};
> +
> +&r_i2c {
> + status = "okay";
> +
> + axp805: pmic@36 {
> + compatible = "x-powers,axp805", "x-powers,axp806";
> + reg = <0x36>;
> + interrupt-parent = <&r_intc>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + x-powers,self-working-mode;
> + vina-supply = <®_vcc5v>;
> + vinb-supply = <®_vcc5v>;
> + vinc-supply = <®_vcc5v>;
> + vind-supply = <®_vcc5v>;
> + vine-supply = <®_vcc5v>;
> + aldoin-supply = <®_vcc5v>;
> + bldoin-supply = <®_vcc5v>;
> + cldoin-supply = <®_vcc5v>;
> +
> + regulators {
> + reg_aldo1: aldo1 {
> + regulator-always-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "vcc-pl";
> + };
> +
> + reg_aldo2: aldo2 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "vcc-ac200";
> + regulator-enable-ramp-delay = <100000>;
> + };
> +
> + reg_aldo3: aldo3 {
> + regulator-always-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "vcc25-dram";
> + };
> +
> + reg_bldo1: bldo1 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-name = "vcc-bias-pll";
> + };
> +
> + reg_bldo2: bldo2 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-name = "vcc-efuse-pcie-hdmi-io";
> + };
> +
> + reg_bldo3: bldo3 {
> + regulator-always-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-name = "vcc-dcxoio";
> + };
> +
> + bldo4 {
> + /* unused */
> + };
> +
> + reg_cldo1: cldo1 {
> + regulator-always-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "vcc-3v3";
> + };
> +
> + reg_cldo2: cldo2 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "vcc-wifi-1";
> + };
> +
> + reg_cldo3: cldo3 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-name = "vcc-wifi-2";
> + };
> +
> + reg_dcdca: dcdca {
> + regulator-always-on;
> + regulator-min-microvolt = <810000>;
> + regulator-max-microvolt = <1080000>;
> + regulator-name = "vdd-cpu";
> + };
> +
> + reg_dcdcc: dcdcc {
> + regulator-min-microvolt = <810000>;
> + regulator-max-microvolt = <1080000>;
> + regulator-name = "vdd-gpu";
> + };
> +
> + reg_dcdcd: dcdcd {
> + regulator-always-on;
> + regulator-min-microvolt = <960000>;
> + regulator-max-microvolt = <960000>;
> + regulator-name = "vdd-sys";
> + };
> +
> + reg_dcdce: dcdce {
> + regulator-always-on;
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-name = "vcc-dram";
> + };
> +
> + sw {
> + /* unused */
> + };
> + };
> + };
> +};
> +
> +&r_pio {
> + vcc-pl-supply = <®_aldo1>;
> + vcc-pm-supply = <®_aldo1>;
> +};
> +
> +&uart0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_ph_pins>;
> + status = "okay";
> +};
> +
> +&usb2otg {
> + dr_mode = "host";
> + status = "okay";
> +};
> +
> +&usb2phy {
> + usb0_vbus-supply = <®_vcc5v>;
> + status = "okay";
> +};
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board
2019-04-05 12:53 ` Clément Péron
@ 2019-04-05 13:07 ` Clément Péron
2019-04-05 15:11 ` Maxime Ripard
1 sibling, 0 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 13:07 UTC (permalink / raw)
To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-sunxi
Probing PMIC, Probe the PL0/1 Pins which Probe PL Bank power which Probe PMIC
On Fri, 5 Apr 2019 at 14:53, Clément Péron <peron.clem@gmail.com> wrote:
>
> Hi,
>
> Adding this r_pio regulators make a new error in the bootlog :
>
> [ 0.346843] sun50i-h6-r-pinctrl 7022000.pinctrl: Couldn't get bank
> PL regulator
> [ 0.346853] sun50i-h6-r-pinctrl 7022000.pinctrl: request() failed for pin 352
> [ 0.346862] sun50i-h6-r-pinctrl 7022000.pinctrl: pin-352
> (7081400.i2c) status -517
> [ 0.346871] sun50i-h6-r-pinctrl 7022000.pinctrl: could not request
> pin 352 (PL0) from group PL0 on device 7022000.pinctrl
> [ 0.346878] mv64xxx_i2c 7081400.i2c: Error applying setting,
> reverse things back
>
> PL0 and PL1 are SCK/SDA for the PMIC :(
>
> Clement
>
> On Fri, 5 Apr 2019 at 14:21, Clément Péron <peron.clem@gmail.com> wrote:
> >
> > Beelink GS1 is an Allwinner H6 based TV box,
> > which support:
> > - Allwinner H6 Quad-core 64-bit ARM Cortex-A53
> > - GPU Mali-T720
> > - 2GB LPDDR3 RAM
> > - AXP805 PMIC
> > - 1Gbps GMAC via RTL8211E
> > - FN-Link 6222B-SRB Wifi/BT
> > - 1x USB 2.0 Host and 1x USB 3.0 Host
> > - HDMI port
> > - S/PDIF Tx
> > - IR receiver
> > - 5V/2A DC power supply
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >
> > Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on
> > the OrangePi One Plus and Pine H64.
> >
> > Changes in v2 (Thanks to Maxime Ripard):
> > - move MMC pinctrl to SOC dtsi
> > - add board to Sunxi YAML file
> > - add PIO/R_PIO regulators
> > - remove always_on from SDIO regulators
> >
> >
> > .../devicetree/bindings/arm/sunxi.yaml | 5 +
> > arch/arm64/boot/dts/allwinner/Makefile | 1 +
> > .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 256 ++++++++++++++++++
> > 3 files changed, 262 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > index 11563d3f7c65..9ab9b266881d 100644
> > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > @@ -136,6 +136,11 @@ properties:
> > - const: lemaker,bananapro
> > - const: allwinner,sun7i-a20
> >
> > + - description: Beelink GS1
> > + items:
> > + - const: azw,beelink-gs1
> > + - const: allwinner,sun50i-h6
> > +
> > - description: Beelink X2
> > items:
> > - const: roofull,beelink-x2
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > index e4dce2f6fa3a..2dd806a3d5c9 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-beelink-gs1.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
> > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > new file mode 100644
> > index 000000000000..d820a138522b
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > @@ -0,0 +1,256 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +/*
> > + * Copyright (C) 2019 Clément Péron <peron.clem@gmail.com>
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun50i-h6.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +
> > +/ {
> > + model = "Beelink GS1";
> > + compatible = "azw,beelink-gs1", "allwinner,sun50i-h6";
> > +
> > + aliases {
> > + ethernet0 = &emac;
> > + serial0 = &uart0;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +
> > + connector {
> > + compatible = "hdmi-connector";
> > + type = "a";
> > +
> > + port {
> > + hdmi_con_in: endpoint {
> > + remote-endpoint = <&hdmi_out_con>;
> > + };
> > + };
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > +
> > + power {
> > + label = "beelink:white:power";
> > + gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
> > + default-state = "on";
> > + };
> > + };
> > +
> > + reg_vcc5v: vcc5v {
> > + /* board wide 5V supply directly from the DC jack */
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc-5v";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + regulator-always-on;
> > + };
> > +};
> > +
> > +&de {
> > + status = "okay";
> > +};
> > +
> > +&ehci0 {
> > + status = "okay";
> > +};
> > +
> > +&emac {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ext_rgmii_pins>;
> > + phy-mode = "rgmii";
> > + phy-handle = <&ext_rgmii_phy>;
> > + phy-supply = <®_aldo2>;
> > + allwinner,rx-delay-ps = <0>;
> > + allwinner,tx-delay-ps = <0>;
> > + status = "okay";
> > +};
> > +
> > +&hdmi {
> > + status = "okay";
> > +};
> > +
> > +&hdmi_out {
> > + hdmi_out_con: endpoint {
> > + remote-endpoint = <&hdmi_con_in>;
> > + };
> > +};
> > +
> > +&mdio {
> > + ext_rgmii_phy: ethernet-phy@1 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <1>;
> > + };
> > +};
> > +
> > +&mmc0 {
> > + vmmc-supply = <®_cldo1>;
> > + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
> > + bus-width = <4>;
> > + status = "okay";
> > +};
> > +
> > +&mmc2 {
> > + vmmc-supply = <®_cldo1>;
> > + vqmmc-supply = <®_bldo2>;
> > + non-removable;
> > + cap-mmc-hw-reset;
> > + bus-width = <8>;
> > + status = "okay";
> > +};
> > +
> > +&ohci0 {
> > + status = "okay";
> > +};
> > +
> > +&pio {
> > + vcc-pd-supply = <®_cldo1>;
> > + vcc-pg-supply = <®_aldo1>;
> > +};
> > +
> > +&r_i2c {
> > + status = "okay";
> > +
> > + axp805: pmic@36 {
> > + compatible = "x-powers,axp805", "x-powers,axp806";
> > + reg = <0x36>;
> > + interrupt-parent = <&r_intc>;
> > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > + x-powers,self-working-mode;
> > + vina-supply = <®_vcc5v>;
> > + vinb-supply = <®_vcc5v>;
> > + vinc-supply = <®_vcc5v>;
> > + vind-supply = <®_vcc5v>;
> > + vine-supply = <®_vcc5v>;
> > + aldoin-supply = <®_vcc5v>;
> > + bldoin-supply = <®_vcc5v>;
> > + cldoin-supply = <®_vcc5v>;
> > +
> > + regulators {
> > + reg_aldo1: aldo1 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc-pl";
> > + };
> > +
> > + reg_aldo2: aldo2 {
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc-ac200";
> > + regulator-enable-ramp-delay = <100000>;
> > + };
> > +
> > + reg_aldo3: aldo3 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc25-dram";
> > + };
> > +
> > + reg_bldo1: bldo1 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-name = "vcc-bias-pll";
> > + };
> > +
> > + reg_bldo2: bldo2 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-name = "vcc-efuse-pcie-hdmi-io";
> > + };
> > +
> > + reg_bldo3: bldo3 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-name = "vcc-dcxoio";
> > + };
> > +
> > + bldo4 {
> > + /* unused */
> > + };
> > +
> > + reg_cldo1: cldo1 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc-3v3";
> > + };
> > +
> > + reg_cldo2: cldo2 {
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc-wifi-1";
> > + };
> > +
> > + reg_cldo3: cldo3 {
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc-wifi-2";
> > + };
> > +
> > + reg_dcdca: dcdca {
> > + regulator-always-on;
> > + regulator-min-microvolt = <810000>;
> > + regulator-max-microvolt = <1080000>;
> > + regulator-name = "vdd-cpu";
> > + };
> > +
> > + reg_dcdcc: dcdcc {
> > + regulator-min-microvolt = <810000>;
> > + regulator-max-microvolt = <1080000>;
> > + regulator-name = "vdd-gpu";
> > + };
> > +
> > + reg_dcdcd: dcdcd {
> > + regulator-always-on;
> > + regulator-min-microvolt = <960000>;
> > + regulator-max-microvolt = <960000>;
> > + regulator-name = "vdd-sys";
> > + };
> > +
> > + reg_dcdce: dcdce {
> > + regulator-always-on;
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + regulator-name = "vcc-dram";
> > + };
> > +
> > + sw {
> > + /* unused */
> > + };
> > + };
> > + };
> > +};
> > +
> > +&r_pio {
> > + vcc-pl-supply = <®_aldo1>;
> > + vcc-pm-supply = <®_aldo1>;
> > +};
> > +
> > +&uart0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart0_ph_pins>;
> > + status = "okay";
> > +};
> > +
> > +&usb2otg {
> > + dr_mode = "host";
> > + status = "okay";
> > +};
> > +
> > +&usb2phy {
> > + usb0_vbus-supply = <®_vcc5v>;
> > + status = "okay";
> > +};
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators
2019-04-05 12:24 [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Clément Péron
` (3 preceding siblings ...)
2019-04-05 12:24 ` [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board Clément Péron
@ 2019-04-05 15:08 ` Maxime Ripard
2019-04-05 16:42 ` Clément Péron
4 siblings, 1 reply; 13+ messages in thread
From: Maxime Ripard @ 2019-04-05 15:08 UTC (permalink / raw)
To: Clément Péron
Cc: Rob Herring, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki, devicetree,
linux-kernel, linux-arm-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
On Fri, Apr 05, 2019 at 02:24:42PM +0200, Clément Péron wrote:
> OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
>
> Add this in the common device tree.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> index b2526dac2fcf..fd2af5095425 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> @@ -72,6 +72,12 @@
> status = "okay";
> };
>
> +&pio {
> + vcc-pc-supply = <®_bldo2>;
> + vcc-pd-supply = <®_cldo1>;
> + vcc-pg-supply = <®_bldo3>;
> +};
> +
> &r_i2c {
> status = "okay";
>
> @@ -191,6 +197,11 @@
> };
> };
>
> +&r_pio {
> + vcc-pl-supply = <®_aldo1>;
> + vcc-pm-supply = <®_bldo3>;
> +};
> +
How was this tested?
Please run checkpatch on your patches as well.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board
2019-04-05 12:24 ` [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board Clément Péron
2019-04-05 12:53 ` Clément Péron
@ 2019-04-05 15:10 ` Maxime Ripard
1 sibling, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2019-04-05 15:10 UTC (permalink / raw)
To: Clément Péron
Cc: Rob Herring, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki, devicetree,
linux-kernel, linux-arm-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
On Fri, Apr 05, 2019 at 02:24:46PM +0200, Clément Péron wrote:
> Beelink GS1 is an Allwinner H6 based TV box,
> which support:
> - Allwinner H6 Quad-core 64-bit ARM Cortex-A53
> - GPU Mali-T720
> - 2GB LPDDR3 RAM
> - AXP805 PMIC
> - 1Gbps GMAC via RTL8211E
> - FN-Link 6222B-SRB Wifi/BT
> - 1x USB 2.0 Host and 1x USB 3.0 Host
> - HDMI port
> - S/PDIF Tx
> - IR receiver
> - 5V/2A DC power supply
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>
> Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on
> the OrangePi One Plus and Pine H64.
>
> Changes in v2 (Thanks to Maxime Ripard):
> - move MMC pinctrl to SOC dtsi
> - add board to Sunxi YAML file
> - add PIO/R_PIO regulators
> - remove always_on from SDIO regulators
>
>
> .../devicetree/bindings/arm/sunxi.yaml | 5 +
> arch/arm64/boot/dts/allwinner/Makefile | 1 +
> .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 256 ++++++++++++++++++
> 3 files changed, 262 insertions(+)
> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 11563d3f7c65..9ab9b266881d 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -136,6 +136,11 @@ properties:
> - const: lemaker,bananapro
> - const: allwinner,sun7i-a20
>
> + - description: Beelink GS1
> + items:
> + - const: azw,beelink-gs1
> + - const: allwinner,sun50i-h6
> +
Can you make that a separate patch?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board
2019-04-05 12:53 ` Clément Péron
2019-04-05 13:07 ` Clément Péron
@ 2019-04-05 15:11 ` Maxime Ripard
2019-04-05 16:40 ` Clément Péron
1 sibling, 1 reply; 13+ messages in thread
From: Maxime Ripard @ 2019-04-05 15:11 UTC (permalink / raw)
To: Clément Péron
Cc: Rob Herring, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki, devicetree,
linux-kernel, linux-arm-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Fri, Apr 05, 2019 at 02:53:35PM +0200, Clément Péron wrote:
> Hi,
>
> Adding this r_pio regulators make a new error in the bootlog :
>
> [ 0.346843] sun50i-h6-r-pinctrl 7022000.pinctrl: Couldn't get bank
> PL regulator
> [ 0.346853] sun50i-h6-r-pinctrl 7022000.pinctrl: request() failed for pin 352
> [ 0.346862] sun50i-h6-r-pinctrl 7022000.pinctrl: pin-352
> (7081400.i2c) status -517
> [ 0.346871] sun50i-h6-r-pinctrl 7022000.pinctrl: could not request
> pin 352 (PL0) from group PL0 on device 7022000.pinctrl
> [ 0.346878] mv64xxx_i2c 7081400.i2c: Error applying setting,
> reverse things back
>
> PL0 and PL1 are SCK/SDA for the PMIC :(
How was this DT tested then?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board
2019-04-05 15:11 ` Maxime Ripard
@ 2019-04-05 16:40 ` Clément Péron
0 siblings, 0 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 16:40 UTC (permalink / raw)
To: Maxime Ripard
Cc: Rob Herring, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki, devicetree,
linux-kernel, linux-arm-kernel, linux-sunxi
Hi,
On Fri, 5 Apr 2019 at 17:11, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Apr 05, 2019 at 02:53:35PM +0200, Clément Péron wrote:
> > Hi,
> >
> > Adding this r_pio regulators make a new error in the bootlog :
> >
> > [ 0.346843] sun50i-h6-r-pinctrl 7022000.pinctrl: Couldn't get bank
> > PL regulator
> > [ 0.346853] sun50i-h6-r-pinctrl 7022000.pinctrl: request() failed for pin 352
> > [ 0.346862] sun50i-h6-r-pinctrl 7022000.pinctrl: pin-352
> > (7081400.i2c) status -517
> > [ 0.346871] sun50i-h6-r-pinctrl 7022000.pinctrl: could not request
> > pin 352 (PL0) from group PL0 on device 7022000.pinctrl
> > [ 0.346878] mv64xxx_i2c 7081400.i2c: Error applying setting,
> > reverse things back
> >
> > PL0 and PL1 are SCK/SDA for the PMIC :(
>
> How was this DT tested then?
There was a mistake when I tested the patch v2 and only saw this after
posting the patch.
Can I submit a V3 without pio / r_pio regulators ? (+ the yaml patch separated)
Thanks,
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators
2019-04-05 15:08 ` [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Maxime Ripard
@ 2019-04-05 16:42 ` Clément Péron
0 siblings, 0 replies; 13+ messages in thread
From: Clément Péron @ 2019-04-05 16:42 UTC (permalink / raw)
To: Maxime Ripard
Cc: Rob Herring, Chen-Yu Tsai, Icenowy Zheng, Jagan Teki, devicetree,
linux-kernel, linux-arm-kernel, linux-sunxi
Hi,
On Fri, 5 Apr 2019 at 17:08, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Fri, Apr 05, 2019 at 02:24:42PM +0200, Clément Péron wrote:
> > OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
> >
> > Add this in the common device tree.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > index b2526dac2fcf..fd2af5095425 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > @@ -72,6 +72,12 @@
> > status = "okay";
> > };
> >
> > +&pio {
> > + vcc-pc-supply = <®_bldo2>;
> > + vcc-pd-supply = <®_cldo1>;
> > + vcc-pg-supply = <®_bldo3>;
> > +};
> > +
> > &r_i2c {
> > status = "okay";
> >
> > @@ -191,6 +197,11 @@
> > };
> > };
> >
> > +&r_pio {
> > + vcc-pl-supply = <®_aldo1>;
> > + vcc-pm-supply = <®_bldo3>;
> > +};
> > +
>
> How was this tested?
Sorry maybe I should mention that but I don't own an OrangePi or a Pine H64.
But this should have the same issue than the Beelink GS1.
>
> Please run checkpatch on your patches as well.
Thanks for the advice,
Clement
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-04-05 16:41 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05 12:24 [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Clément Péron
2019-04-05 12:24 ` [PATCH v2 2/5] arm64: dts: allwinner: h6: pine64: " Clément Péron
2019-04-05 12:24 ` [PATCH v2 3/5] arm64: dts: allwinner: h6: move MMC pinctrl to dtsi Clément Péron
2019-04-05 12:24 ` [PATCH v2 4/5] dt-bindings: vendor-prefixes: add AZW Clément Péron
2019-04-05 12:42 ` Robin Murphy
2019-04-05 12:24 ` [PATCH v2 5/5] ARM: dts: sun50i: h6: Introduce Beelink GS1 board Clément Péron
2019-04-05 12:53 ` Clément Péron
2019-04-05 13:07 ` Clément Péron
2019-04-05 15:11 ` Maxime Ripard
2019-04-05 16:40 ` Clément Péron
2019-04-05 15:10 ` Maxime Ripard
2019-04-05 15:08 ` [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators Maxime Ripard
2019-04-05 16:42 ` Clément Péron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).