* [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
@ 2019-04-09 15:11 Andy Shevchenko
2019-04-10 8:05 ` Jarkko Nikula
2019-04-16 3:08 ` Evan Green
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-04-09 15:11 UTC (permalink / raw)
To: Lee Jones, linux-kernel, Jarkko Nikula; +Cc: Andy Shevchenko
Intel Comet Lake has the same LPSS than Intel Cannon Lake.
Add the new IDs to the list of supported devices.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index a67f67c90ec4..50a907f93da9 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -129,6 +129,19 @@ static const struct intel_lpss_platform_info cnl_i2c_info = {
};
static const struct pci_device_id intel_lpss_pci_ids[] = {
+ /* CML */
+ { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
+ { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
+ { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x02c7), (kernel_ulong_t)&spt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x02e8), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x02e9), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x02ea), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x02eb), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x02fb), (kernel_ulong_t)&spt_info },
/* BXT A-Step */
{ PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x0aae), (kernel_ulong_t)&bxt_i2c_info },
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
2019-04-09 15:11 [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs Andy Shevchenko
@ 2019-04-10 8:05 ` Jarkko Nikula
2019-04-16 3:08 ` Evan Green
1 sibling, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2019-04-10 8:05 UTC (permalink / raw)
To: Andy Shevchenko, Lee Jones, linux-kernel
On 4/9/19 6:11 PM, Andy Shevchenko wrote:
> Intel Comet Lake has the same LPSS than Intel Cannon Lake.
> Add the new IDs to the list of supported devices.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index a67f67c90ec4..50a907f93da9 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -129,6 +129,19 @@ static const struct intel_lpss_platform_info cnl_i2c_info = {
> };
>
> static const struct pci_device_id intel_lpss_pci_ids[] = {
> + /* CML */
> + { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
> + { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
> + { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02c7), (kernel_ulong_t)&spt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x02e8), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02e9), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02ea), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02eb), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02fb), (kernel_ulong_t)&spt_info },
> /* BXT A-Step */
> { PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x0aae), (kernel_ulong_t)&bxt_i2c_info },
Let's hold a bit. I'd like to double check does the I2C controller use
Skylake or Broxton derived input clocks.
--
Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
2019-04-09 15:11 [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs Andy Shevchenko
2019-04-10 8:05 ` Jarkko Nikula
@ 2019-04-16 3:08 ` Evan Green
2019-04-16 7:55 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Evan Green @ 2019-04-16 3:08 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, LKML, Jarkko Nikula
On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Intel Comet Lake has the same LPSS than Intel Cannon Lake.
> Add the new IDs to the list of supported devices.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index a67f67c90ec4..50a907f93da9 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -129,6 +129,19 @@ static const struct intel_lpss_platform_info cnl_i2c_info = {
> };
>
> static const struct pci_device_id intel_lpss_pci_ids[] = {
> + /* CML */
> + { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
> + { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
> + { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
How come it's not cnl_i2c_info?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
2019-04-16 3:08 ` Evan Green
@ 2019-04-16 7:55 ` Andy Shevchenko
2019-04-30 11:34 ` Jarkko Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-04-16 7:55 UTC (permalink / raw)
To: Evan Green; +Cc: Andy Shevchenko, Lee Jones, LKML, Jarkko Nikula
On Tue, Apr 16, 2019 at 6:10 AM Evan Green <evgreen@chromium.org> wrote:
> On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Intel Comet Lake has the same LPSS than Intel Cannon Lake.
> > Add the new IDs to the list of supported devices.
> > static const struct pci_device_id intel_lpss_pci_ids[] = {
> > + /* CML */
> > + { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
> > + { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
> > + { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
> > + { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
> > + { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
> > + { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
>
> How come it's not cnl_i2c_info?
This is a good question, that's why Jarkko asked Lee to hold on until
we have confirmation about i2c timings.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs
2019-04-16 7:55 ` Andy Shevchenko
@ 2019-04-30 11:34 ` Jarkko Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2019-04-30 11:34 UTC (permalink / raw)
To: Andy Shevchenko, Evan Green; +Cc: Andy Shevchenko, Lee Jones, LKML
On 4/16/19 10:55 AM, Andy Shevchenko wrote:
> On Tue, Apr 16, 2019 at 6:10 AM Evan Green <evgreen@chromium.org> wrote:
>> On Tue, Apr 9, 2019 at 11:11 PM Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>>
>>> Intel Comet Lake has the same LPSS than Intel Cannon Lake.
>>> Add the new IDs to the list of supported devices.
>
>>> static const struct pci_device_id intel_lpss_pci_ids[] = {
>>> + /* CML */
>>> + { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
>>> + { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
>>> + { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
>>> + { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info },
>>> + { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info },
>>> + { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info },
>>
>> How come it's not cnl_i2c_info?
>
> This is a good question, that's why Jarkko asked Lee to hold on until
> we have confirmation about i2c timings.
>
I got confirmation I2C uses the same input clock than Cannon Lake and
matches with my measurements.
Andy: please do s/bxt_i2c_info/cnl_i2c_info/ in your patch.
--
Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-30 11:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 15:11 [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs Andy Shevchenko
2019-04-10 8:05 ` Jarkko Nikula
2019-04-16 3:08 ` Evan Green
2019-04-16 7:55 ` Andy Shevchenko
2019-04-30 11:34 ` Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).