From: Guenter Roeck <linux@roeck-us.net>
To: Yury Norov <yury.norov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Mike Travis <travis@sgi.com>, Yury Norov <ynorov@marvell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist
Date: Thu, 11 Apr 2019 11:39:46 -0700 [thread overview]
Message-ID: <20190411183946.GA13348@roeck-us.net> (raw)
In-Reply-To: <20190405173211.11373-5-ynorov@marvell.com>
On Fri, Apr 05, 2019 at 08:32:10PM +0300, Yury Norov wrote:
> Add tests for non-number character, empty regions, integer overflow.
>
> Signed-off-by: Yury Norov <ynorov@marvell.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> lib/test_bitmap.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index b06e0fd3811b..709424a788ee 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -224,7 +224,8 @@ static const unsigned long exp[] __initconst = {
> BITMAP_FROM_U64(0xffffffff),
> BITMAP_FROM_U64(0xfffffffe),
> BITMAP_FROM_U64(0x3333333311111111ULL),
> - BITMAP_FROM_U64(0xffffffff77777777ULL)
> + BITMAP_FROM_U64(0xffffffff77777777ULL),
> + BITMAP_FROM_U64(0),
> };
>
> static const unsigned long exp2[] __initconst = {
> @@ -247,19 +248,34 @@ static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> {0, "1-31:4/4", &exp[9 * step], 32, 0},
> {0, "0-31:1/4,32-63:2/4", &exp[10 * step], 64, 0},
> {0, "0-31:3/4,32-63:4/4", &exp[11 * step], 64, 0},
> + {0, " ,, 0-31:3/4 ,, 32-63:4/4 ,, ", &exp[11 * step], 64, 0},
>
> {0, "0-31:1/4,32-63:2/4,64-95:3/4,96-127:4/4", exp2, 128, 0},
>
> {0, "0-2047:128/256", NULL, 2048, PARSE_TIME},
>
> + {0, "", &exp[12], 8, 0},
> + {0, "\n", &exp[12], 8, 0},
> + {0, ",, ,, , , ,", &exp[12], 8, 0},
> + {0, " , ,, , , ", &exp[12], 8, 0},
> + {0, " , ,, , , \n", &exp[12], 8, 0},
> +
This results in error messages such as
test_bitmap: parselist: 17: input is ,, ,, , , ,, result is 0x0, expected 0x11111111
test_bitmap: parselist: 18: input is , ,, , , , result is 0x0, expected 0x11111111
on 32-bit systems. The above should be "&exp[12 * step]".
Guenter
> {-EINVAL, "-1", NULL, 8, 0},
> {-EINVAL, "-0", NULL, 8, 0},
> {-EINVAL, "10-1", NULL, 8, 0},
> {-EINVAL, "0-31:", NULL, 8, 0},
> {-EINVAL, "0-31:0", NULL, 8, 0},
> + {-EINVAL, "0-31:0/", NULL, 8, 0},
> {-EINVAL, "0-31:0/0", NULL, 8, 0},
> {-EINVAL, "0-31:1/0", NULL, 8, 0},
> {-EINVAL, "0-31:10/1", NULL, 8, 0},
> + {-EOVERFLOW, "0-98765432123456789:10/1", NULL, 8, 0},
> +
> + {-EINVAL, "a-31", NULL, 8, 0},
> + {-EINVAL, "0-a1", NULL, 8, 0},
> + {-EINVAL, "a-31:10/1", NULL, 8, 0},
> + {-EINVAL, "0-31:a/1", NULL, 8, 0},
> + {-EINVAL, "0-\n", NULL, 8, 0},
> };
>
> static void __init test_bitmap_parselist(void)
next prev parent reply other threads:[~2019-04-11 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 17:32 [PATCH v4 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-05 17:32 ` [PATCH 1/5] lib: make bitmap_parselist_user() a wrapper on bitmap_parselist() Yury Norov
2019-04-08 9:30 ` Andy Shevchenko
2019-04-05 17:32 ` [PATCH 2/5] lib: rework bitmap_parselist Yury Norov
2019-04-08 9:55 ` Andy Shevchenko
2019-04-05 17:32 ` [PATCH 3/5] lib/test_bitmap: switch test_bitmap_parselist to ktime_get() Yury Norov
2019-04-05 17:32 ` [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist Yury Norov
2019-04-11 18:39 ` Guenter Roeck [this message]
2019-04-12 8:40 ` Andy Shevchenko
2019-04-05 17:32 ` [PATCH 5/5] lib/test_bitmap: add tests for bitmap_parselist_user Yury Norov
2019-04-16 6:37 [PATCH v5 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-16 6:38 ` [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411183946.GA13348@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=travis@sgi.com \
--cc=willy@infradead.org \
--cc=ynorov@marvell.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).