From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Yury Norov <yury.norov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Mike Travis <travis@sgi.com>, Yury Norov <ynorov@marvell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist
Date: Fri, 12 Apr 2019 11:40:29 +0300 [thread overview]
Message-ID: <20190412084029.GI9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190411183946.GA13348@roeck-us.net>
On Thu, Apr 11, 2019 at 11:39:46AM -0700, Guenter Roeck wrote:
> On Fri, Apr 05, 2019 at 08:32:10PM +0300, Yury Norov wrote:
> > Add tests for non-number character, empty regions, integer overflow.
> > {0, "1-31:4/4", &exp[9 * step], 32, 0},
> > {0, "0-31:1/4,32-63:2/4", &exp[10 * step], 64, 0},
> > {0, "0-31:3/4,32-63:4/4", &exp[11 * step], 64, 0},
> > + {0, " ,, 0-31:3/4 ,, 32-63:4/4 ,, ", &exp[11 * step], 64, 0},
> >
> > {0, "0-31:1/4,32-63:2/4,64-95:3/4,96-127:4/4", exp2, 128, 0},
> >
> > {0, "0-2047:128/256", NULL, 2048, PARSE_TIME},
> >
> > + {0, "", &exp[12], 8, 0},
> > + {0, "\n", &exp[12], 8, 0},
> > + {0, ",, ,, , , ,", &exp[12], 8, 0},
> > + {0, " , ,, , , ", &exp[12], 8, 0},
> > + {0, " , ,, , , \n", &exp[12], 8, 0},
> > +
>
> This results in error messages such as
>
> test_bitmap: parselist: 17: input is ,, ,, , , ,, result is 0x0, expected 0x11111111
> test_bitmap: parselist: 18: input is , ,, , , , result is 0x0, expected 0x11111111
>
> on 32-bit systems. The above should be "&exp[12 * step]".
Nice catch!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-04-12 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 17:32 [PATCH v4 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-05 17:32 ` [PATCH 1/5] lib: make bitmap_parselist_user() a wrapper on bitmap_parselist() Yury Norov
2019-04-08 9:30 ` Andy Shevchenko
2019-04-05 17:32 ` [PATCH 2/5] lib: rework bitmap_parselist Yury Norov
2019-04-08 9:55 ` Andy Shevchenko
2019-04-05 17:32 ` [PATCH 3/5] lib/test_bitmap: switch test_bitmap_parselist to ktime_get() Yury Norov
2019-04-05 17:32 ` [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist Yury Norov
2019-04-11 18:39 ` Guenter Roeck
2019-04-12 8:40 ` Andy Shevchenko [this message]
2019-04-05 17:32 ` [PATCH 5/5] lib/test_bitmap: add tests for bitmap_parselist_user Yury Norov
2019-04-16 6:37 [PATCH v5 0/5] lib: rework bitmap_parselist and tests Yury Norov
2019-04-16 6:38 ` [PATCH 4/5] lib/test_bitmap: add testcases for bitmap_parselist Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412084029.GI9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=travis@sgi.com \
--cc=willy@infradead.org \
--cc=ynorov@marvell.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).