From: Ira Weiny <ira.weiny@intel.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: jglisse@redhat.com, linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, "Christian König" <christian.koenig@amd.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Jan Kara" <jack@suse.cz>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Jason Gunthorpe" <jgg@mellanox.com>,
"Ross Zwisler" <zwisler@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Michal Hocko" <mhocko@kernel.org>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
kvm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rdma@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v6 7/8] mm/mmu_notifier: pass down vma and reasons why mmu notifier is happening v2
Date: Thu, 11 Apr 2019 14:50:33 -0700 [thread overview]
Message-ID: <20190411215033.GH22989@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20190411054130.GY3201@mtr-leonro.mtl.com>
On Thu, Apr 11, 2019 at 08:41:30AM +0300, Leon Romanovsky wrote:
> On Wed, Apr 10, 2019 at 04:41:57PM -0700, Ira Weiny wrote:
> > On Tue, Mar 26, 2019 at 12:47:46PM -0400, Jerome Glisse wrote:
> > > From: Jérôme Glisse <jglisse@redhat.com>
> > >
[snip]
> > > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> > > index 62f94cd85455..0379956fff23 100644
> > > --- a/include/linux/mmu_notifier.h
> > > +++ b/include/linux/mmu_notifier.h
> > > @@ -58,10 +58,12 @@ struct mmu_notifier_mm {
> > > #define MMU_NOTIFIER_RANGE_BLOCKABLE (1 << 0)
> > >
> > > struct mmu_notifier_range {
> > > + struct vm_area_struct *vma;
> > > struct mm_struct *mm;
> > > unsigned long start;
> > > unsigned long end;
> > > unsigned flags;
> > > + enum mmu_notifier_event event;
> > > };
> > >
> > > struct mmu_notifier_ops {
> > > @@ -363,10 +365,12 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,
> > > unsigned long start,
> > > unsigned long end)
> > > {
> > > + range->vma = vma;
> > > + range->event = event;
> > > range->mm = mm;
> > > range->start = start;
> > > range->end = end;
> > > - range->flags = 0;
> > > + range->flags = flags;
> >
> > Which of the "user patch sets" uses the new flags?
> >
> > I'm not seeing that user yet. In general I don't see anything wrong with the
> > series and I like the idea of telling drivers why the invalidate has fired.
> >
> > But is the flags a future feature?
>
> It seems that it is used in HMM ODP patch.
> https://patchwork.kernel.org/patch/10894281/
AFAICT the flags in that patch are "hmm_range->flags" not
"mmu_notifier_range->flags"
They are not the same.
Ira
>
> Thanks
>
> >
> > For the series:
> >
> > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> >
> > Ira
> >
> > > }
> > >
> > > #define ptep_clear_flush_young_notify(__vma, __address, __ptep) \
> > > --
> > > 2.20.1
> > >
next prev parent reply other threads:[~2019-04-11 21:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 16:47 [PATCH v6 0/8] mmu notifier provide context informations jglisse
2019-03-26 16:47 ` [PATCH v6 1/8] mm/mmu_notifier: helper to test if a range invalidation is blockable jglisse
2019-03-26 16:47 ` [PATCH v6 2/8] mm/mmu_notifier: convert user range->blockable to helper function jglisse
2019-03-26 16:47 ` [PATCH v6 3/8] mm/mmu_notifier: convert mmu_notifier_range->blockable to a flags jglisse
2019-03-26 16:47 ` [PATCH v6 4/8] mm/mmu_notifier: contextual information for event enums jglisse
2019-03-26 16:47 ` [PATCH v6 5/8] mm/mmu_notifier: contextual information for event triggering invalidation v2 jglisse
2019-03-26 16:47 ` [PATCH v6 6/8] mm/mmu_notifier: use correct mmu_notifier events for each invalidation jglisse
2019-03-26 16:47 ` [PATCH v6 7/8] mm/mmu_notifier: pass down vma and reasons why mmu notifier is happening v2 jglisse
2019-04-10 23:41 ` Ira Weiny
2019-04-11 5:41 ` Leon Romanovsky
2019-04-11 21:50 ` Ira Weiny [this message]
2019-04-11 14:39 ` Jerome Glisse
2019-04-11 15:21 ` Weiny, Ira
2019-04-11 17:00 ` Jerome Glisse
2019-03-26 16:47 ` [PATCH v6 8/8] mm/mmu_notifier: mmu_notifier_range_update_to_read_only() helper jglisse
2019-04-09 14:21 ` [PATCH v6 0/8] mmu notifier provide context informations Jerome Glisse
2019-04-09 22:08 ` Andrew Morton
2019-04-10 16:06 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411215033.GH22989@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=Felix.Kuehling@amd.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jack@suse.cz \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=rkrcmar@redhat.com \
--cc=rodrigo.vivi@intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).