From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: mathieu.poirier@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator
Date: Fri, 12 Apr 2019 18:54:32 +0800 [thread overview]
Message-ID: <20190412105432.GA1643@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <a38d1f9e-622e-7fd6-6282-be5601863c11@arm.com>
On Fri, Apr 12, 2019 at 11:40:13AM +0100, Suzuki K Poulose wrote:
> On 04/12/2019 11:27 AM, Leo Yan wrote:
> > CoreSight uses below bindings for replicator:
> >
> > Dynamic replicator, aka. configurable replicator:
> > "arm,coresight-dynamic-replicator", "arm,primecell";
> >
> > Static replicator, aka. non-configurable replicator:
> > "arm,coresight-replicator";
> >
> > The compatible string "arm,coresight-replicator" is not an explicit
> > naming to express the replicator is 'static'. To unify the naming
> > convention, this patch introduces a new compatible string
> > "arm,coresight-static-replicator" for the static replicator; the
> > compatible string "arm,coresight-replicator" is kept for backward
> > compatibility, but tag it as obsolete and suggest to use the new
> > compatible string.
> >
> > As result CoreSight replicator have below bindings:
> >
> > Dynamic replicator:
> > "arm,coresight-dynamic-replicator", "arm,primecell";
> >
> > Static replicator:
> > "arm,coresight-static-replicator";
> > "arm,coresight-replicator"; (obsolete)
> >
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > ---
> > Documentation/devicetree/bindings/arm/coresight.txt | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> > index f8aff65ab921..d02d160fa8ac 100644
> > --- a/Documentation/devicetree/bindings/arm/coresight.txt
> > +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> > @@ -69,7 +69,10 @@ its hardware characteristcs.
> > * compatible: Currently supported value is (note the absence of the
> > AMBA markee):
> > - - "arm,coresight-replicator"
> > + - Coresight Non-configurable Replicator:
> > + "arm,coresight-static-replicator";
> > + "arm,coresight-replicator"; (OBSOLETE. For backward
> > + compatibility and will be removed)
> > * port or ports: see "Graph bindings for Coresight" below.
> > @@ -169,7 +172,7 @@ Example:
> > /* non-configurable replicators don't show up on the
> > * AMBA bus. As such no need to add "arm,primecell".
> > */
> > - compatible = "arm,coresight-replicator";
> > + compatible = "arm,coresight-static-replicator";
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Thanks a lot for quick reviewing, Suzuki.
next prev parent reply other threads:[~2019-04-12 10:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 10:27 [PATCH v5 0/4] CoreSight: Support static funnel with DT binding consolidation Leo Yan
2019-04-12 10:27 ` [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Leo Yan
2019-04-12 10:40 ` Suzuki K Poulose
2019-04-12 10:54 ` Leo Yan [this message]
2019-04-16 20:18 ` Mathieu Poirier
2019-04-17 0:09 ` Leo Yan
2019-04-17 13:57 ` Mathieu Poirier
2019-04-26 14:25 ` Rob Herring
2019-04-26 15:03 ` Mathieu Poirier
2019-04-26 14:25 ` Rob Herring
2019-04-12 10:27 ` [PATCH v5 2/4] coresight: replicator: Add new device id " Leo Yan
2019-04-12 10:41 ` Suzuki K Poulose
2019-04-12 10:27 ` [PATCH v5 3/4] dt-bindings: arm: coresight: Unify funnel DT binding Leo Yan
2019-04-12 10:43 ` Suzuki K Poulose
2019-04-16 20:20 ` Mathieu Poirier
2019-04-26 14:26 ` Rob Herring
2019-04-12 10:27 ` [PATCH v5 4/4] coresight: funnel: Support static funnel Leo Yan
2019-05-03 15:11 ` Suzuki K Poulose
2019-05-05 1:28 ` Leo Yan
2019-04-26 16:26 ` [PATCH v5 0/4] CoreSight: Support static funnel with DT binding consolidation Mathieu Poirier
2019-04-27 0:20 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412105432.GA1643@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).