From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: leo.yan@linaro.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: shiwanglai@hisilicon.com
Subject: Re: [PATCH v5 3/4] dt-bindings: arm: coresight: Unify funnel DT binding
Date: Fri, 12 Apr 2019 11:43:20 +0100 [thread overview]
Message-ID: <63901a4c-2f34-a688-48b3-77b3dd8bb5d9@arm.com> (raw)
In-Reply-To: <20190412102738.12679-4-leo.yan@linaro.org>
On 04/12/2019 11:27 AM, Leo Yan wrote:
> Following the same fashion with replicator DT binding, this patch is to
> unify the DT binding for funnel to support static and dynamic modes;
> finally we get the funnel DT binding as below:
>
> Before patch:
>
> Static funnel, aka. non-configurable funnel:
> Not supported;
>
> Dynamic funnel, aka. configurable funnel:
> "arm,coresight-funnel", "arm,primecell";
>
> After patch:
>
> Static funnel:
> "arm,coresight-static-funnel";
>
> Dynamic funnel:
> "arm,coresight-dynamic-funnel", "arm,primecell";
> "arm,coresight-funnel", "arm,primecell"; (obsolete)
>
> At the end of this patch, it gives an example for static funnel DT
> binding, and updates the dynamic funnel example.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Wanglai Shi <shiwanglai@hisilicon.com>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> .../devicetree/bindings/arm/coresight.txt | 53 +++++++++++++++++--
> 1 file changed, 48 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index d02d160fa8ac..8a88ddebc1a2 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -8,7 +8,8 @@ through the intermediate links connecting the source to the currently selected
> sink. Each CoreSight component device should use these properties to describe
> its hardware characteristcs.
>
> -* Required properties for all components *except* non-configurable replicators:
> +* Required properties for all components *except* non-configurable replicators
> + and non-configurable funnels:
>
> * compatible: These have to be supplemented with "arm,primecell" as
> drivers are using the AMBA bus interface. Possible values include:
> @@ -24,8 +25,10 @@ its hardware characteristcs.
> discovered at boot time when the device is probed.
> "arm,coresight-tmc", "arm,primecell";
>
> - - Trace Funnel:
> - "arm,coresight-funnel", "arm,primecell";
> + - Trace Programmable Funnel:
> + "arm,coresight-dynamic-funnel", "arm,primecell";
> + "arm,coresight-funnel", "arm,primecell"; (OBSOLETE. For
> + backward compatibility and will be removed)
>
> - Embedded Trace Macrocell (version 3.x) and
> Program Flow Trace Macrocell:
> @@ -65,7 +68,7 @@ its hardware characteristcs.
> "stm-stimulus-base", each corresponding to the areas defined in "reg".
>
> * Required properties for devices that don't show up on the AMBA bus, such as
> - non-configurable replicators:
> + non-configurable replicators and non-configurable funnels:
>
> * compatible: Currently supported value is (note the absence of the
> AMBA markee):
> @@ -74,6 +77,9 @@ its hardware characteristcs.
> "arm,coresight-replicator"; (OBSOLETE. For backward
> compatibility and will be removed)
>
> + - Coresight Non-configurable Funnel:
> + "arm,coresight-static-funnel";
> +
> * port or ports: see "Graph bindings for Coresight" below.
>
> * Optional properties for ETM/PTMs:
> @@ -203,8 +209,45 @@ Example:
> };
> };
>
> + funnel {
> + /*
> + * non-configurable funnel don't show up on the AMBA
> + * bus. As such no need to add "arm,primecell".
> + */
> + compatible = "arm,coresight-static-funnel";
> + clocks = <&crg_ctrl HI3660_PCLK>;
> + clock-names = "apb_pclk";
> +
> + out-ports {
> + port {
> + combo_funnel_out: endpoint {
> + remote-endpoint = <&top_funnel_in>;
> + };
> + };
> + };
> +
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + combo_funnel_in0: endpoint {
> + remote-endpoint = <&cluster0_etf_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + combo_funnel_in1: endpoint {
> + remote-endpoint = <&cluster1_etf_out>;
> + };
> + };
> + };
> + };
> +
> funnel@20040000 {
> - compatible = "arm,coresight-funnel", "arm,primecell";
> + compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> reg = <0 0x20040000 0 0x1000>;
>
> clocks = <&oscclk6a>;
>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2019-04-12 10:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 10:27 [PATCH v5 0/4] CoreSight: Support static funnel with DT binding consolidation Leo Yan
2019-04-12 10:27 ` [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Leo Yan
2019-04-12 10:40 ` Suzuki K Poulose
2019-04-12 10:54 ` Leo Yan
2019-04-16 20:18 ` Mathieu Poirier
2019-04-17 0:09 ` Leo Yan
2019-04-17 13:57 ` Mathieu Poirier
2019-04-26 14:25 ` Rob Herring
2019-04-26 15:03 ` Mathieu Poirier
2019-04-26 14:25 ` Rob Herring
2019-04-12 10:27 ` [PATCH v5 2/4] coresight: replicator: Add new device id " Leo Yan
2019-04-12 10:41 ` Suzuki K Poulose
2019-04-12 10:27 ` [PATCH v5 3/4] dt-bindings: arm: coresight: Unify funnel DT binding Leo Yan
2019-04-12 10:43 ` Suzuki K Poulose [this message]
2019-04-16 20:20 ` Mathieu Poirier
2019-04-26 14:26 ` Rob Herring
2019-04-12 10:27 ` [PATCH v5 4/4] coresight: funnel: Support static funnel Leo Yan
2019-05-03 15:11 ` Suzuki K Poulose
2019-05-05 1:28 ` Leo Yan
2019-04-26 16:26 ` [PATCH v5 0/4] CoreSight: Support static funnel with DT binding consolidation Mathieu Poirier
2019-04-27 0:20 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63901a4c-2f34-a688-48b3-77b3dd8bb5d9@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=shiwanglai@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).