* [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()
@ 2019-04-12 23:34 Dexuan Cui
2019-04-13 2:19 ` Michael Kelley
0 siblings, 1 reply; 3+ messages in thread
From: Dexuan Cui @ 2019-04-12 23:34 UTC (permalink / raw)
To: gregkh, Stephen Hemminger, Sasha Levin, Haiyang Zhang,
KY Srinivasan, devel, linux-kernel, Michael Kelley
Cc: marcelo.cerri, apw, olaf, vkuznets, jasowang, Dexuan Cui, stable
With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow
warning in preempt_count_sub().
Fixes: 37cdd991fac8 ("vmbus: put related per-cpu variable together")
Cc: stable@vger.kernel.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
drivers/hv/hv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 632d25674e7f..45653029ee18 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -408,7 +408,6 @@ int hv_synic_cleanup(unsigned int cpu)
clockevents_unbind_device(hv_cpu->clk_evt, cpu);
hv_ce_shutdown(hv_cpu->clk_evt);
- put_cpu_ptr(hv_cpu);
}
hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64);
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()
2019-04-12 23:34 [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup() Dexuan Cui
@ 2019-04-13 2:19 ` Michael Kelley
2019-04-13 13:38 ` Sasha Levin
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2019-04-13 2:19 UTC (permalink / raw)
To: Dexuan Cui, gregkh, Stephen Hemminger, Sasha Levin,
Haiyang Zhang, KY Srinivasan, devel, linux-kernel
Cc: marcelo.cerri, apw, olaf, vkuznets, jasowang, stable
From: Dexuan Cui <decui@microsoft.com> Sent: Friday, April 12, 2019 4:35 PM
>
> With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow
> warning in preempt_count_sub().
>
> Fixes: 37cdd991fac8 ("vmbus: put related per-cpu variable together")
> Cc: stable@vger.kernel.org
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup()
2019-04-13 2:19 ` Michael Kelley
@ 2019-04-13 13:38 ` Sasha Levin
0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-04-13 13:38 UTC (permalink / raw)
To: Michael Kelley
Cc: Dexuan Cui, gregkh, Stephen Hemminger, Sasha Levin,
Haiyang Zhang, KY Srinivasan, devel, linux-kernel, marcelo.cerri,
apw, olaf, vkuznets, jasowang, stable
On Sat, Apr 13, 2019 at 02:19:52AM +0000, Michael Kelley wrote:
>From: Dexuan Cui <decui@microsoft.com> Sent: Friday, April 12, 2019 4:35 PM
>>
>> With CONFIG_DEBUG_PREEMPT=y, the put_cpu_ptr() triggiers an underflow
>> warning in preempt_count_sub().
>>
>> Fixes: 37cdd991fac8 ("vmbus: put related per-cpu variable together")
>> Cc: stable@vger.kernel.org
>> Cc: Stephen Hemminger <sthemmin@microsoft.com>
>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>
>Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Queued for hyperv-fixes, thanks all.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-13 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 23:34 [PATCH] vmbus: Remove the undesired put_cpu_ptr() in hv_synic_cleanup() Dexuan Cui
2019-04-13 2:19 ` Michael Kelley
2019-04-13 13:38 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).