* [PATCH] video: fbdev: gbefb: add COMPILE_TEST support
[not found] <CGME20190412115351eucas1p1dc215edd8d8c3d2dda99663925939290@eucas1p1.samsung.com>
@ 2019-04-12 11:53 ` Bartlomiej Zolnierkiewicz
2019-04-13 19:42 ` kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-04-12 11:53 UTC (permalink / raw)
To: linux-fbdev, dri-devel, linux-kernel
Add COMPILE_TEST support to gbefb driver for better compile
testing coverage.
While at it remove dead x86 specific code.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/video/fbdev/Kconfig | 2 +-
drivers/video/fbdev/gbefb.c | 9 ++-------
2 files changed, 3 insertions(+), 8 deletions(-)
Index: b/drivers/video/fbdev/Kconfig
===================================================================
--- a/drivers/video/fbdev/Kconfig 2019-04-12 13:34:54.000000000 +0200
+++ b/drivers/video/fbdev/Kconfig 2019-04-12 13:40:48.246274115 +0200
@@ -673,7 +673,7 @@ config FB_HGA
config FB_GBE
bool "SGI Graphics Backend frame buffer support"
- depends on (FB = y) && SGI_IP32
+ depends on (FB = y) && (SGI_IP32 || COMPILE_TEST)
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
Index: b/drivers/video/fbdev/gbefb.c
===================================================================
--- a/drivers/video/fbdev/gbefb.c 2019-04-12 11:39:45.266091209 +0200
+++ b/drivers/video/fbdev/gbefb.c 2019-04-12 13:48:00.142284992 +0200
@@ -39,9 +39,7 @@ struct gbefb_par {
int valid;
};
-#ifdef CONFIG_SGI_IP32
#define GBE_BASE 0x16000000 /* SGI O2 */
-#endif
/* macro for fastest write-though access to the framebuffer */
#ifdef CONFIG_MIPS
@@ -51,10 +49,6 @@ struct gbefb_par {
#define pgprot_fb(_prot) (((_prot) & (~_CACHE_MASK)) | _CACHE_CACHABLE_NO_WA)
#endif
#endif
-#ifdef CONFIG_X86
-#define pgprot_fb(_prot) (((_prot) & ~_PAGE_CACHE_MASK) | \
- cachemode2protval(_PAGE_CACHE_MODE_UC_MINUS))
-#endif
/*
* RAM we reserve for the frame buffer. This defines the maximum screen
@@ -1018,9 +1012,10 @@ static int gbefb_mmap(struct fb_info *in
/* remap using the fastest write-through mode on architecture */
/* try not polluting the cache when possible */
+#ifdef CONFIG_MIPS
pgprot_val(vma->vm_page_prot) =
pgprot_fb(pgprot_val(vma->vm_page_prot));
-
+#endif
/* VM_IO | VM_DONTEXPAND | VM_DONTDUMP are set by remap_pfn_range() */
/* look for the starting tile */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: gbefb: add COMPILE_TEST support
2019-04-12 11:53 ` [PATCH] video: fbdev: gbefb: add COMPILE_TEST support Bartlomiej Zolnierkiewicz
@ 2019-04-13 19:42 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-04-13 19:42 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: kbuild-all, linux-fbdev, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
Hi Bartlomiej,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.1-rc4 next-20190412]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/video-fbdev-gbefb-add-COMPILE_TEST-support/20190413-072821
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/video/fbdev/gbefb.o: In function `gbe_turn_off':
>> gbefb.c:(.text+0x9b8): undefined reference to `__bad_udelay'
gbefb.c:(.text+0xa0c): undefined reference to `__bad_udelay'
drivers/video/fbdev/gbefb.o: In function `gbe_turn_on':
gbefb.c:(.text+0xb64): undefined reference to `__bad_udelay'
gbefb.c:(.text+0xbb0): undefined reference to `__bad_udelay'
drivers/video/fbdev/gbefb.o: In function `gbefb_set_par':
gbefb.c:(.text+0xda4): undefined reference to `__bad_udelay'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67480 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-13 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190412115351eucas1p1dc215edd8d8c3d2dda99663925939290@eucas1p1.samsung.com>
2019-04-12 11:53 ` [PATCH] video: fbdev: gbefb: add COMPILE_TEST support Bartlomiej Zolnierkiewicz
2019-04-13 19:42 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).