linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huw Davies <huw@codeweavers.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@kernel.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [PATCH 2/3] x86/vdso: Allow clock specific mult and shift values
Date: Mon, 15 Apr 2019 10:30:43 +0100	[thread overview]
Message-ID: <20190415093042.GA21726@merlot.physics.ox.ac.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.1904141229380.4917@nanos.tec.linutronix.de>

On Sun, Apr 14, 2019 at 12:53:32PM +0200, Thomas Gleixner wrote:
> So it stays in the same cache line, but as we move the VDSO to generic
> code, the mask field needs to stay and this will make basetime[CLOCK_MONOTONIC] 
> overlap into the next cache line.

Thanks for the great review; this is a good point.

> See https://lkml.kernel.org/r/alpine.DEB.2.21.1902231727060.1666@nanos.tec.linutronix.de
> for an alternate solution to this problem, which avoids this and just gives
> CLOCK_MONOTONIC_RAW a separate storage space alltogether.

I can certainly do this for the x86 vdso.  Would that be useful or
should I wait for Vincenzo's work on the generic vdso first?

Many thanks,
Huw.

  reply	other threads:[~2019-04-15  9:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 10:12 [PATCH 0/3] x86/vdso: Add support for CLOCK_MONOTONIC_RAW in the vDSO Huw Davies
2019-04-11 10:12 ` [PATCH 1/3] x86/vdso: Remove unused 'mask' member Huw Davies
2019-04-14 10:36   ` Thomas Gleixner
2019-04-11 10:12 ` [PATCH 2/3] x86/vdso: Allow clock specific mult and shift values Huw Davies
2019-04-14 10:53   ` Thomas Gleixner
2019-04-15  9:30     ` Huw Davies [this message]
2019-04-15  9:51       ` Thomas Gleixner
2019-04-15 10:15         ` Vincenzo Frascino
2019-04-15 12:14           ` Huw Davies
2019-05-30 14:21             ` Vincenzo Frascino
2019-04-11 10:12 ` [PATCH 3/3] x86/vdso: Add support for CLOCK_MONOTONIC_RAW in the vDSO Huw Davies

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415093042.GA21726@merlot.physics.ox.ac.uk \
    --to=huw@codeweavers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).