* [PATCH] quota: remvoe redundant variable assignment
@ 2019-04-14 13:58 Chengguang Xu
2019-04-15 9:50 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2019-04-14 13:58 UTC (permalink / raw)
To: jack; +Cc: linux-kernel, Chengguang Xu
The assignment of variable ret is redundant because the
value of ret is 0 after calling v2_read_header() in normal
case.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/quota/quota_v2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c
index a73e5b34db41..25d36607be6e 100644
--- a/fs/quota/quota_v2.c
+++ b/fs/quota/quota_v2.c
@@ -158,7 +158,6 @@ static int v2_read_file_info(struct super_block *sb, int type)
qinfo->dqi_entry_size = sizeof(struct v2r1_disk_dqblk);
qinfo->dqi_ops = &v2r1_qtree_ops;
}
- ret = 0;
out:
up_read(&dqopt->dqio_sem);
return ret;
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] quota: remvoe redundant variable assignment
2019-04-14 13:58 [PATCH] quota: remvoe redundant variable assignment Chengguang Xu
@ 2019-04-15 9:50 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-04-15 9:50 UTC (permalink / raw)
To: Chengguang Xu; +Cc: jack, linux-kernel
On Sun 14-04-19 21:58:55, Chengguang Xu wrote:
> The assignment of variable ret is redundant because the
> value of ret is 0 after calling v2_read_header() in normal
> case.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Thanks for the patch. Yes, you are correct the assignment is redundant but
this way it is more obvious what we're going to return and there are also
less chances we'll break the logic when adding some code using 'ret' in the
middle of v2_read_file_info().
Honza
> ---
> fs/quota/quota_v2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c
> index a73e5b34db41..25d36607be6e 100644
> --- a/fs/quota/quota_v2.c
> +++ b/fs/quota/quota_v2.c
> @@ -158,7 +158,6 @@ static int v2_read_file_info(struct super_block *sb, int type)
> qinfo->dqi_entry_size = sizeof(struct v2r1_disk_dqblk);
> qinfo->dqi_ops = &v2r1_qtree_ops;
> }
> - ret = 0;
> out:
> up_read(&dqopt->dqio_sem);
> return ret;
> --
> 2.17.2
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-15 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-14 13:58 [PATCH] quota: remvoe redundant variable assignment Chengguang Xu
2019-04-15 9:50 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).