From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexander Dahl <ada@thorsis.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 04/12] clocksource/drivers/tcb_clksrc: stop depending on atmel_tclib
Date: Mon, 15 Apr 2019 16:14:28 +0200 [thread overview]
Message-ID: <20190415141428.GE3578@piout.net> (raw)
In-Reply-To: <7ce7342d-7fa2-d2b0-621d-2c47a0e5cdba@linaro.org>
On 11/04/2019 18:19:34+0200, Daniel Lezcano wrote:
> > + tc.clk[0] = t0_clk;
> > + tc.clk[1] = of_clk_get_by_name(node->parent, "t1_clk");
> > + if (IS_ERR(tc.clk[1]))
> > + tc.clk[1] = t0_clk;
> > + tc.clk[2] = of_clk_get_by_name(node->parent, "t2_clk");
> > + if (IS_ERR(tc.clk[2]))
> > + tc.clk[2] = t0_clk;
> > + tc.irq[0] = irq;
> > + tc.irq[1] = of_irq_get(node->parent, 1);
> > + if (tc.irq[1] <= 0)
> > + tc.irq[1] = irq;
> > + tc.irq[2] = of_irq_get(node->parent, 2);
> > + if (tc.irq[2] <= 0)
> > + tc.irq[2] = irq;
>
> Why are clk[1/2] and irq[1/2] defaulting back to t0 in case of error?
>
This is how the DT binding is madewhen the same IRQ/clk is used for all
the channels of the TCB, then it is only specified once. Unfortunately,
this has to be kept to keep backward DT compatibility. Still, I'm
reworking the irq paring as the driver only needs the irq for channel 2.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-04-15 14:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 14:11 [PATCH 00/12] clocksource: improve Atmel TCB timer driver Alexandre Belloni
2019-04-03 14:11 ` [PATCH 01/12] ARM: at91: move SoC specific definitions to SoC folder Alexandre Belloni
2019-04-03 14:36 ` Thierry Reding
2019-04-03 17:36 ` Arnd Bergmann
2019-04-03 14:11 ` [PATCH 02/12] misc: atmel_tclib: drop AVR32 support Alexandre Belloni
2019-04-03 14:11 ` [PATCH 03/12] misc: atmel_tclib: move definitions to header file Alexandre Belloni
2019-04-11 15:00 ` Daniel Lezcano
2019-04-15 14:22 ` Alexandre Belloni
2019-04-03 14:11 ` [PATCH 04/12] clocksource/drivers/tcb_clksrc: stop depending on atmel_tclib Alexandre Belloni
2019-04-11 16:19 ` Daniel Lezcano
2019-04-15 14:14 ` Alexandre Belloni [this message]
2019-04-03 14:11 ` [PATCH 05/12] clocksource/drivers/tcb_clksrc: Use tcb as sched_clock Alexandre Belloni
2019-04-03 14:11 ` [PATCH 06/12] ARM: at91: Implement clocksource selection Alexandre Belloni
2019-04-03 14:11 ` [PATCH 07/12] clocksource/drivers/tcb_clksrc: move Kconfig option Alexandre Belloni
2019-04-03 14:11 ` [PATCH 08/12] clocksource/drivers/timer-atmel-pit: rework " Alexandre Belloni
2019-04-03 14:11 ` [PATCH 09/12] clocksource/drivers/tcb_clksrc: Rename the file for consistency Alexandre Belloni
2019-04-03 14:11 ` [PATCH 10/12] ARM: configs: at91: unselect PIT Alexandre Belloni
2019-04-03 14:11 ` [PATCH 11/12] misc: atmel_tclib: do not probe already used TCBs Alexandre Belloni
2019-04-25 20:18 ` Greg Kroah-Hartman
2019-04-03 14:11 ` [PATCH 12/12] clocksource/drivers/timer-atmel-tcb: Use ARRAY_SIZE instead of hardcoded size Alexandre Belloni
2019-04-11 16:34 ` [PATCH 00/12] clocksource: improve Atmel TCB timer driver Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415141428.GE3578@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=ada@thorsis.com \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).