From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexander Dahl <ada@thorsis.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 00/12] clocksource: improve Atmel TCB timer driver
Date: Thu, 11 Apr 2019 18:34:24 +0200 [thread overview]
Message-ID: <580bf140-1e00-517d-628a-952128ebe4fe@linaro.org> (raw)
In-Reply-To: <20190403141120.32754-1-alexandre.belloni@bootlin.com>
Hi Alexandre,
except the comment for 3/12, the series looks good to me.
On 03/04/2019 16:11, Alexandre Belloni wrote:
> Hi,
>
> This series immproves the Atmel TCB clocksource driver to address the
> most urgent shortcomings:
> - the current tcb_clksrc driver is probed too late to be able to be used at
> boot and we now have SoCs that don't have a PIT. They currently are not able
> to boot an upstream kernel.
> - using the PIT doesn't work well with preempt-rt because its interrupt is
> shared (in particular with the UART) and their interrupt flags are
> incompatible). This also happen with the threadedirq command line
> switch.
> - there is currently no high resolution sched_clock.
>
> The plan is to get those changes upstream as soon as possible as they
> arre fixing real issues that people are facing. There are further
> changes needed on the clocksource driver to try to stop wasting a TCB
> channel.
> the PWM TCB driver will also be changed to actually used the reviewed
> binding and this will allow to get rif of atmel_tclib.
>
> Alexandre Belloni (12):
> ARM: at91: move SoC specific definitions to SoC folder
> misc: atmel_tclib: drop AVR32 support
> misc: atmel_tclib: move definitions to header file
> clocksource/drivers/tcb_clksrc: stop depending on atmel_tclib
> clocksource/drivers/tcb_clksrc: Use tcb as sched_clock
> ARM: at91: Implement clocksource selection
> clocksource/drivers/tcb_clksrc: move Kconfig option
> clocksource/drivers/timer-atmel-pit: rework Kconfig option
> clocksource/drivers/tcb_clksrc: Rename the file for consistency
> ARM: configs: at91: unselect PIT
> misc: atmel_tclib: do not probe already used TCBs
> clocksource/drivers/timer-atmel-tcb: Use ARRAY_SIZE instead of
> hardcoded size
>
> arch/arm/configs/at91_dt_defconfig | 1 +
> arch/arm/configs/sama5_defconfig | 1 +
> arch/arm/mach-at91/Kconfig | 23 ++++
> drivers/clocksource/Kconfig | 12 +-
> drivers/clocksource/Makefile | 2 +-
> .../{tcb_clksrc.c => timer-atmel-tcb.c} | 123 ++++++++++++------
> drivers/misc/Kconfig | 24 ----
> drivers/misc/atmel_tclib.c | 37 +-----
> drivers/pwm/pwm-atmel-tcb.c | 2 +-
> .../atmel_tc.h => soc/at91/atmel_tcb.h} | 25 +++-
> 10 files changed, 146 insertions(+), 104 deletions(-)
> rename drivers/clocksource/{tcb_clksrc.c => timer-atmel-tcb.c} (81%)
> rename include/{linux/atmel_tc.h => soc/at91/atmel_tcb.h} (95%)
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2019-04-11 16:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 14:11 [PATCH 00/12] clocksource: improve Atmel TCB timer driver Alexandre Belloni
2019-04-03 14:11 ` [PATCH 01/12] ARM: at91: move SoC specific definitions to SoC folder Alexandre Belloni
2019-04-03 14:36 ` Thierry Reding
2019-04-03 17:36 ` Arnd Bergmann
2019-04-03 14:11 ` [PATCH 02/12] misc: atmel_tclib: drop AVR32 support Alexandre Belloni
2019-04-03 14:11 ` [PATCH 03/12] misc: atmel_tclib: move definitions to header file Alexandre Belloni
2019-04-11 15:00 ` Daniel Lezcano
2019-04-15 14:22 ` Alexandre Belloni
2019-04-03 14:11 ` [PATCH 04/12] clocksource/drivers/tcb_clksrc: stop depending on atmel_tclib Alexandre Belloni
2019-04-11 16:19 ` Daniel Lezcano
2019-04-15 14:14 ` Alexandre Belloni
2019-04-03 14:11 ` [PATCH 05/12] clocksource/drivers/tcb_clksrc: Use tcb as sched_clock Alexandre Belloni
2019-04-03 14:11 ` [PATCH 06/12] ARM: at91: Implement clocksource selection Alexandre Belloni
2019-04-03 14:11 ` [PATCH 07/12] clocksource/drivers/tcb_clksrc: move Kconfig option Alexandre Belloni
2019-04-03 14:11 ` [PATCH 08/12] clocksource/drivers/timer-atmel-pit: rework " Alexandre Belloni
2019-04-03 14:11 ` [PATCH 09/12] clocksource/drivers/tcb_clksrc: Rename the file for consistency Alexandre Belloni
2019-04-03 14:11 ` [PATCH 10/12] ARM: configs: at91: unselect PIT Alexandre Belloni
2019-04-03 14:11 ` [PATCH 11/12] misc: atmel_tclib: do not probe already used TCBs Alexandre Belloni
2019-04-25 20:18 ` Greg Kroah-Hartman
2019-04-03 14:11 ` [PATCH 12/12] clocksource/drivers/timer-atmel-tcb: Use ARRAY_SIZE instead of hardcoded size Alexandre Belloni
2019-04-11 16:34 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580bf140-1e00-517d-628a-952128ebe4fe@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).