* [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
@ 2019-04-10 14:09 Yue Haibing
2019-04-10 16:36 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yue Haibing @ 2019-04-10 14:09 UTC (permalink / raw)
To: thomas.petazzoni, jason, lorenzo.pieralisi, bhelgaas, gustavo.pimentel
Cc: linux-kernel, linux-arm-kernel, linux-pci, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/pci/controller/pci-mvebu.c:557:28: warning:
symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pci/controller/pci-mvebu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
index d3a0419..ed032e9 100644
--- a/drivers/pci/controller/pci-mvebu.c
+++ b/drivers/pci/controller/pci-mvebu.c
@@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
}
}
-struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
+static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
.write_base = mvebu_pci_bridge_emul_base_conf_write,
.read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
.write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
2019-04-10 14:09 [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static Yue Haibing
@ 2019-04-10 16:36 ` Thomas Petazzoni
2019-04-15 13:00 ` Lorenzo Pieralisi
2019-04-16 10:08 ` Lorenzo Pieralisi
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-10 16:36 UTC (permalink / raw)
To: Yue Haibing
Cc: jason, lorenzo.pieralisi, bhelgaas, gustavo.pimentel,
linux-kernel, linux-arm-kernel, linux-pci
On Wed, 10 Apr 2019 22:09:49 +0800
Yue Haibing <yuehaibing@huawei.com> wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/pci/controller/pci-mvebu.c:557:28: warning:
> symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
2019-04-10 14:09 [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static Yue Haibing
2019-04-10 16:36 ` Thomas Petazzoni
@ 2019-04-15 13:00 ` Lorenzo Pieralisi
2019-04-15 14:06 ` YueHaibing
2019-04-16 10:08 ` Lorenzo Pieralisi
2 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Pieralisi @ 2019-04-15 13:00 UTC (permalink / raw)
To: Yue Haibing
Cc: thomas.petazzoni, jason, bhelgaas, gustavo.pimentel,
linux-kernel, linux-arm-kernel, linux-pci
On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/pci/controller/pci-mvebu.c:557:28: warning:
> symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
Is Mr.Robot reachable by email ?
If it is a CI bot I doubt it is useful to leave this tag there unless
you want it for accounting purposes, just let me know.
Thanks,
Lorenzo
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/pci-mvebu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
> index d3a0419..ed032e9 100644
> --- a/drivers/pci/controller/pci-mvebu.c
> +++ b/drivers/pci/controller/pci-mvebu.c
> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
> }
> }
>
> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> .write_base = mvebu_pci_bridge_emul_base_conf_write,
> .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
> .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
2019-04-15 13:00 ` Lorenzo Pieralisi
@ 2019-04-15 14:06 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2019-04-15 14:06 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: thomas.petazzoni, jason, bhelgaas, gustavo.pimentel,
linux-kernel, linux-arm-kernel, linux-pci
On 2019/4/15 21:00, Lorenzo Pieralisi wrote:
> On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warning:
>>
>> drivers/pci/controller/pci-mvebu.c:557:28: warning:
>> symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>
> Is Mr.Robot reachable by email ?
>
> If it is a CI bot I doubt it is useful to leave this tag there unless
> you want it for accounting purposes, just let me know.
Yes, it is our CI bot.
>
> Thanks,
> Lorenzo
>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/pci/controller/pci-mvebu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
>> index d3a0419..ed032e9 100644
>> --- a/drivers/pci/controller/pci-mvebu.c
>> +++ b/drivers/pci/controller/pci-mvebu.c
>> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
>> }
>> }
>>
>> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>> .write_base = mvebu_pci_bridge_emul_base_conf_write,
>> .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
>> .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
>> --
>> 2.7.4
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
2019-04-10 14:09 [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static Yue Haibing
2019-04-10 16:36 ` Thomas Petazzoni
2019-04-15 13:00 ` Lorenzo Pieralisi
@ 2019-04-16 10:08 ` Lorenzo Pieralisi
2 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2019-04-16 10:08 UTC (permalink / raw)
To: Yue Haibing
Cc: thomas.petazzoni, jason, bhelgaas, gustavo.pimentel,
linux-kernel, linux-arm-kernel, linux-pci
On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/pci/controller/pci-mvebu.c:557:28: warning:
> symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/pci-mvebu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/misc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
> index d3a0419..ed032e9 100644
> --- a/drivers/pci/controller/pci-mvebu.c
> +++ b/drivers/pci/controller/pci-mvebu.c
> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
> }
> }
>
> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> .write_base = mvebu_pci_bridge_emul_base_conf_write,
> .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
> .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-16 10:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 14:09 [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static Yue Haibing
2019-04-10 16:36 ` Thomas Petazzoni
2019-04-15 13:00 ` Lorenzo Pieralisi
2019-04-15 14:06 ` YueHaibing
2019-04-16 10:08 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).