* [PATCH -next] ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static
@ 2019-04-16 14:52 Yue Haibing
2019-04-16 16:32 ` Applied "ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static" to the asoc tree Mark Brown
2019-05-02 2:18 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-16 14:52 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, Vijendar.Mukunda
Cc: linux-kernel, alsa-devel, maruthi.bayyavarapu, colin.king, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
sound/soc/amd/raven/acp3x-pcm-dma.c:561:24: warning:
symbol 'acp3x_dai_i2s_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 1a2e15f..9775bda 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -558,7 +558,7 @@ static int acp3x_dai_i2s_trigger(struct snd_pcm_substream *substream,
return ret;
}
-struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
+static struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
.hw_params = acp3x_dai_i2s_hwparams,
.trigger = acp3x_dai_i2s_trigger,
.set_fmt = acp3x_dai_i2s_set_fmt,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Applied "ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static" to the asoc tree
2019-04-16 14:52 [PATCH -next] ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static Yue Haibing
@ 2019-04-16 16:32 ` Mark Brown
2019-05-02 2:18 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-04-16 16:32 UTC (permalink / raw)
To: YueHaibing
Cc: alsa-devel, broonie, colin.king, Hulk Robot, lgirdwood,
linux-kernel, Mark Brown, maruthi.bayyavarapu, perex, tiwai,
Vijendar.Mukunda
The patch
ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From dc11607e151bd85b17c8e03d1bf823febd5e3c40 Mon Sep 17 00:00:00 2001
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 16 Apr 2019 22:52:51 +0800
Subject: [PATCH] ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static
Fix sparse warning:
sound/soc/amd/raven/acp3x-pcm-dma.c:561:24: warning:
symbol 'acp3x_dai_i2s_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 1a2e15ff1456..9775bda2a4ca 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -558,7 +558,7 @@ static int acp3x_dai_i2s_trigger(struct snd_pcm_substream *substream,
return ret;
}
-struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
+static struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
.hw_params = acp3x_dai_i2s_hwparams,
.trigger = acp3x_dai_i2s_trigger,
.set_fmt = acp3x_dai_i2s_set_fmt,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Applied "ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static" to the asoc tree
2019-04-16 14:52 [PATCH -next] ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static Yue Haibing
2019-04-16 16:32 ` Applied "ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static" to the asoc tree Mark Brown
@ 2019-05-02 2:18 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-05-02 2:18 UTC (permalink / raw)
To: YueHaibing
Cc: alsa-devel, broonie, colin.king, Hulk Robot, lgirdwood,
linux-kernel, Mark Brown, maruthi.bayyavarapu, perex, tiwai,
Vijendar.Mukunda
The patch
ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From a1a86e1bd4a87fd09171fd8555fe7490917e4e94 Mon Sep 17 00:00:00 2001
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 16 Apr 2019 22:52:51 +0800
Subject: [PATCH] ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static
Fix sparse warning:
sound/soc/amd/raven/acp3x-pcm-dma.c:561:24: warning:
symbol 'acp3x_dai_i2s_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 1a2e15ff1456..9775bda2a4ca 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -558,7 +558,7 @@ static int acp3x_dai_i2s_trigger(struct snd_pcm_substream *substream,
return ret;
}
-struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
+static struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
.hw_params = acp3x_dai_i2s_hwparams,
.trigger = acp3x_dai_i2s_trigger,
.set_fmt = acp3x_dai_i2s_set_fmt,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-02 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 14:52 [PATCH -next] ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static Yue Haibing
2019-04-16 16:32 ` Applied "ASoC: amd: acp3x: Make acp3x_dai_i2s_ops static" to the asoc tree Mark Brown
2019-05-02 2:18 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).