* [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module autoloading
@ 2019-04-16 23:49 Bjorn Andersson
2019-04-22 10:54 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2019-04-16 23:49 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler
Cc: Andy Gross, David Brown, linux-arm-msm, linux-iio, linux-kernel, stable
The of_device_id table needs to be registered as module alias in order
for automatic module loading to pick the kernel module based on the
DeviceTree compatible. So add MODULE_DEVICE_TABLE() to make this happen.
Fixes: e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
Cc: stable@vger.kernel.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/iio/adc/qcom-spmi-adc5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index 6a866cc187f7..21fdcde77883 100644
--- a/drivers/iio/adc/qcom-spmi-adc5.c
+++ b/drivers/iio/adc/qcom-spmi-adc5.c
@@ -664,6 +664,7 @@ static const struct of_device_id adc5_match_table[] = {
},
{ }
};
+MODULE_DEVICE_TABLE(of, adc5_match_table);
static int adc5_get_dt_data(struct adc5_chip *adc, struct device_node *node)
{
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module autoloading
2019-04-16 23:49 [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module autoloading Bjorn Andersson
@ 2019-04-22 10:54 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-04-22 10:54 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Andy Gross, David Brown, linux-arm-msm, linux-iio, linux-kernel,
stable
On Tue, 16 Apr 2019 16:49:27 -0700
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> The of_device_id table needs to be registered as module alias in order
> for automatic module loading to pick the kernel module based on the
> DeviceTree compatible. So add MODULE_DEVICE_TABLE() to make this happen.
>
> Fixes: e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
I'll take this via the next merge window because it's been there a little
while and in isn't a regression. Obviously we are very late in this
cycle so I'd rather not do another fixes pull request.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/qcom-spmi-adc5.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
> index 6a866cc187f7..21fdcde77883 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5.c
> @@ -664,6 +664,7 @@ static const struct of_device_id adc5_match_table[] = {
> },
> { }
> };
> +MODULE_DEVICE_TABLE(of, adc5_match_table);
>
> static int adc5_get_dt_data(struct adc5_chip *adc, struct device_node *node)
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-22 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16 23:49 [PATCH] iio: adc: qcom-spmi-adc5: Fix of-based module autoloading Bjorn Andersson
2019-04-22 10:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).