* [PATCH] regulator: stm32-pwr: Staticize local symbols
@ 2019-04-17 7:59 Axel Lin
2019-04-17 16:38 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2019-04-17 7:59 UTC (permalink / raw)
To: Mark Brown; +Cc: Pascal Paillet, Liam Girdwood, linux-kernel, Axel Lin
These symbols are only used by this driver, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/stm32-pwr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
index e434b26d4c8b..222d593d76a2 100644
--- a/drivers/regulator/stm32-pwr.c
+++ b/drivers/regulator/stm32-pwr.c
@@ -32,7 +32,7 @@ enum {
STM32PWR_REG_NUM_REGS
};
-u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
+static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
[PWR_REG11] = REG_1_1_RDY,
[PWR_REG18] = REG_1_8_RDY,
[PWR_USB33] = USB_3_3_RDY,
@@ -44,7 +44,7 @@ struct stm32_pwr_reg {
u32 ready_mask;
};
-int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
+static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
{
struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
u32 val;
@@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
return (val & priv->ready_mask);
}
-int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
+static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
{
struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
u32 val;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: stm32-pwr: Staticize local symbols
2019-04-17 7:59 [PATCH] regulator: stm32-pwr: Staticize local symbols Axel Lin
@ 2019-04-17 16:38 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2019-04-17 16:38 UTC (permalink / raw)
To: Axel Lin; +Cc: Pascal Paillet, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
On Wed, Apr 17, 2019 at 03:59:42PM +0800, Axel Lin wrote:
> These symbols are only used by this driver, make them static.
Someone already sent a patch for this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-17 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 7:59 [PATCH] regulator: stm32-pwr: Staticize local symbols Axel Lin
2019-04-17 16:38 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).