* [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties @ 2019-04-17 0:43 Nick Crews 2019-04-17 0:43 ` [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews 2019-04-17 21:40 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Sebastian Reichel 0 siblings, 2 replies; 12+ messages in thread From: Nick Crews @ 2019-04-17 0:43 UTC (permalink / raw) To: enric.balletbo, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong, Nick Crews Add "Standard", "Adaptive", and "Custom" modes to the charge_type property, to expand the existing "Trickle" and "Fast" modes. In addition, add POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties, to expand the existing CHARGE_CONTROL_* properties. I am adding them in order to support a new Chrome OS device, but these properties should be general enough that they can be used on other devices. The meaning of "Standard" is obvious, but "Adaptive" and "Custom" are more tricky: "Adaptive" means that the charge controller uses some custom algorithm to change the charge type automatically, with no configuration needed. "Custom" means that the charge controller uses the POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some other algorithm. For example, in the use case that I am supporting, this means the battery begins charging when the percentage level drops below POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and charging ceases when the percentage level goes above POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD. v4 changes: - Add documentation for the new properties, and add documentation for the the previously missing charge_control_limit and charge_control_limit_max properties. Signed-off-by: Nick Crews <ncrews@chromium.org> --- Documentation/ABI/testing/sysfs-class-power | 51 +++++++++++++++++++-- drivers/power/supply/power_supply_sysfs.c | 4 +- include/linux/power_supply.h | 10 +++- 3 files changed, 59 insertions(+), 6 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power index 5e23e22dce1b..b77e30b9014e 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -114,15 +114,60 @@ Description: Access: Read Valid values: Represented in microamps +What: /sys/class/power_supply/<supply_name>/charge_control_limit +Date: Oct 2012 +Contact: linux-pm@vger.kernel.org +Description: + Maximum allowable charging current. Used for charge rate + throttling for thermal cooling or improving battery health. + + Access: Read, Write + Valid values: Represented in microamps + +What: /sys/class/power_supply/<supply_name>/charge_control_limit_max +Date: Oct 2012 +Contact: linux-pm@vger.kernel.org +Description: + Maximum legal value for the charge_control_limit property. + + Access: Read + Valid values: Represented in microamps + +What: /sys/class/power_supply/<supply_name>/charge_control_start_threshold +Date: April 2019 +Contact: linux-pm@vger.kernel.org +Description: + Represents a battery percentage level, below which charging will + begin. + + Access: Read, Write + Valid values: 0 - 100 (percent) + +What: /sys/class/power_supply/<supply_name>/charge_control_end_threshold +Date: April 2019 +Contact: linux-pm@vger.kernel.org +Description: + Represents a battery percentage level, above which charging will + stop. + + Access: Read, Write + Valid values: 0 - 100 (percent) + What: /sys/class/power_supply/<supply_name>/charge_type Date: July 2009 Contact: linux-pm@vger.kernel.org Description: Represents the type of charging currently being applied to the - battery. + battery. "Trickle", "Fast", and "Standard" all mean different + charging speeds. "Adaptive" means that the charger uses some + algorithm to adjust the charge rate dynamically, without + any user configuration required. "Custom" means that the charger + uses the charge_control_* properties as configuration for some + different algorithm. - Access: Read - Valid values: "Unknown", "N/A", "Trickle", "Fast" + Access: Read, Write + Valid values: "Unknown", "N/A", "Trickle", "Fast", "Standard", + "Adaptive", "Custom" What: /sys/class/power_supply/<supply_name>/charge_term_current Date: July 2014 diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index dce24f596160..6104a3f03d46 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -56,7 +56,7 @@ static const char * const power_supply_status_text[] = { }; static const char * const power_supply_charge_type_text[] = { - "Unknown", "N/A", "Trickle", "Fast" + "Unknown", "N/A", "Trickle", "Fast", "Standard", "Adaptive", "Custom" }; static const char * const power_supply_health_text[] = { @@ -274,6 +274,8 @@ static struct device_attribute power_supply_attrs[] = { POWER_SUPPLY_ATTR(constant_charge_voltage_max), POWER_SUPPLY_ATTR(charge_control_limit), POWER_SUPPLY_ATTR(charge_control_limit_max), + POWER_SUPPLY_ATTR(charge_control_start_threshold), + POWER_SUPPLY_ATTR(charge_control_end_threshold), POWER_SUPPLY_ATTR(input_current_limit), POWER_SUPPLY_ATTR(energy_full_design), POWER_SUPPLY_ATTR(energy_empty_design), diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 2f9c201a54d1..d59205170232 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -40,11 +40,15 @@ enum { POWER_SUPPLY_STATUS_FULL, }; +/* What algorithm is the charger using? */ enum { POWER_SUPPLY_CHARGE_TYPE_UNKNOWN = 0, POWER_SUPPLY_CHARGE_TYPE_NONE, - POWER_SUPPLY_CHARGE_TYPE_TRICKLE, - POWER_SUPPLY_CHARGE_TYPE_FAST, + POWER_SUPPLY_CHARGE_TYPE_TRICKLE, /* slow speed */ + POWER_SUPPLY_CHARGE_TYPE_FAST, /* fast speed */ + POWER_SUPPLY_CHARGE_TYPE_STANDARD, /* normal speed */ + POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE, /* dynamically adjusted speed */ + POWER_SUPPLY_CHARGE_TYPE_CUSTOM, /* use CHARGE_CONTROL_* props */ }; enum { @@ -121,6 +125,8 @@ enum power_supply_property { POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX, POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT, POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX, + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, /* in percents! */ + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, /* in percents! */ POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN, POWER_SUPPLY_PROP_ENERGY_EMPTY_DESIGN, -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver 2019-04-17 0:43 [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews @ 2019-04-17 0:43 ` Nick Crews 2019-04-19 23:05 ` kbuild test robot 2019-04-17 21:40 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Sebastian Reichel 1 sibling, 1 reply; 12+ messages in thread From: Nick Crews @ 2019-04-17 0:43 UTC (permalink / raw) To: enric.balletbo, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong, Nick Crews Add control of the charging algorithm used on Wilco devices. See Documentation/ABI/testing/sysfs-class-power-wilco for the userspace interface and other info. v4 changes: -Move implementation from drivers/platform/chrome/wilco_ec/charge_config.c to drivers/power/supply/wilco_charger.c -Move drivers/platform/chrome/wilco_ec/properties.h to include/linux/platform_data/wilco-ec-properties.h -Remove parentheses in switch statement in psp_val_to_charge_mode() -Check for any negatvie return code from psp_val_to_charge_mode() instead of just -EINVAL so its less brittle -Tweak comments in wilco-ec-properties.h v3 changes: -Add this changelog -Fix commit message tags v2 changes: -Update Documentation to say KernelVersion 5.2 -Update Documentation to explain Trickle mode better. -rename things from using *PCC* to *CHARGE* -Split up conversions between POWER_SUPPLY_PROP_CHARGE_TYPE values and Wilco EC codes -Use devm_ flavor of power_supply_register(), which simplifies things -Add extra error checking on property messages received from the EC -Fix bug in memcpy() calls in properties.c -Refactor fill_property_id() -Add valid input checks to charge_type -Properly convert charge_type when get()ting Signed-off-by: Nick Crews <ncrews@chromium.org> --- .../ABI/testing/sysfs-class-power-wilco | 30 +++ drivers/platform/chrome/wilco_ec/Kconfig | 9 + drivers/platform/chrome/wilco_ec/Makefile | 2 + drivers/platform/chrome/wilco_ec/core.c | 16 ++ drivers/platform/chrome/wilco_ec/properties.c | 125 ++++++++++++ drivers/power/supply/wilco_charger.c | 190 ++++++++++++++++++ .../linux/platform_data/wilco-ec-properties.h | 68 +++++++ include/linux/platform_data/wilco-ec.h | 2 + 8 files changed, 442 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-power-wilco create mode 100644 drivers/platform/chrome/wilco_ec/properties.c create mode 100644 drivers/power/supply/wilco_charger.c create mode 100644 include/linux/platform_data/wilco-ec-properties.h diff --git a/Documentation/ABI/testing/sysfs-class-power-wilco b/Documentation/ABI/testing/sysfs-class-power-wilco new file mode 100644 index 000000000000..7f3b01310476 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-power-wilco @@ -0,0 +1,30 @@ +What: /sys/class/power_supply/wilco_charger/charge_type +Date: April 2019 +KernelVersion: 5.2 +Description: + What charging algorithm to use: + + Standard: Fully charges battery at a standard rate. + Adaptive: Battery settings adaptively optimized based on + typical battery usage pattern. + Fast: Battery charges over a shorter period. + Trickle: Extends battery lifespan, intended for users who + primarily use their Chromebook while connected to AC. + Custom: A low and high threshold percentage is specified. + Charging begins when level drops below + charge_control_start_threshold, and ceases when + level is above charge_control_end_threshold. + +What: /sys/class/power_supply/wilco_charger/charge_control_start_threshold +Date: April 2019 +KernelVersion: 5.2 +Description: + Used when charge_type="Custom", as described above. Measured in + percentages. The valid range is [50, 95]. + +What: /sys/class/power_supply/wilco_charger/charge_control_end_threshold +Date: April 2019 +KernelVersion: 5.2 +Description: + Used when charge_type="Custom", as described above. Measured in + percentages. The valid range is [55, 100]. diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig index e09e4cebe9b4..1c427830bd57 100644 --- a/drivers/platform/chrome/wilco_ec/Kconfig +++ b/drivers/platform/chrome/wilco_ec/Kconfig @@ -18,3 +18,12 @@ config WILCO_EC_DEBUGFS manipulation and allow for testing arbitrary commands. This interface is intended for debug only and will not be present on production devices. + +config WILCO_EC_CHARGE_CNTL + tristate "Enable charging control" + depends on WILCO_EC + help + If you say Y here, you get support to control the charging + routines performed by the Wilco Embedded Controller. + Further information can be found in + Documentation/ABI/testing/sysfs-class-power-wilco) diff --git a/drivers/platform/chrome/wilco_ec/Makefile b/drivers/platform/chrome/wilco_ec/Makefile index 063e7fb4ea17..7e980f56f793 100644 --- a/drivers/platform/chrome/wilco_ec/Makefile +++ b/drivers/platform/chrome/wilco_ec/Makefile @@ -4,3 +4,5 @@ wilco_ec-objs := core.o mailbox.o obj-$(CONFIG_WILCO_EC) += wilco_ec.o wilco_ec_debugfs-objs := debugfs.o obj-$(CONFIG_WILCO_EC_DEBUGFS) += wilco_ec_debugfs.o +wilco_ec_charging-objs := charge_config.o properties.o +obj-$(CONFIG_WILCO_EC_CHARGE_CNTL) += wilco_ec_charging.o diff --git a/drivers/platform/chrome/wilco_ec/core.c b/drivers/platform/chrome/wilco_ec/core.c index 05e1e2be1c91..c13f10d12285 100644 --- a/drivers/platform/chrome/wilco_ec/core.c +++ b/drivers/platform/chrome/wilco_ec/core.c @@ -89,8 +89,23 @@ static int wilco_ec_probe(struct platform_device *pdev) goto unregister_debugfs; } + /* Register child device to be found by charging config driver. */ + ec->charging_pdev = platform_device_register_data(dev, + "wilco-ec-charging", + PLATFORM_DEVID_AUTO, + NULL, 0); + if (IS_ERR(ec->charging_pdev)) { + dev_err(dev, "Failed to create charging platform device\n"); + ret = PTR_ERR(ec->charging_pdev); + goto unregister_rtc; + } + return 0; +unregister_kbbl: + platform_device_unregister(ec->kbbl_pdev); +unregister_rtc: + platform_device_unregister(ec->rtc_pdev); unregister_debugfs: if (ec->debugfs_pdev) platform_device_unregister(ec->debugfs_pdev); @@ -102,6 +117,7 @@ static int wilco_ec_remove(struct platform_device *pdev) { struct wilco_ec_device *ec = platform_get_drvdata(pdev); + platform_device_unregister(ec->charging_pdev); platform_device_unregister(ec->rtc_pdev); if (ec->debugfs_pdev) platform_device_unregister(ec->debugfs_pdev); diff --git a/drivers/platform/chrome/wilco_ec/properties.c b/drivers/platform/chrome/wilco_ec/properties.c new file mode 100644 index 000000000000..49bcc413e378 --- /dev/null +++ b/drivers/platform/chrome/wilco_ec/properties.c @@ -0,0 +1,125 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright 2019 Google LLC + */ + +#include <linux/string.h> +#include "properties.h" + +struct ec_property_request { + u8 op; + u8 property_id[4]; + u8 length; + u8 data[WILCO_EC_PROPERTY_MAX_SIZE]; +} __packed; + +struct ec_property_response { + u8 reserved[2]; + u8 op; + u8 property_id[4]; + u8 length; + u8 data[WILCO_EC_PROPERTY_MAX_SIZE]; +} __packed; + +static int send_property_msg(struct wilco_ec_device *ec, + struct ec_property_request *rq, + struct ec_property_response *rs) +{ + struct wilco_ec_message ec_msg; + int ret; + + memset(&ec_msg, 0, sizeof(ec_msg)); + ec_msg.type = WILCO_EC_MSG_PROPERTY; + ec_msg.request_data = rq; + ec_msg.request_size = sizeof(*rq); + ec_msg.response_data = rs; + ec_msg.response_size = sizeof(*rs); + ret = wilco_ec_mailbox(ec, &ec_msg); + if (ret < 0) + return ret; + + if (rs->op != rq->op) + return -EBADMSG; + if (memcmp(rq->property_id, rs->property_id, sizeof(rs->property_id))) + return -EBADMSG; + if (rs->length > sizeof(rs->data)) + return -EMSGSIZE; + + return 0; +} + +int wilco_ec_get_property(struct wilco_ec_device *ec, + struct ec_property_get_msg *prop_msg) +{ + struct ec_property_request rq; + struct ec_property_response rs; + int ret; + + memset(&rq, 0, sizeof(rq)); + rq.op = OP_GET; + put_unaligned_le32(prop_msg->property_id, rq.property_id); + + ret = send_property_msg(ec, &rq, &rs); + if (ret < 0) + return ret; + + prop_msg->length = rs.length; + memcpy(prop_msg->data, rs.data, rs.length); + + return 0; +} + +int wilco_ec_set_property(struct wilco_ec_device *ec, + struct ec_property_set_msg *prop_msg) +{ + struct ec_property_request rq; + struct ec_property_response rs; + int ret; + + memset(&rq, 0, sizeof(rq)); + rq.op = prop_msg->op; + put_unaligned_le32(prop_msg->property_id, rq.property_id); + rq.length = prop_msg->length; + memcpy(rq.data, prop_msg->data, prop_msg->length); + + ret = send_property_msg(ec, &rq, &rs); + if (ret < 0) + return ret; + + if (rs.length != prop_msg->length) + return -EBADMSG; + + return 0; +} + +int wilco_ec_get_byte_property(struct wilco_ec_device *ec, u32 property_id, + u8 *val) +{ + struct ec_property_get_msg msg; + int ret; + + msg.property_id = property_id; + ret = wilco_ec_get_property(ec, &msg); + if (ret) + return ret; + + if (msg.length != 1) + return -EBADMSG; + + *val = msg.data[0]; + + return 0; +} + +int wilco_ec_set_byte_property(struct wilco_ec_device *ec, u32 property_id, + u8 val) +{ + struct ec_property_set_msg msg; + + msg.property_id = property_id; + msg.op = OP_SET; + msg.data[0] = val; + msg.length = 1; + + return wilco_ec_set_property(ec, &msg); +} diff --git a/drivers/power/supply/wilco_charger.c b/drivers/power/supply/wilco_charger.c new file mode 100644 index 000000000000..899b72720f63 --- /dev/null +++ b/drivers/power/supply/wilco_charger.c @@ -0,0 +1,190 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Charging control driver for the Wilco EC + * + * Copyright 2019 Google LLC + * + * See Documentation/ABI/testing/sysfs-class-power and + * Documentation/ABI/testing/sysfs-class-power-wilco for userspace interface + * and other info. + */ + +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/platform_data/wilco-ec.h> +#include <linux/platform_data/wilco-ec-properties.h> +#include <linux/power_supply.h> + +#define DRV_NAME "wilco-ec-charging" + +/* Property IDs and related EC constants */ +#define PID_CHARGE_MODE 0x0710 +#define PID_CHARGE_LOWER_LIMIT 0x0711 +#define PID_CHARGE_UPPER_LIMIT 0x0712 + +enum charge_mode { + CHARGE_MODE_STD = 1, /* Used for Standard */ + CHARGE_MODE_EXP = 2, /* Express Charge, used for Fast */ + CHARGE_MODE_AC = 3, /* Mostly AC use, used for Trickle */ + CHARGE_MODE_AUTO = 4, /* Used for Adaptive */ + CHARGE_MODE_CUSTOM = 5, /* Used for Custom */ +}; + +#define CHARGE_LOWER_LIMIT_MIN 50 +#define CHARGE_LOWER_LIMIT_MAX 95 +#define CHARGE_UPPER_LIMIT_MIN 55 +#define CHARGE_UPPER_LIMIT_MAX 100 + +/* Convert from POWER_SUPPLY_PROP_CHARGE_TYPE value to the EC's charge mode */ +static enum charge_mode psp_val_to_charge_mode(int psp_val) +{ + switch (psp_val) { + case POWER_SUPPLY_CHARGE_TYPE_TRICKLE: + return CHARGE_MODE_AC; + case POWER_SUPPLY_CHARGE_TYPE_FAST: + return CHARGE_MODE_EXP; + case POWER_SUPPLY_CHARGE_TYPE_STANDARD: + return CHARGE_MODE_STD; + case POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE: + return CHARGE_MODE_AUTO; + case POWER_SUPPLY_CHARGE_TYPE_CUSTOM: + return CHARGE_MODE_CUSTOM; + default: + return -EINVAL; + } +} + +/* Convert from EC's charge mode to POWER_SUPPLY_PROP_CHARGE_TYPE value */ +static int charge_mode_to_psp_val(enum charge_mode mode) +{ + switch (mode) { + case (CHARGE_MODE_AC): + return POWER_SUPPLY_CHARGE_TYPE_TRICKLE; + case (CHARGE_MODE_EXP): + return POWER_SUPPLY_CHARGE_TYPE_FAST; + case (CHARGE_MODE_STD): + return POWER_SUPPLY_CHARGE_TYPE_STANDARD; + case (CHARGE_MODE_AUTO): + return POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE; + case (CHARGE_MODE_CUSTOM): + return POWER_SUPPLY_CHARGE_TYPE_CUSTOM; + default: + return -EINVAL; + } +} + +static enum power_supply_property wilco_charge_props[] = { + POWER_SUPPLY_PROP_CHARGE_TYPE, + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, +}; + +static int wilco_charge_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct wilco_ec_device *ec = power_supply_get_drvdata(psy); + u32 property_id; + int ret; + u8 raw; + + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_TYPE: + property_id = PID_CHARGE_MODE; + break; + case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD: + property_id = PID_CHARGE_LOWER_LIMIT; + break; + case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD: + property_id = PID_CHARGE_UPPER_LIMIT; + break; + default: + return -EINVAL; + } + + ret = wilco_ec_get_byte_property(ec, property_id, &raw); + if (ret < 0) + return ret; + if (property_id == PID_CHARGE_MODE) { + ret = charge_mode_to_psp_val(raw); + if (ret < 0) + return -EBADMSG; + raw = ret; + } + val->intval = raw; + + return 0; +} + +static int wilco_charge_set_property(struct power_supply *psy, + enum power_supply_property psp, + const union power_supply_propval *val) +{ + struct wilco_ec_device *ec = power_supply_get_drvdata(psy); + enum charge_mode mode; + + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_TYPE: + mode = psp_val_to_charge_mode(val->intval); + if (mode < 0) + return -EINVAL; + return wilco_ec_set_byte_property(ec, PID_CHARGE_MODE, mode); + case POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD: + if (val->intval < CHARGE_LOWER_LIMIT_MIN || + val->intval > CHARGE_LOWER_LIMIT_MAX) + return -EINVAL; + return wilco_ec_set_byte_property(ec, PID_CHARGE_LOWER_LIMIT, + val->intval); + case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD: + if (val->intval < CHARGE_UPPER_LIMIT_MIN || + val->intval > CHARGE_UPPER_LIMIT_MAX) + return -EINVAL; + return wilco_ec_set_byte_property(ec, PID_CHARGE_UPPER_LIMIT, + val->intval); + default: + return -EINVAL; + } +} + +static int wilco_charge_property_is_writeable(struct power_supply *psy, + enum power_supply_property psp) +{ + return 1; +} + +static const struct power_supply_desc wilco_ps_desc = { + .properties = wilco_charge_props, + .num_properties = ARRAY_SIZE(wilco_charge_props), + .get_property = wilco_charge_get_property, + .set_property = wilco_charge_set_property, + .property_is_writeable = wilco_charge_property_is_writeable, + .name = "wilco-charger", + .type = POWER_SUPPLY_TYPE_MAINS, +}; + +static int wilco_charge_probe(struct platform_device *pdev) +{ + struct wilco_ec_device *ec = dev_get_drvdata(pdev->dev.parent); + struct power_supply_config psy_cfg = {}; + struct power_supply *psy; + + psy_cfg.drv_data = ec; + psy = devm_power_supply_register(&pdev->dev, &wilco_ps_desc, &psy_cfg); + if (IS_ERR(psy)) + return PTR_ERR(psy); + + return 0; +} + +static struct platform_driver wilco_charge_driver = { + .probe = wilco_charge_probe, + .driver = { + .name = DRV_NAME, + } +}; +module_platform_driver(wilco_charge_driver); + +MODULE_ALIAS("platform:" DRV_NAME); +MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>"); +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("Wilco EC charge control driver"); diff --git a/include/linux/platform_data/wilco-ec-properties.h b/include/linux/platform_data/wilco-ec-properties.h new file mode 100644 index 000000000000..acbd10d0fd0e --- /dev/null +++ b/include/linux/platform_data/wilco-ec-properties.h @@ -0,0 +1,68 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Helper library for property access on the Wilco EC. + * + * Copyright 2019 Google LLC + * + * A Property is typically a data item that is stored to NVRAM + * by the EC. Each of these data items has an index associated + * with it, known as the Property ID (PID). Properties may have + * variable lengths, up to a max of WILCO_EC_PROPERTY_MAX_SIZE + * bytes. Properties can be simple integers, or they may be more + * complex binary data. + */ + +#include "wilco-ec.h" + +#define WILCO_EC_PROPERTY_MAX_SIZE 4 + +/* + * Properties are accessed with an operation, or "op". OP_GET + * requests the property from the EC. OP_SET and OP_SYNC do the + * exact same thing from our perspective: save a property. Only + * one of them works for a given property, so each property uses + * either OP_GET and OP_SET, or OP_GET and OP_SYNC. + */ +enum get_set_sync_op { + OP_GET = 0, + OP_SET = 1, + OP_SYNC = 4 +}; + +/** + * struct ec_property_get_msg - Message to retrieve a property. + * @property_id: PID of property to retrieve. + * @length: number of bytes received, set by wilco_ec_get_property(). + * @data: actual property data, set by wilco_ec_get_property(). + */ +struct ec_property_get_msg { + u32 property_id; + int length; + u8 data[WILCO_EC_PROPERTY_MAX_SIZE]; +}; + +/** + * struct ec_property_set_msg - Message to save a property. + * @op: Which subcommand to use, either OP_SET or OP_SYNC + * @property_id: PID of property to save. + * @length: number of bytes to save, must not exceed WILCO_EC_PROPERTY_MAX_SIZE. + * @data: actual property data. + */ +struct ec_property_set_msg { + enum get_set_sync_op op; + u32 property_id; + int length; + u8 data[WILCO_EC_PROPERTY_MAX_SIZE]; +}; + +/* Both of these will return 0 on success, negative error code on failure */ +int wilco_ec_get_property(struct wilco_ec_device *ec, + struct ec_property_get_msg *prop_msg); +int wilco_ec_set_property(struct wilco_ec_device *ec, + struct ec_property_set_msg *prop_msg); + +/* Both of these will return 0 on success, negative error code on failure */ +int wilco_ec_get_byte_property(struct wilco_ec_device *ec, u32 property_id, + u8 *val); +int wilco_ec_set_byte_property(struct wilco_ec_device *ec, u32 property_id, + u8 val); diff --git a/include/linux/platform_data/wilco-ec.h b/include/linux/platform_data/wilco-ec.h index 1ff224793c99..4e7dce897500 100644 --- a/include/linux/platform_data/wilco-ec.h +++ b/include/linux/platform_data/wilco-ec.h @@ -32,6 +32,7 @@ * @data_size: Size of the data buffer used for EC communication. * @debugfs_pdev: The child platform_device used by the debugfs sub-driver. * @rtc_pdev: The child platform_device used by the RTC sub-driver. + * @charging_pdev: Child platform_device used by the charging config sub-driver. */ struct wilco_ec_device { struct device *dev; @@ -43,6 +44,7 @@ struct wilco_ec_device { size_t data_size; struct platform_device *debugfs_pdev; struct platform_device *rtc_pdev; + struct platform_device *charging_pdev; }; /** -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver 2019-04-17 0:43 ` [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews @ 2019-04-19 23:05 ` kbuild test robot 0 siblings, 0 replies; 12+ messages in thread From: kbuild test robot @ 2019-04-19 23:05 UTC (permalink / raw) To: Nick Crews Cc: kbuild-all, enric.balletbo, bleung, sre, linux-pm, linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong, Nick Crews [-- Attachment #1: Type: text/plain, Size: 4208 bytes --] Hi Nick, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc5 next-20190418] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-Add-more-charge-types-and-CHARGE_CONTROL_-properties/20190420-045118 config: i386-randconfig-x017-201915 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All errors (new ones prefixed by >>): drivers/platform/chrome/wilco_ec/core.c: In function 'wilco_ec_probe': >> drivers/platform/chrome/wilco_ec/core.c:106:33: error: 'struct wilco_ec_device' has no member named 'kbbl_pdev'; did you mean 'rtc_pdev'? platform_device_unregister(ec->kbbl_pdev); ^~~~~~~~~ rtc_pdev drivers/platform/chrome/wilco_ec/core.c:105:1: warning: label 'unregister_kbbl' defined but not used [-Wunused-label] unregister_kbbl: ^~~~~~~~~~~~~~~ vim +106 drivers/platform/chrome/wilco_ec/core.c 40 41 static int wilco_ec_probe(struct platform_device *pdev) 42 { 43 struct device *dev = &pdev->dev; 44 struct wilco_ec_device *ec; 45 int ret; 46 47 ec = devm_kzalloc(dev, sizeof(*ec), GFP_KERNEL); 48 if (!ec) 49 return -ENOMEM; 50 51 platform_set_drvdata(pdev, ec); 52 ec->dev = dev; 53 mutex_init(&ec->mailbox_lock); 54 55 /* Largest data buffer size requirement is extended data response */ 56 ec->data_size = sizeof(struct wilco_ec_response) + 57 EC_MAILBOX_DATA_SIZE_EXTENDED; 58 ec->data_buffer = devm_kzalloc(dev, ec->data_size, GFP_KERNEL); 59 if (!ec->data_buffer) 60 return -ENOMEM; 61 62 /* Prepare access to IO regions provided by ACPI */ 63 ec->io_data = wilco_get_resource(pdev, 0); /* Host Data */ 64 ec->io_command = wilco_get_resource(pdev, 1); /* Host Command */ 65 ec->io_packet = wilco_get_resource(pdev, 2); /* MEC EMI */ 66 if (!ec->io_data || !ec->io_command || !ec->io_packet) 67 return -ENODEV; 68 69 /* Initialize cros_ec register interface for communication */ 70 cros_ec_lpc_mec_init(ec->io_packet->start, 71 ec->io_packet->start + EC_MAILBOX_DATA_SIZE); 72 73 /* 74 * Register a child device that will be found by the debugfs driver. 75 * Ignore failure. 76 */ 77 ec->debugfs_pdev = platform_device_register_data(dev, 78 "wilco-ec-debugfs", 79 PLATFORM_DEVID_AUTO, 80 NULL, 0); 81 82 /* Register a child device that will be found by the RTC driver. */ 83 ec->rtc_pdev = platform_device_register_data(dev, "rtc-wilco-ec", 84 PLATFORM_DEVID_AUTO, 85 NULL, 0); 86 if (IS_ERR(ec->rtc_pdev)) { 87 dev_err(dev, "Failed to create RTC platform device\n"); 88 ret = PTR_ERR(ec->rtc_pdev); 89 goto unregister_debugfs; 90 } 91 92 /* Register child device to be found by charging config driver. */ 93 ec->charging_pdev = platform_device_register_data(dev, 94 "wilco-ec-charging", 95 PLATFORM_DEVID_AUTO, 96 NULL, 0); 97 if (IS_ERR(ec->charging_pdev)) { 98 dev_err(dev, "Failed to create charging platform device\n"); 99 ret = PTR_ERR(ec->charging_pdev); 100 goto unregister_rtc; 101 } 102 103 return 0; 104 105 unregister_kbbl: > 106 platform_device_unregister(ec->kbbl_pdev); 107 unregister_rtc: 108 platform_device_unregister(ec->rtc_pdev); 109 unregister_debugfs: 110 if (ec->debugfs_pdev) 111 platform_device_unregister(ec->debugfs_pdev); 112 cros_ec_lpc_mec_destroy(); 113 return ret; 114 } 115 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 27300 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties 2019-04-17 0:43 [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews 2019-04-17 0:43 ` [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews @ 2019-04-17 21:40 ` Sebastian Reichel 2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews 2019-04-18 16:45 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews 1 sibling, 2 replies; 12+ messages in thread From: Sebastian Reichel @ 2019-04-17 21:40 UTC (permalink / raw) To: Nick Crews Cc: enric.balletbo, bleung, linux-pm, linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong [-- Attachment #1: Type: text/plain, Size: 6774 bytes --] Hi, The changes itself look all good to me, but this does multiple things in a single patch, so please split it into multiple commits. -- Sebastian On Tue, Apr 16, 2019 at 06:43:19PM -0600, Nick Crews wrote: > Add "Standard", "Adaptive", and "Custom" modes to the charge_type > property, to expand the existing "Trickle" and "Fast" modes. > In addition, add POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD > and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties, to expand > the existing CHARGE_CONTROL_* properties. I am adding them in order > to support a new Chrome OS device, but these properties should be > general enough that they can be used on other devices. > > The meaning of "Standard" is obvious, but "Adaptive" and "Custom" are > more tricky: "Adaptive" means that the charge controller uses some > custom algorithm to change the charge type automatically, with no > configuration needed. "Custom" means that the charge controller uses the > POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some > other algorithm. For example, in the use case that I am supporting, > this means the battery begins charging when the percentage > level drops below POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and > charging ceases when the percentage level goes above > POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD. > > v4 changes: > - Add documentation for the new properties, and add documentation for > the the previously missing charge_control_limit and > charge_control_limit_max properties. > > Signed-off-by: Nick Crews <ncrews@chromium.org> > --- > Documentation/ABI/testing/sysfs-class-power | 51 +++++++++++++++++++-- > drivers/power/supply/power_supply_sysfs.c | 4 +- > include/linux/power_supply.h | 10 +++- > 3 files changed, 59 insertions(+), 6 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 5e23e22dce1b..b77e30b9014e 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -114,15 +114,60 @@ Description: > Access: Read > Valid values: Represented in microamps > > +What: /sys/class/power_supply/<supply_name>/charge_control_limit > +Date: Oct 2012 > +Contact: linux-pm@vger.kernel.org > +Description: > + Maximum allowable charging current. Used for charge rate > + throttling for thermal cooling or improving battery health. > + > + Access: Read, Write > + Valid values: Represented in microamps > + > +What: /sys/class/power_supply/<supply_name>/charge_control_limit_max > +Date: Oct 2012 > +Contact: linux-pm@vger.kernel.org > +Description: > + Maximum legal value for the charge_control_limit property. > + > + Access: Read > + Valid values: Represented in microamps > + > +What: /sys/class/power_supply/<supply_name>/charge_control_start_threshold > +Date: April 2019 > +Contact: linux-pm@vger.kernel.org > +Description: > + Represents a battery percentage level, below which charging will > + begin. > + > + Access: Read, Write > + Valid values: 0 - 100 (percent) > + > +What: /sys/class/power_supply/<supply_name>/charge_control_end_threshold > +Date: April 2019 > +Contact: linux-pm@vger.kernel.org > +Description: > + Represents a battery percentage level, above which charging will > + stop. > + > + Access: Read, Write > + Valid values: 0 - 100 (percent) > + > What: /sys/class/power_supply/<supply_name>/charge_type > Date: July 2009 > Contact: linux-pm@vger.kernel.org > Description: > Represents the type of charging currently being applied to the > - battery. > + battery. "Trickle", "Fast", and "Standard" all mean different > + charging speeds. "Adaptive" means that the charger uses some > + algorithm to adjust the charge rate dynamically, without > + any user configuration required. "Custom" means that the charger > + uses the charge_control_* properties as configuration for some > + different algorithm. > > - Access: Read > - Valid values: "Unknown", "N/A", "Trickle", "Fast" > + Access: Read, Write > + Valid values: "Unknown", "N/A", "Trickle", "Fast", "Standard", > + "Adaptive", "Custom" > > What: /sys/class/power_supply/<supply_name>/charge_term_current > Date: July 2014 > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > index dce24f596160..6104a3f03d46 100644 > --- a/drivers/power/supply/power_supply_sysfs.c > +++ b/drivers/power/supply/power_supply_sysfs.c > @@ -56,7 +56,7 @@ static const char * const power_supply_status_text[] = { > }; > > static const char * const power_supply_charge_type_text[] = { > - "Unknown", "N/A", "Trickle", "Fast" > + "Unknown", "N/A", "Trickle", "Fast", "Standard", "Adaptive", "Custom" > }; > > static const char * const power_supply_health_text[] = { > @@ -274,6 +274,8 @@ static struct device_attribute power_supply_attrs[] = { > POWER_SUPPLY_ATTR(constant_charge_voltage_max), > POWER_SUPPLY_ATTR(charge_control_limit), > POWER_SUPPLY_ATTR(charge_control_limit_max), > + POWER_SUPPLY_ATTR(charge_control_start_threshold), > + POWER_SUPPLY_ATTR(charge_control_end_threshold), > POWER_SUPPLY_ATTR(input_current_limit), > POWER_SUPPLY_ATTR(energy_full_design), > POWER_SUPPLY_ATTR(energy_empty_design), > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index 2f9c201a54d1..d59205170232 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -40,11 +40,15 @@ enum { > POWER_SUPPLY_STATUS_FULL, > }; > > +/* What algorithm is the charger using? */ > enum { > POWER_SUPPLY_CHARGE_TYPE_UNKNOWN = 0, > POWER_SUPPLY_CHARGE_TYPE_NONE, > - POWER_SUPPLY_CHARGE_TYPE_TRICKLE, > - POWER_SUPPLY_CHARGE_TYPE_FAST, > + POWER_SUPPLY_CHARGE_TYPE_TRICKLE, /* slow speed */ > + POWER_SUPPLY_CHARGE_TYPE_FAST, /* fast speed */ > + POWER_SUPPLY_CHARGE_TYPE_STANDARD, /* normal speed */ > + POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE, /* dynamically adjusted speed */ > + POWER_SUPPLY_CHARGE_TYPE_CUSTOM, /* use CHARGE_CONTROL_* props */ > }; > > enum { > @@ -121,6 +125,8 @@ enum power_supply_property { > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX, > POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT, > POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX, > + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, /* in percents! */ > + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, /* in percents! */ > POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, > POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN, > POWER_SUPPLY_PROP_ENERGY_EMPTY_DESIGN, > -- > 2.20.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types 2019-04-17 21:40 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Sebastian Reichel @ 2019-04-18 16:43 ` Nick Crews 2019-04-18 16:43 ` [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties Nick Crews ` (2 more replies) 2019-04-18 16:45 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews 1 sibling, 3 replies; 12+ messages in thread From: Nick Crews @ 2019-04-18 16:43 UTC (permalink / raw) To: enric.balletbo, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong, Nick Crews Add "Standard", "Adaptive", and "Custom" modes to the charge_type property, to expand the existing "Trickle" and "Fast" modes. I am adding them in order to support a new Chrome OS device, but these properties should be general enough that they can be used on other devices. The meaning of "Standard" is obvious, but "Adaptive" and "Custom" are more tricky: "Adaptive" means that the charge controller uses some custom algorithm to change the charge type automatically, with no configuration needed. "Custom" means that the charge controller uses the POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some other algorithm. v5 changes: - Split up adding the charge types and adding the POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties into two different commits. v4 changes: - Add documentation for the new properties, and add documentation for the the previously missing charge_control_limit and charge_control_limit_max properties. Signed-off-by: Nick Crews <ncrews@chromium.org> --- Documentation/ABI/testing/sysfs-class-power | 12 +++++++++--- drivers/power/supply/power_supply_sysfs.c | 2 +- include/linux/power_supply.h | 8 ++++++-- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power index 5e23e22dce1b..544c4e0ef8b6 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -119,10 +119,16 @@ Date: July 2009 Contact: linux-pm@vger.kernel.org Description: Represents the type of charging currently being applied to the - battery. + battery. "Trickle", "Fast", and "Standard" all mean different + charging speeds. "Adaptive" means that the charger uses some + algorithm to adjust the charge rate dynamically, without + any user configuration required. "Custom" means that the charger + uses the charge_control_* properties as configuration for some + different algorithm. - Access: Read - Valid values: "Unknown", "N/A", "Trickle", "Fast" + Access: Read, Write + Valid values: "Unknown", "N/A", "Trickle", "Fast", "Standard", + "Adaptive", "Custom" What: /sys/class/power_supply/<supply_name>/charge_term_current Date: July 2014 diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index dce24f596160..64dff5cfecc3 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -56,7 +56,7 @@ static const char * const power_supply_status_text[] = { }; static const char * const power_supply_charge_type_text[] = { - "Unknown", "N/A", "Trickle", "Fast" + "Unknown", "N/A", "Trickle", "Fast", "Standard", "Adaptive", "Custom" }; static const char * const power_supply_health_text[] = { diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index 2f9c201a54d1..e86e05d8134d 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -40,11 +40,15 @@ enum { POWER_SUPPLY_STATUS_FULL, }; +/* What algorithm is the charger using? */ enum { POWER_SUPPLY_CHARGE_TYPE_UNKNOWN = 0, POWER_SUPPLY_CHARGE_TYPE_NONE, - POWER_SUPPLY_CHARGE_TYPE_TRICKLE, - POWER_SUPPLY_CHARGE_TYPE_FAST, + POWER_SUPPLY_CHARGE_TYPE_TRICKLE, /* slow speed */ + POWER_SUPPLY_CHARGE_TYPE_FAST, /* fast speed */ + POWER_SUPPLY_CHARGE_TYPE_STANDARD, /* normal speed */ + POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE, /* dynamically adjusted speed */ + POWER_SUPPLY_CHARGE_TYPE_CUSTOM, /* use CHARGE_CONTROL_* props */ }; enum { -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties 2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews @ 2019-04-18 16:43 ` Nick Crews 2019-04-23 13:56 ` Enric Balletbo i Serra 2019-04-18 16:43 ` [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties Nick Crews 2019-04-23 13:55 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Enric Balletbo i Serra 2 siblings, 1 reply; 12+ messages in thread From: Nick Crews @ 2019-04-18 16:43 UTC (permalink / raw) To: enric.balletbo, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong, Nick Crews Add POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties, to expand the existing CHARGE_CONTROL_* properties. I am adding them in order to support a new Chrome OS device, but these properties should be general enough that they can be used on other devices. When the charge_type is "Custom", the charge controller uses the POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some other algorithm. For example, in the use case that I am supporting, this means the battery begins charging when the percentage level drops below POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and charging ceases when the percentage level goes above POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD. v5 changes: - Add the other missing CHARGE_CONTROL_* properties documentation in a separate commit - Split up adding the charge types and adding the POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties into two different commits. v4 changes: - Add documentation for the new properties, and add documentation for the the previously missing charge_control_limit and charge_control_limit_max properties. Signed-off-by: Nick Crews <ncrews@chromium.org> --- Documentation/ABI/testing/sysfs-class-power | 20 ++++++++++++++++++++ drivers/power/supply/power_supply_sysfs.c | 2 ++ include/linux/power_supply.h | 2 ++ 3 files changed, 24 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power index 544c4e0ef8b6..a5b144f61de8 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -114,6 +114,26 @@ Description: Access: Read Valid values: Represented in microamps +What: /sys/class/power_supply/<supply_name>/charge_control_start_threshold +Date: April 2019 +Contact: linux-pm@vger.kernel.org +Description: + Represents a battery percentage level, below which charging will + begin. + + Access: Read, Write + Valid values: 0 - 100 (percent) + +What: /sys/class/power_supply/<supply_name>/charge_control_end_threshold +Date: April 2019 +Contact: linux-pm@vger.kernel.org +Description: + Represents a battery percentage level, above which charging will + stop. + + Access: Read, Write + Valid values: 0 - 100 (percent) + What: /sys/class/power_supply/<supply_name>/charge_type Date: July 2009 Contact: linux-pm@vger.kernel.org diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index 64dff5cfecc3..6104a3f03d46 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -274,6 +274,8 @@ static struct device_attribute power_supply_attrs[] = { POWER_SUPPLY_ATTR(constant_charge_voltage_max), POWER_SUPPLY_ATTR(charge_control_limit), POWER_SUPPLY_ATTR(charge_control_limit_max), + POWER_SUPPLY_ATTR(charge_control_start_threshold), + POWER_SUPPLY_ATTR(charge_control_end_threshold), POWER_SUPPLY_ATTR(input_current_limit), POWER_SUPPLY_ATTR(energy_full_design), POWER_SUPPLY_ATTR(energy_empty_design), diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h index e86e05d8134d..d59205170232 100644 --- a/include/linux/power_supply.h +++ b/include/linux/power_supply.h @@ -125,6 +125,8 @@ enum power_supply_property { POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX, POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT, POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX, + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, /* in percents! */ + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, /* in percents! */ POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN, POWER_SUPPLY_PROP_ENERGY_EMPTY_DESIGN, -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties 2019-04-18 16:43 ` [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties Nick Crews @ 2019-04-23 13:56 ` Enric Balletbo i Serra 0 siblings, 0 replies; 12+ messages in thread From: Enric Balletbo i Serra @ 2019-04-23 13:56 UTC (permalink / raw) To: Nick Crews, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong On 18/4/19 18:43, Nick Crews wrote: > Add POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD > and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties, to expand > the existing CHARGE_CONTROL_* properties. I am adding them in order > to support a new Chrome OS device, but these properties should be > general enough that they can be used on other devices. > > When the charge_type is "Custom", the charge controller uses the > POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some > other algorithm. For example, in the use case that I am supporting, > this means the battery begins charging when the percentage > level drops below POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and > charging ceases when the percentage level goes above > POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD. > > v5 changes: > - Add the other missing CHARGE_CONTROL_* properties documentation in > a separate commit > - Split up adding the charge types and adding the > POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and > POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties into > two different commits. > v4 changes: > - Add documentation for the new properties, and add documentation for > the the previously missing charge_control_limit and > charge_control_limit_max properties. > > Signed-off-by: Nick Crews <ncrews@chromium.org> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > Documentation/ABI/testing/sysfs-class-power | 20 ++++++++++++++++++++ > drivers/power/supply/power_supply_sysfs.c | 2 ++ > include/linux/power_supply.h | 2 ++ > 3 files changed, 24 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 544c4e0ef8b6..a5b144f61de8 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -114,6 +114,26 @@ Description: > Access: Read > Valid values: Represented in microamps > > +What: /sys/class/power_supply/<supply_name>/charge_control_start_threshold > +Date: April 2019 > +Contact: linux-pm@vger.kernel.org > +Description: > + Represents a battery percentage level, below which charging will > + begin. > + > + Access: Read, Write > + Valid values: 0 - 100 (percent) > + > +What: /sys/class/power_supply/<supply_name>/charge_control_end_threshold > +Date: April 2019 > +Contact: linux-pm@vger.kernel.org > +Description: > + Represents a battery percentage level, above which charging will > + stop. > + > + Access: Read, Write > + Valid values: 0 - 100 (percent) > + > What: /sys/class/power_supply/<supply_name>/charge_type > Date: July 2009 > Contact: linux-pm@vger.kernel.org > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > index 64dff5cfecc3..6104a3f03d46 100644 > --- a/drivers/power/supply/power_supply_sysfs.c > +++ b/drivers/power/supply/power_supply_sysfs.c > @@ -274,6 +274,8 @@ static struct device_attribute power_supply_attrs[] = { > POWER_SUPPLY_ATTR(constant_charge_voltage_max), > POWER_SUPPLY_ATTR(charge_control_limit), > POWER_SUPPLY_ATTR(charge_control_limit_max), > + POWER_SUPPLY_ATTR(charge_control_start_threshold), > + POWER_SUPPLY_ATTR(charge_control_end_threshold), > POWER_SUPPLY_ATTR(input_current_limit), > POWER_SUPPLY_ATTR(energy_full_design), > POWER_SUPPLY_ATTR(energy_empty_design), > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index e86e05d8134d..d59205170232 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -125,6 +125,8 @@ enum power_supply_property { > POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX, > POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT, > POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX, > + POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD, /* in percents! */ > + POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD, /* in percents! */ > POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, > POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN, > POWER_SUPPLY_PROP_ENERGY_EMPTY_DESIGN, > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties 2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews 2019-04-18 16:43 ` [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties Nick Crews @ 2019-04-18 16:43 ` Nick Crews 2019-04-23 13:56 ` Enric Balletbo i Serra 2019-04-23 13:55 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Enric Balletbo i Serra 2 siblings, 1 reply; 12+ messages in thread From: Nick Crews @ 2019-04-18 16:43 UTC (permalink / raw) To: enric.balletbo, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong, Nick Crews The existing POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT and POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX properties don't have documentation. I add that documentation here. v5 changes: - Split this commit out from the previous two commits. Signed-off-by: Nick Crews <ncrews@chromium.org> --- Documentation/ABI/testing/sysfs-class-power | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power index a5b144f61de8..b77e30b9014e 100644 --- a/Documentation/ABI/testing/sysfs-class-power +++ b/Documentation/ABI/testing/sysfs-class-power @@ -114,6 +114,25 @@ Description: Access: Read Valid values: Represented in microamps +What: /sys/class/power_supply/<supply_name>/charge_control_limit +Date: Oct 2012 +Contact: linux-pm@vger.kernel.org +Description: + Maximum allowable charging current. Used for charge rate + throttling for thermal cooling or improving battery health. + + Access: Read, Write + Valid values: Represented in microamps + +What: /sys/class/power_supply/<supply_name>/charge_control_limit_max +Date: Oct 2012 +Contact: linux-pm@vger.kernel.org +Description: + Maximum legal value for the charge_control_limit property. + + Access: Read + Valid values: Represented in microamps + What: /sys/class/power_supply/<supply_name>/charge_control_start_threshold Date: April 2019 Contact: linux-pm@vger.kernel.org -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties 2019-04-18 16:43 ` [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties Nick Crews @ 2019-04-23 13:56 ` Enric Balletbo i Serra 0 siblings, 0 replies; 12+ messages in thread From: Enric Balletbo i Serra @ 2019-04-23 13:56 UTC (permalink / raw) To: Nick Crews, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong On 18/4/19 18:43, Nick Crews wrote: > The existing POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT and > POWER_SUPPLY_PROP_CHARGE_CONTROL_LIMIT_MAX properties > don't have documentation. I add that documentation here. > > v5 changes: > - Split this commit out from the previous two commits. > > Signed-off-by: Nick Crews <ncrews@chromium.org> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > Documentation/ABI/testing/sysfs-class-power | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index a5b144f61de8..b77e30b9014e 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -114,6 +114,25 @@ Description: > Access: Read > Valid values: Represented in microamps > > +What: /sys/class/power_supply/<supply_name>/charge_control_limit > +Date: Oct 2012 > +Contact: linux-pm@vger.kernel.org > +Description: > + Maximum allowable charging current. Used for charge rate > + throttling for thermal cooling or improving battery health. > + > + Access: Read, Write > + Valid values: Represented in microamps > + > +What: /sys/class/power_supply/<supply_name>/charge_control_limit_max > +Date: Oct 2012 > +Contact: linux-pm@vger.kernel.org > +Description: > + Maximum legal value for the charge_control_limit property. > + > + Access: Read > + Valid values: Represented in microamps > + > What: /sys/class/power_supply/<supply_name>/charge_control_start_threshold > Date: April 2019 > Contact: linux-pm@vger.kernel.org > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types 2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews 2019-04-18 16:43 ` [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties Nick Crews 2019-04-18 16:43 ` [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties Nick Crews @ 2019-04-23 13:55 ` Enric Balletbo i Serra [not found] ` <CAHX4x87APA8eSD0pCwkBFcR_JxRQsxsH-Ur7186BnHBF=PZf+A@mail.gmail.com> 2 siblings, 1 reply; 12+ messages in thread From: Enric Balletbo i Serra @ 2019-04-23 13:55 UTC (permalink / raw) To: Nick Crews, bleung, sre, linux-pm Cc: linux-kernel, dlaurie, lamzin, bartfab, derat, dtor, sjg, jchwong On 18/4/19 18:43, Nick Crews wrote: > Add "Standard", "Adaptive", and "Custom" modes to the charge_type > property, to expand the existing "Trickle" and "Fast" modes. > I am adding them in order to support a new Chrome OS device, > but these properties should be general enough that they can be > used on other devices. > > The meaning of "Standard" is obvious, but "Adaptive" and "Custom" are > more tricky: "Adaptive" means that the charge controller uses some > custom algorithm to change the charge type automatically, with no > configuration needed. "Custom" means that the charge controller uses the > POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some > other algorithm. > > v5 changes: > - Split up adding the charge types and adding the > POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and > POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties into > two different commits. > v4 changes: > - Add documentation for the new properties, and add documentation for > the the previously missing charge_control_limit and > charge_control_limit_max properties. > > Signed-off-by: Nick Crews <ncrews@chromium.org> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > Documentation/ABI/testing/sysfs-class-power | 12 +++++++++--- > drivers/power/supply/power_supply_sysfs.c | 2 +- > include/linux/power_supply.h | 8 ++++++-- > 3 files changed, 16 insertions(+), 6 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 5e23e22dce1b..544c4e0ef8b6 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -119,10 +119,16 @@ Date: July 2009 > Contact: linux-pm@vger.kernel.org > Description: > Represents the type of charging currently being applied to the > - battery. > + battery. "Trickle", "Fast", and "Standard" all mean different > + charging speeds. "Adaptive" means that the charger uses some > + algorithm to adjust the charge rate dynamically, without > + any user configuration required. "Custom" means that the charger > + uses the charge_control_* properties as configuration for some > + different algorithm. > > - Access: Read > - Valid values: "Unknown", "N/A", "Trickle", "Fast" > + Access: Read, Write > + Valid values: "Unknown", "N/A", "Trickle", "Fast", "Standard", > + "Adaptive", "Custom" > > What: /sys/class/power_supply/<supply_name>/charge_term_current > Date: July 2014 > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > index dce24f596160..64dff5cfecc3 100644 > --- a/drivers/power/supply/power_supply_sysfs.c > +++ b/drivers/power/supply/power_supply_sysfs.c > @@ -56,7 +56,7 @@ static const char * const power_supply_status_text[] = { > }; > > static const char * const power_supply_charge_type_text[] = { > - "Unknown", "N/A", "Trickle", "Fast" > + "Unknown", "N/A", "Trickle", "Fast", "Standard", "Adaptive", "Custom" > }; > > static const char * const power_supply_health_text[] = { > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index 2f9c201a54d1..e86e05d8134d 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -40,11 +40,15 @@ enum { > POWER_SUPPLY_STATUS_FULL, > }; > > +/* What algorithm is the charger using? */ > enum { > POWER_SUPPLY_CHARGE_TYPE_UNKNOWN = 0, > POWER_SUPPLY_CHARGE_TYPE_NONE, > - POWER_SUPPLY_CHARGE_TYPE_TRICKLE, > - POWER_SUPPLY_CHARGE_TYPE_FAST, > + POWER_SUPPLY_CHARGE_TYPE_TRICKLE, /* slow speed */ > + POWER_SUPPLY_CHARGE_TYPE_FAST, /* fast speed */ > + POWER_SUPPLY_CHARGE_TYPE_STANDARD, /* normal speed */ > + POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE, /* dynamically adjusted speed */ > + POWER_SUPPLY_CHARGE_TYPE_CUSTOM, /* use CHARGE_CONTROL_* props */ > }; > > enum { > ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <CAHX4x87APA8eSD0pCwkBFcR_JxRQsxsH-Ur7186BnHBF=PZf+A@mail.gmail.com>]
* Re: [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types [not found] ` <CAHX4x87APA8eSD0pCwkBFcR_JxRQsxsH-Ur7186BnHBF=PZf+A@mail.gmail.com> @ 2019-05-01 23:27 ` Sebastian Reichel 0 siblings, 0 replies; 12+ messages in thread From: Sebastian Reichel @ 2019-05-01 23:27 UTC (permalink / raw) To: Nick Crews Cc: Benson Leung, linux-pm, linux-kernel, Duncan Laurie, Oleh Lamzin, Bartosz Fabianowski, Daniel Erat, Dmitry Torokhov, Simon Glass, jchwong, Enric Balletbo i Serra [-- Attachment #1: Type: text/plain, Size: 5146 bytes --] Hi Nick, Yes. I merged the three patches adding the generic power supply properties, thanks. -- Sebastian On Wed, May 01, 2019 at 10:34:38AM -0600, Nick Crews wrote: > Hi Sebastian, does this look like an acceptable way of splitting up the > content into multiple commits? > > Sorry to bug, and thanks, > Nick > > On Tue, Apr 23, 2019 at 7:55 AM Enric Balletbo i Serra < > enric.balletbo@collabora.com> wrote: > > > > > > > On 18/4/19 18:43, Nick Crews wrote: > > > Add "Standard", "Adaptive", and "Custom" modes to the charge_type > > > property, to expand the existing "Trickle" and "Fast" modes. > > > I am adding them in order to support a new Chrome OS device, > > > but these properties should be general enough that they can be > > > used on other devices. > > > > > > The meaning of "Standard" is obvious, but "Adaptive" and "Custom" are > > > more tricky: "Adaptive" means that the charge controller uses some > > > custom algorithm to change the charge type automatically, with no > > > configuration needed. "Custom" means that the charge controller uses the > > > POWER_SUPPLY_PROP_CHARGE_CONTROL_* properties as configuration for some > > > other algorithm. > > > > > > v5 changes: > > > - Split up adding the charge types and adding the > > > POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD and > > > POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD properties into > > > two different commits. > > > v4 changes: > > > - Add documentation for the new properties, and add documentation for > > > the the previously missing charge_control_limit and > > > charge_control_limit_max properties. > > > > > > Signed-off-by: Nick Crews <ncrews@chromium.org> > > > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > > > > --- > > > Documentation/ABI/testing/sysfs-class-power | 12 +++++++++--- > > > drivers/power/supply/power_supply_sysfs.c | 2 +- > > > include/linux/power_supply.h | 8 ++++++-- > > > 3 files changed, 16 insertions(+), 6 deletions(-) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-class-power > > b/Documentation/ABI/testing/sysfs-class-power > > > index 5e23e22dce1b..544c4e0ef8b6 100644 > > > --- a/Documentation/ABI/testing/sysfs-class-power > > > +++ b/Documentation/ABI/testing/sysfs-class-power > > > @@ -119,10 +119,16 @@ Date: July 2009 > > > Contact: linux-pm@vger.kernel.org > > > Description: > > > Represents the type of charging currently being applied to > > the > > > - battery. > > > + battery. "Trickle", "Fast", and "Standard" all mean > > different > > > + charging speeds. "Adaptive" means that the charger uses > > some > > > + algorithm to adjust the charge rate dynamically, without > > > + any user configuration required. "Custom" means that the > > charger > > > + uses the charge_control_* properties as configuration for > > some > > > + different algorithm. > > > > > > - Access: Read > > > - Valid values: "Unknown", "N/A", "Trickle", "Fast" > > > + Access: Read, Write > > > + Valid values: "Unknown", "N/A", "Trickle", "Fast", > > "Standard", > > > + "Adaptive", "Custom" > > > > > > What: > > /sys/class/power_supply/<supply_name>/charge_term_current > > > Date: July 2014 > > > diff --git a/drivers/power/supply/power_supply_sysfs.c > > b/drivers/power/supply/power_supply_sysfs.c > > > index dce24f596160..64dff5cfecc3 100644 > > > --- a/drivers/power/supply/power_supply_sysfs.c > > > +++ b/drivers/power/supply/power_supply_sysfs.c > > > @@ -56,7 +56,7 @@ static const char * const power_supply_status_text[] = > > { > > > }; > > > > > > static const char * const power_supply_charge_type_text[] = { > > > - "Unknown", "N/A", "Trickle", "Fast" > > > + "Unknown", "N/A", "Trickle", "Fast", "Standard", "Adaptive", > > "Custom" > > > }; > > > > > > static const char * const power_supply_health_text[] = { > > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > > > index 2f9c201a54d1..e86e05d8134d 100644 > > > --- a/include/linux/power_supply.h > > > +++ b/include/linux/power_supply.h > > > @@ -40,11 +40,15 @@ enum { > > > POWER_SUPPLY_STATUS_FULL, > > > }; > > > > > > +/* What algorithm is the charger using? */ > > > enum { > > > POWER_SUPPLY_CHARGE_TYPE_UNKNOWN = 0, > > > POWER_SUPPLY_CHARGE_TYPE_NONE, > > > - POWER_SUPPLY_CHARGE_TYPE_TRICKLE, > > > - POWER_SUPPLY_CHARGE_TYPE_FAST, > > > + POWER_SUPPLY_CHARGE_TYPE_TRICKLE, /* slow speed */ > > > + POWER_SUPPLY_CHARGE_TYPE_FAST, /* fast speed */ > > > + POWER_SUPPLY_CHARGE_TYPE_STANDARD, /* normal speed */ > > > + POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE, /* dynamically adjusted > > speed */ > > > + POWER_SUPPLY_CHARGE_TYPE_CUSTOM, /* use CHARGE_CONTROL_* > > props */ > > > }; > > > > > > enum { > > > > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties 2019-04-17 21:40 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Sebastian Reichel 2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews @ 2019-04-18 16:45 ` Nick Crews 1 sibling, 0 replies; 12+ messages in thread From: Nick Crews @ 2019-04-18 16:45 UTC (permalink / raw) To: Sebastian Reichel Cc: Enric Balletbo i Serra, Benson Leung, linux-pm, linux-kernel, Duncan Laurie, Oleh Lamzin, Bartosz Fabianowski, Daniel Erat, Dmitry Torokhov, Simon Glass, jchwong On Wed, Apr 17, 2019 at 3:40 PM Sebastian Reichel <sre@kernel.org> wrote: > > Hi, > > The changes itself look all good to me, but this does multiple > things in a single patch, so please split it into multiple commits. Thanks Sebastian! I split this into 3 commits: -add more charge_type's -add more CHARGE_CONTROL_* properties -Add missing documentation for other CHARGE_CONTROL_* properties and just re-sent them. > > -- Sebastian > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-05-01 23:27 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 0:43 [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews
2019-04-17 0:43 ` [PATCH v4 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-04-19 23:05 ` kbuild test robot
2019-04-17 21:40 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Sebastian Reichel
2019-04-18 16:43 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Nick Crews
2019-04-18 16:43 ` [PATCH v5 2/3] power_supply: Add CHARGE_CONTROL_{START_THRESHOLD,END_THRESHOLD} properties Nick Crews
2019-04-23 13:56 ` Enric Balletbo i Serra
2019-04-18 16:43 ` [PATCH v5 3/3] power_supply: Add missing documentation for CHARGE_CONTROL_* properties Nick Crews
2019-04-23 13:56 ` Enric Balletbo i Serra
2019-04-23 13:55 ` [PATCH v5 1/3] power_supply: Add Standard, Adaptive, and Custom charge types Enric Balletbo i Serra
[not found] ` <CAHX4x87APA8eSD0pCwkBFcR_JxRQsxsH-Ur7186BnHBF=PZf+A@mail.gmail.com>
2019-05-01 23:27 ` Sebastian Reichel
2019-04-18 16:45 ` [PATCH v4 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).