* [next] kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build
@ 2019-04-19 8:33 Sergey Senozhatsky
2019-04-19 8:59 ` yamada.masahiro
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2019-04-19 8:33 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kernel, Sergey Senozhatsky
Hello Masahiro,
It seems that commit a9a49c2ad9b9b8 (linux-next) breaks ./scripts/tags.sh
on my system. It scans, basically, my entire drive now (including the
root partition):
$ ./scripts/tags.sh tags
find: ‘/arch/*.[chS]/’: No such file or directory
find: ‘/include’: No such file or directory
find: ‘/boot/lost+found’: Permission denied
find: ‘/etc/pacman.d/gnupg/openpgp-revocs.d’: Permission denied
find: ‘/etc/pacman.d/gnupg/private-keys-v1.d’: Permission denied
find: ‘/etc/pacman.d/gnupg/crls.d’: Permission denied
find: ‘/etc/polkit-1/rules.d’: Permission denied
find: ‘/etc/sudoers.d’: Permission denied
find: ‘/etc/audisp/plugins.d’: Permission denied
find: ‘/home/lost+found’: Permission denied
find: ‘/home/sk’: Permission denied
find: ‘/lost+found’: Permission denied
ctags: Warning: --extra option is obsolete; use --extras instead
[..]
With reverted a9a49c2ad9b9b8 tags scans kernel source tree only
./scripts/tags.sh tags
find: ‘arch/*.[chS]/’: No such file or directory
ctags: Warning: --extra option is obsolete; use --extras instead
[..]
-ss
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [next] kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build
2019-04-19 8:33 [next] kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build Sergey Senozhatsky
@ 2019-04-19 8:59 ` yamada.masahiro
2019-04-19 12:33 ` Sergey Senozhatsky
0 siblings, 1 reply; 3+ messages in thread
From: yamada.masahiro @ 2019-04-19 8:59 UTC (permalink / raw)
To: sergey.senozhatsky.work; +Cc: linux-kernel, sergey.senozhatsky
Hi Sergey,
> -----Original Message-----
> From: Sergey Senozhatsky [mailto:sergey.senozhatsky.work@gmail.com]
> Sent: Friday, April 19, 2019 5:34 PM
> To: Yamada, Masahiro/山田 真弘 <yamada.masahiro@socionext.com>
> Cc: linux-kernel@vger.kernel.org; Sergey Senozhatsky
> <sergey.senozhatsky@gmail.com>
> Subject: [next] kbuild: use $(srctree) instead of KBUILD_SRC to check
> out-of-tree build
>
> Hello Masahiro,
>
> It seems that commit a9a49c2ad9b9b8 (linux-next) breaks ./scripts/tags.sh
> on my system. It scans, basically, my entire drive now (including the
> root partition):
>
> $ ./scripts/tags.sh tags
I did not know this script is run directly
because I expected people were using 'make tags'.
It is easy to fix, though.
diff --git a/scripts/tags.sh b/scripts/tags.sh
index 6a551805db52..70e14c67bde7 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -19,7 +19,7 @@ ignore="$ignore ( -name *.mod.c ) -prune -o"
# Do not use full path if we do not use O=.. builds
# Use make O=. {tags|cscope}
# to force full paths for a non-O= build
-if [ "${srctree}" = "." ]; then
+if [ "${srctree}" = "." -o -z "${srctree}" ]; then
tree=
else
tree=${srctree}/
> find: ‘/arch/*.[chS]/’: No such file or directory
> find: ‘/include’: No such file or directory
> find: ‘/boot/lost+found’: Permission denied
> find: ‘/etc/pacman.d/gnupg/openpgp-revocs.d’: Permission denied
> find: ‘/etc/pacman.d/gnupg/private-keys-v1.d’: Permission denied
> find: ‘/etc/pacman.d/gnupg/crls.d’: Permission denied
> find: ‘/etc/polkit-1/rules.d’: Permission denied
> find: ‘/etc/sudoers.d’: Permission denied
> find: ‘/etc/audisp/plugins.d’: Permission denied
> find: ‘/home/lost+found’: Permission denied
> find: ‘/home/sk’: Permission denied
> find: ‘/lost+found’: Permission denied
> ctags: Warning: --extra option is obsolete; use --extras instead
> [..]
>
>
> With reverted a9a49c2ad9b9b8 tags scans kernel source tree only
>
> ./scripts/tags.sh tags
> find: ‘arch/*.[chS]/’: No such file or directory
> ctags: Warning: --extra option is obsolete; use --extras instead
> [..]
>
> -ss
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [next] kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build
2019-04-19 8:59 ` yamada.masahiro
@ 2019-04-19 12:33 ` Sergey Senozhatsky
0 siblings, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2019-04-19 12:33 UTC (permalink / raw)
To: yamada.masahiro; +Cc: sergey.senozhatsky.work, linux-kernel, sergey.senozhatsky
On (04/19/19 08:59), yamada.masahiro@socionext.com wrote:
> > It seems that commit a9a49c2ad9b9b8 (linux-next) breaks ./scripts/tags.sh
> > on my system. It scans, basically, my entire drive now (including the
> > root partition):
> >
> > $ ./scripts/tags.sh tags
>
> I did not know this script is run directly
> because I expected people were using 'make tags'.
:) I always run it directly, didn't even know there was 'make tags'
> It is easy to fix, though.
Works fine.
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-19 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 8:33 [next] kbuild: use $(srctree) instead of KBUILD_SRC to check out-of-tree build Sergey Senozhatsky
2019-04-19 8:59 ` yamada.masahiro
2019-04-19 12:33 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).