* [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd()
@ 2019-04-19 21:11 Madhumitha Prabakaran
2019-04-20 21:02 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Madhumitha Prabakaran @ 2019-04-19 21:11 UTC (permalink / raw)
To: gregkh, matthias.bgg, devel, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Madhumitha Prabakaran
Remove unwanted variable and replace the respective return type.
Issue suggested by Coccinelle.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/mt7621-mmc/sd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
index b12ed2c988fd..2b327fde7145 100644
--- a/drivers/staging/mt7621-mmc/sd.c
+++ b/drivers/staging/mt7621-mmc/sd.c
@@ -752,7 +752,6 @@ static int msdc_app_cmd(struct mmc_host *mmc, struct msdc_host *host)
{
struct mmc_command cmd;
struct mmc_request mrq;
- u32 err;
memset(&cmd, 0, sizeof(struct mmc_command));
cmd.opcode = MMC_APP_CMD;
@@ -763,8 +762,7 @@ static int msdc_app_cmd(struct mmc_host *mmc, struct msdc_host *host)
mrq.cmd = &cmd; cmd.mrq = &mrq;
cmd.data = NULL;
- err = msdc_do_command(host, &cmd, 0, CMD_TIMEOUT);
- return err;
+ return msdc_do_command(host, &cmd, 0, CMD_TIMEOUT);
}
static int msdc_tune_cmdrsp(struct msdc_host *host, struct mmc_command *cmd)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd()
2019-04-19 21:11 [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd() Madhumitha Prabakaran
@ 2019-04-20 21:02 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-04-20 21:02 UTC (permalink / raw)
To: Madhumitha Prabakaran
Cc: matthias.bgg, devel, linux-arm-kernel, linux-mediatek, linux-kernel
On Fri, Apr 19, 2019 at 04:11:30PM -0500, Madhumitha Prabakaran wrote:
> Remove unwanted variable and replace the respective return type.
>
> Issue suggested by Coccinelle.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/mt7621-mmc/sd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
This file is long deleted. Always make sure you work off of the latest
development tree for the subsystem you are wanting to contribute to. Or
on linux-next at the least.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-20 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 21:11 [PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd() Madhumitha Prabakaran
2019-04-20 21:02 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).