* [PATCH v2 01/06] atm: iphase: fix misuse of %x
@ 2019-04-21 11:46 Fuqian Huang
2019-04-21 17:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-04-21 11:46 UTC (permalink / raw)
Cc: Fuqian Huang, Chas Williams, linux-atm-general, netdev, linux-kernel
Pointers should be printed with %p or %px rather than
cast to long type and printed with %x.
Change %x to %p to print the pointers.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/atm/iphase.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 82532c2..5278c57 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -2826,8 +2826,8 @@ static int ia_ioctl(struct atm_dev *dev, unsigned int cmd, void __user *arg)
case 0x6:
{
ia_cmds.status = 0;
- printk("skb = 0x%lx\n", (long)skb_peek(&iadev->tx_backlog));
- printk("rtn_q: 0x%lx\n",(long)ia_deque_rtn_q(&iadev->tx_return_q));
+ printk("skb = 0x%p\n", skb_peek(&iadev->tx_backlog));
+ printk("rtn_q: 0x%p\n",ia_deque_rtn_q(&iadev->tx_return_q));
}
break;
case 0x8:
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 01/06] atm: iphase: fix misuse of %x
2019-04-21 11:46 [PATCH v2 01/06] atm: iphase: fix misuse of %x Fuqian Huang
@ 2019-04-21 17:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-04-21 17:37 UTC (permalink / raw)
To: huangfq.daxian; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel
From: Fuqian Huang <huangfq.daxian@gmail.com>
Date: Sun, 21 Apr 2019 19:46:54 +0800
> Pointers should be printed with %p or %px rather than
> cast to long type and printed with %x.
> Change %x to %p to print the pointers.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-21 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-21 11:46 [PATCH v2 01/06] atm: iphase: fix misuse of %x Fuqian Huang
2019-04-21 17:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).