* [PATCH] kvm_main: fix some comments
@ 2019-04-23 9:40 Jiang Biao
2019-04-23 11:11 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Jiang Biao @ 2019-04-23 9:40 UTC (permalink / raw)
To: pbonzini, rkrcmar; +Cc: kvm, linux-kernel, benbjiang
is_dirty has been rename to flush, but the comment for it is
outdated. And the description about @flush parameter for
kvm_clear_dirty_log_protect() is missing, add it in this patch
also.
Signed-off-by: Jiang Biao <benbjiang@tencent.com>
---
virt/kvm/kvm_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index dc8edc97ba85..40b435e77672 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1138,7 +1138,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log);
* and reenable dirty page tracking for the corresponding pages.
* @kvm: pointer to kvm instance
* @log: slot id and address to which we copy the log
- * @is_dirty: flag set if any page is dirty
+ * @flush: if TLB flush is needed by caller
*
* We need to keep it in mind that VCPU threads can write to the bitmap
* concurrently. So, to avoid losing track of dirty pages we keep the
@@ -1223,6 +1223,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log_protect);
* and reenable dirty page tracking for the corresponding pages.
* @kvm: pointer to kvm instance
* @log: slot id and address from which to fetch the bitmap of dirty pages
+ * @flush: if TLB flush is needed by caller
*/
int kvm_clear_dirty_log_protect(struct kvm *kvm,
struct kvm_clear_dirty_log *log, bool *flush)
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm_main: fix some comments
2019-04-23 9:40 [PATCH] kvm_main: fix some comments Jiang Biao
@ 2019-04-23 11:11 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2019-04-23 11:11 UTC (permalink / raw)
To: Jiang Biao; +Cc: pbonzini, rkrcmar, kvm, linux-kernel
On Tue, 23 Apr 2019 17:40:08 +0800
Jiang Biao <benbjiang@tencent.com> wrote:
> is_dirty has been rename to flush, but the comment for it is
s/rename/renamed/
> outdated. And the description about @flush parameter for
> kvm_clear_dirty_log_protect() is missing, add it in this patch
> also.
>
> Signed-off-by: Jiang Biao <benbjiang@tencent.com>
> ---
> virt/kvm/kvm_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index dc8edc97ba85..40b435e77672 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1138,7 +1138,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log);
> * and reenable dirty page tracking for the corresponding pages.
BTW: Not seen in the diff, but this line and the preceding one do not
really form a sentence that makes sense :) Maybe fix that as well, as
you are touching the area anyway?
> * @kvm: pointer to kvm instance
> * @log: slot id and address to which we copy the log
> - * @is_dirty: flag set if any page is dirty
> + * @flush: if TLB flush is needed by caller
Hm, maybe "true if TLB flush is needed by caller"?
> *
> * We need to keep it in mind that VCPU threads can write to the bitmap
> * concurrently. So, to avoid losing track of dirty pages we keep the
> @@ -1223,6 +1223,7 @@ EXPORT_SYMBOL_GPL(kvm_get_dirty_log_protect);
> * and reenable dirty page tracking for the corresponding pages.
> * @kvm: pointer to kvm instance
> * @log: slot id and address from which to fetch the bitmap of dirty pages
> + * @flush: if TLB flush is needed by caller
> */
> int kvm_clear_dirty_log_protect(struct kvm *kvm,
> struct kvm_clear_dirty_log *log, bool *flush)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-23 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 9:40 [PATCH] kvm_main: fix some comments Jiang Biao
2019-04-23 11:11 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).