* [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
@ 2019-04-24 7:59 Yue Haibing
2019-04-24 8:11 ` Leonard Crestez
2019-04-24 9:15 ` [PATCH v2] " Yue Haibing
0 siblings, 2 replies; 6+ messages in thread
From: Yue Haibing @ 2019-04-24 7:59 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, linux-imx, l.stach,
aisheng.dong, leonard.crestez, abel.vesa, Anson.Huang
Cc: linux-kernel, linux-arm-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
During randconfig builds, I occasionally run into an invalid configuration
drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
while CONFIG_SOC_BUS is not set, the building failed like this. This patch
selects SOC_BUS to fix it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: a7e26f356ca1 ("soc: imx: Add generic i.MX8 SoC driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index d80f899..2fb4e47 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS
depends on ARCH_MXC || (COMPILE_TEST && OF)
depends on PM
select PM_GENERIC_DOMAINS
+ select SOC_BUS
default y if SOC_IMX7D
endmenu
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
2019-04-24 7:59 [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS Yue Haibing
@ 2019-04-24 8:11 ` Leonard Crestez
2019-04-24 8:47 ` YueHaibing
2019-04-24 9:15 ` [PATCH v2] " Yue Haibing
1 sibling, 1 reply; 6+ messages in thread
From: Leonard Crestez @ 2019-04-24 8:11 UTC (permalink / raw)
To: Yue Haibing, shawnguo, Abel Vesa
Cc: s.hauer, kernel, festevam, dl-linux-imx, l.stach, Aisheng Dong,
Anson Huang, linux-kernel, linux-arm-kernel
On 4/24/2019 11:00 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> During randconfig builds, I occasionally run into an invalid configuration
>
> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
>
> while CONFIG_SOC_BUS is not set, the building failed like this. This patch
> selects SOC_BUS to fix it.
>
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS
> depends on ARCH_MXC || (COMPILE_TEST && OF)
> depends on PM
> select PM_GENERIC_DOMAINS
> + select SOC_BUS
> default y if SOC_IMX7D
You should "select SOC_BUS" from "config ARCH_MXC" in arm64
Kconfig.platforms, not from a power domain implementation.
Your patch works because arm64 ARCH_MXC currently does "select
IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary.
--
Regards,
Leonard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
2019-04-24 8:11 ` Leonard Crestez
@ 2019-04-24 8:47 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-04-24 8:47 UTC (permalink / raw)
To: Leonard Crestez, shawnguo, Abel Vesa
Cc: s.hauer, kernel, festevam, dl-linux-imx, l.stach, Aisheng Dong,
Anson Huang, linux-kernel, linux-arm-kernel
On 2019/4/24 16:11, Leonard Crestez wrote:
> On 4/24/2019 11:00 AM, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> During randconfig builds, I occasionally run into an invalid configuration
>>
>> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
>> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
>>
>> while CONFIG_SOC_BUS is not set, the building failed like this. This patch
>> selects SOC_BUS to fix it.
>>
>> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
>> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS
>> depends on ARCH_MXC || (COMPILE_TEST && OF)
>> depends on PM
>> select PM_GENERIC_DOMAINS
>> + select SOC_BUS
>> default y if SOC_IMX7D
>
> You should "select SOC_BUS" from "config ARCH_MXC" in arm64
> Kconfig.platforms, not from a power domain implementation.
>
> Your patch works because arm64 ARCH_MXC currently does "select
> IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary.
Yes, you are right, thanks!
>
> --
> Regards,
> Leonard
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] soc: imx: Fix build error without CONFIG_SOC_BUS
2019-04-24 7:59 [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS Yue Haibing
2019-04-24 8:11 ` Leonard Crestez
@ 2019-04-24 9:15 ` Yue Haibing
2019-04-24 10:00 ` Leonard Crestez
2019-05-12 1:21 ` Shawn Guo
1 sibling, 2 replies; 6+ messages in thread
From: Yue Haibing @ 2019-04-24 9:15 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, linux-imx, l.stach,
aisheng.dong, leonard.crestez, abel.vesa, Anson.Huang,
catalin.marinas, will.deacon
Cc: linux-kernel, linux-arm-kernel, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
During randconfig builds, I occasionally run into an invalid configuration
drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
while CONFIG_SOC_BUS is not set, the building failed like this. This patch
selects SOC_BUS to fix it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: a7e26f356ca1 ("soc: imx: Add generic i.MX8 SoC driver")
Suggested-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: select SOC_BUS from CONFIG_ARCH_MXC directly
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index b5ca9c5..ae7f008 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -157,6 +157,7 @@ config ARCH_MXC
select IMX_GPCV2_PM_DOMAINS
select PM
select PM_GENERIC_DOMAINS
+ select SOC_BUS
help
This enables support for the ARMv8 based SoCs in the
NXP i.MX family.
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] soc: imx: Fix build error without CONFIG_SOC_BUS
2019-04-24 9:15 ` [PATCH v2] " Yue Haibing
@ 2019-04-24 10:00 ` Leonard Crestez
2019-05-12 1:21 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Leonard Crestez @ 2019-04-24 10:00 UTC (permalink / raw)
To: Yue Haibing, shawnguo, s.hauer, kernel, festevam, dl-linux-imx,
l.stach, Aisheng Dong, Abel Vesa, Anson Huang, catalin.marinas,
will.deacon
Cc: linux-kernel, linux-arm-kernel
On 24.04.2019 12:16, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> During randconfig builds, I occasionally run into an invalid configuration
>
> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
>
> while CONFIG_SOC_BUS is not set, the building failed like this. This patch
> selects SOC_BUS to fix it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: a7e26f356ca1 ("soc: imx: Add generic i.MX8 SoC driver")
> Suggested-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] soc: imx: Fix build error without CONFIG_SOC_BUS
2019-04-24 9:15 ` [PATCH v2] " Yue Haibing
2019-04-24 10:00 ` Leonard Crestez
@ 2019-05-12 1:21 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-05-12 1:21 UTC (permalink / raw)
To: Yue Haibing
Cc: s.hauer, kernel, festevam, linux-imx, l.stach, aisheng.dong,
leonard.crestez, abel.vesa, Anson.Huang, catalin.marinas,
will.deacon, linux-kernel, linux-arm-kernel
On Wed, Apr 24, 2019 at 05:15:17PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> During randconfig builds, I occasionally run into an invalid configuration
>
> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
>
> while CONFIG_SOC_BUS is not set, the building failed like this. This patch
> selects SOC_BUS to fix it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: a7e26f356ca1 ("soc: imx: Add generic i.MX8 SoC driver")
> Suggested-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: select SOC_BUS from CONFIG_ARCH_MXC directly
> ---
So this becomes a 'arm64: imx: ' change. I updated the subject prefix
and applied the patch.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-12 1:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 7:59 [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS Yue Haibing
2019-04-24 8:11 ` Leonard Crestez
2019-04-24 8:47 ` YueHaibing
2019-04-24 9:15 ` [PATCH v2] " Yue Haibing
2019-04-24 10:00 ` Leonard Crestez
2019-05-12 1:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).