* [PATCH 0/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
@ 2019-04-24 13:24 Mike Rapoport
2019-04-24 13:24 ` [PATCH 1/2] x86/Kconfig: make SPARSEMEM default " Mike Rapoport
2019-04-24 13:24 ` [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
0 siblings, 2 replies; 7+ messages in thread
From: Mike Rapoport @ 2019-04-24 13:24 UTC (permalink / raw)
To: x86
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Christoph Hellwig, Matthew Wilcox, Mel Gorman, linux-mm,
linux-kernel, Mike Rapoport
Hi,
During the recent discussion [1] about DISCONTIGMEM being effectively
deprecated, Christoph suggested to mark it as BROKEN for x86-32.
These patches follow that suggestion and make SPARSEMEM the default for
X86_32 && NUMA and mark DISCONTIGMEM as BROKEN.
[1] https://lore.kernel.org/lkml/20190423071354.GB12114@infradead.org/
Mike Rapoport (2):
x86/Kconfig: make SPARSEMEM default for 32-bit
x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
arch/x86/Kconfig | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] x86/Kconfig: make SPARSEMEM default for 32-bit
2019-04-24 13:24 [PATCH 0/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
@ 2019-04-24 13:24 ` Mike Rapoport
2019-04-24 14:19 ` Mel Gorman
2019-04-25 7:32 ` [tip:x86/mm] x86/Kconfig: Make SPARSEMEM default for 32-bit x86 tip-bot for Mike Rapoport
2019-04-24 13:24 ` [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
1 sibling, 2 replies; 7+ messages in thread
From: Mike Rapoport @ 2019-04-24 13:24 UTC (permalink / raw)
To: x86
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Christoph Hellwig, Matthew Wilcox, Mel Gorman, linux-mm,
linux-kernel, Mike Rapoport
Sparsemem has been a default memory model for x86-64 for over a decade
since the commit b263295dbffd ("x86: 64-bit, make sparsemem vmemmap the
only memory model").
Make it the default for 32-bit NUMA systems (if there any left) as well.
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/x86/Kconfig | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 62fc3fd..5662a3e 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1609,10 +1609,6 @@ config ARCH_DISCONTIGMEM_ENABLE
def_bool y
depends on NUMA && X86_32
-config ARCH_DISCONTIGMEM_DEFAULT
- def_bool y
- depends on NUMA && X86_32
-
config ARCH_SPARSEMEM_ENABLE
def_bool y
depends on X86_64 || NUMA || X86_32 || X86_32_NON_STANDARD
@@ -1620,8 +1616,7 @@ config ARCH_SPARSEMEM_ENABLE
select SPARSEMEM_VMEMMAP_ENABLE if X86_64
config ARCH_SPARSEMEM_DEFAULT
- def_bool y
- depends on X86_64
+ def_bool X86_64 || (NUMA && X86_32)
config ARCH_SELECT_MEMORY_MODEL
def_bool y
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
2019-04-24 13:24 [PATCH 0/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
2019-04-24 13:24 ` [PATCH 1/2] x86/Kconfig: make SPARSEMEM default " Mike Rapoport
@ 2019-04-24 13:24 ` Mike Rapoport
2019-04-24 14:20 ` Mel Gorman
2019-04-25 7:33 ` [tip:x86/mm] x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86 tip-bot for Mike Rapoport
1 sibling, 2 replies; 7+ messages in thread
From: Mike Rapoport @ 2019-04-24 13:24 UTC (permalink / raw)
To: x86
Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Christoph Hellwig, Matthew Wilcox, Mel Gorman, linux-mm,
linux-kernel, Mike Rapoport
Mel Gorman says:
32-bit NUMA systems should be non-existent in practice. The last NUMA
system I'm aware of that was both NUMA and 32-bit only died somewhere
between 2004 and 2007. If someone is running a 64-bit capable system in
32-bit mode with NUMA, they really are just punishing themselves for fun.
Mark DISCONTIGMEM broken for now and remove it in a couple of releases.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Suggested-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/x86/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5662a3e..bd6f93c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1606,8 +1606,9 @@ config ARCH_FLATMEM_ENABLE
depends on X86_32 && !NUMA
config ARCH_DISCONTIGMEM_ENABLE
- def_bool y
+ def_bool n
depends on NUMA && X86_32
+ depends on BROKEN
config ARCH_SPARSEMEM_ENABLE
def_bool y
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] x86/Kconfig: make SPARSEMEM default for 32-bit
2019-04-24 13:24 ` [PATCH 1/2] x86/Kconfig: make SPARSEMEM default " Mike Rapoport
@ 2019-04-24 14:19 ` Mel Gorman
2019-04-25 7:32 ` [tip:x86/mm] x86/Kconfig: Make SPARSEMEM default for 32-bit x86 tip-bot for Mike Rapoport
1 sibling, 0 replies; 7+ messages in thread
From: Mel Gorman @ 2019-04-24 14:19 UTC (permalink / raw)
To: Mike Rapoport
Cc: x86, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
H. Peter Anvin, Christoph Hellwig, Matthew Wilcox, linux-mm,
linux-kernel
On Wed, Apr 24, 2019 at 04:24:11PM +0300, Mike Rapoport wrote:
> Sparsemem has been a default memory model for x86-64 for over a decade
> since the commit b263295dbffd ("x86: 64-bit, make sparsemem vmemmap the
> only memory model").
>
> Make it the default for 32-bit NUMA systems (if there any left) as well.
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
2019-04-24 13:24 ` [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
@ 2019-04-24 14:20 ` Mel Gorman
2019-04-25 7:33 ` [tip:x86/mm] x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86 tip-bot for Mike Rapoport
1 sibling, 0 replies; 7+ messages in thread
From: Mel Gorman @ 2019-04-24 14:20 UTC (permalink / raw)
To: Mike Rapoport
Cc: x86, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
H. Peter Anvin, Christoph Hellwig, Matthew Wilcox, linux-mm,
linux-kernel
On Wed, Apr 24, 2019 at 04:24:12PM +0300, Mike Rapoport wrote:
> Mel Gorman says:
> 32-bit NUMA systems should be non-existent in practice. The last NUMA
> system I'm aware of that was both NUMA and 32-bit only died somewhere
> between 2004 and 2007. If someone is running a 64-bit capable system in
> 32-bit mode with NUMA, they really are just punishing themselves for fun.
>
> Mark DISCONTIGMEM broken for now and remove it in a couple of releases.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Suggested-by: Mel Gorman <mgorman@techsingularity.net>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
It was really Christoph that suggested marking it broken but I do agree
that it should be marked broken to see if anyone complains and if not,
there is no real reason to keep discontig available on x86.
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:x86/mm] x86/Kconfig: Make SPARSEMEM default for 32-bit x86
2019-04-24 13:24 ` [PATCH 1/2] x86/Kconfig: make SPARSEMEM default " Mike Rapoport
2019-04-24 14:19 ` Mel Gorman
@ 2019-04-25 7:32 ` tip-bot for Mike Rapoport
1 sibling, 0 replies; 7+ messages in thread
From: tip-bot for Mike Rapoport @ 2019-04-25 7:32 UTC (permalink / raw)
To: linux-tip-commits
Cc: luto, hch, mgorman, linux-kernel, mingo, bp, peterz, rppt,
dave.hansen, willy, tglx, riel, torvalds, hpa
Commit-ID: 6ad57f7f2cbf65daced27f023cc99360742a24b9
Gitweb: https://git.kernel.org/tip/6ad57f7f2cbf65daced27f023cc99360742a24b9
Author: Mike Rapoport <rppt@linux.ibm.com>
AuthorDate: Wed, 24 Apr 2019 16:24:11 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 25 Apr 2019 09:02:17 +0200
x86/Kconfig: Make SPARSEMEM default for 32-bit x86
Sparsemem has been a default memory model for x86-64 for over a decade,
since:
b263295dbffd ("x86: 64-bit, make sparsemem vmemmap the only memory model").
Make it the default for 32-bit NUMA systems (if there any left) as well.
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/1556112252-9339-2-git-send-email-rppt@linux.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/Kconfig | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5ad92419be19..0b91756ed980 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1609,10 +1609,6 @@ config ARCH_DISCONTIGMEM_ENABLE
def_bool y
depends on NUMA && X86_32
-config ARCH_DISCONTIGMEM_DEFAULT
- def_bool y
- depends on NUMA && X86_32
-
config ARCH_SPARSEMEM_ENABLE
def_bool y
depends on X86_64 || NUMA || X86_32 || X86_32_NON_STANDARD
@@ -1620,8 +1616,7 @@ config ARCH_SPARSEMEM_ENABLE
select SPARSEMEM_VMEMMAP_ENABLE if X86_64
config ARCH_SPARSEMEM_DEFAULT
- def_bool y
- depends on X86_64
+ def_bool X86_64 || (NUMA && X86_32)
config ARCH_SELECT_MEMORY_MODEL
def_bool y
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip:x86/mm] x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86
2019-04-24 13:24 ` [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
2019-04-24 14:20 ` Mel Gorman
@ 2019-04-25 7:33 ` tip-bot for Mike Rapoport
1 sibling, 0 replies; 7+ messages in thread
From: tip-bot for Mike Rapoport @ 2019-04-25 7:33 UTC (permalink / raw)
To: linux-tip-commits
Cc: dave.hansen, willy, tglx, hch, bp, hpa, mingo, linux-kernel,
rppt, mgorman, luto, riel, torvalds, peterz
Commit-ID: 2792107dc3af29ecc1a9b3dc5bc873dac4b61cd6
Gitweb: https://git.kernel.org/tip/2792107dc3af29ecc1a9b3dc5bc873dac4b61cd6
Author: Mike Rapoport <rppt@linux.ibm.com>
AuthorDate: Wed, 24 Apr 2019 16:24:12 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 25 Apr 2019 09:02:18 +0200
x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86
Mel Gorman says:
"32-bit NUMA systems should be non-existent in practice. The last NUMA
system I'm aware of that was both NUMA and 32-bit only died somewhere
between 2004 and 2007. If someone is running a 64-bit capable system in
32-bit mode with NUMA, they really are just punishing themselves for fun."
Mark DISCONTIGMEM broken for now as suggested by Christoph Hellwig,
and (hopefully) remove it in a couple of releases.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/1556112252-9339-3-git-send-email-rppt@linux.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 0b91756ed980..335d6e37f151 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1606,8 +1606,9 @@ config ARCH_FLATMEM_ENABLE
depends on X86_32 && !NUMA
config ARCH_DISCONTIGMEM_ENABLE
- def_bool y
+ def_bool n
depends on NUMA && X86_32
+ depends on BROKEN
config ARCH_SPARSEMEM_ENABLE
def_bool y
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-25 7:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 13:24 [PATCH 0/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
2019-04-24 13:24 ` [PATCH 1/2] x86/Kconfig: make SPARSEMEM default " Mike Rapoport
2019-04-24 14:19 ` Mel Gorman
2019-04-25 7:32 ` [tip:x86/mm] x86/Kconfig: Make SPARSEMEM default for 32-bit x86 tip-bot for Mike Rapoport
2019-04-24 13:24 ` [PATCH 2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit Mike Rapoport
2019-04-24 14:20 ` Mel Gorman
2019-04-25 7:33 ` [tip:x86/mm] x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86 tip-bot for Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).