From: Paul Burton <paul.burton@mips.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"akiyks@gmail.com" <akiyks@gmail.com>,
"andrea.parri@amarulasolutions.com"
<andrea.parri@amarulasolutions.com>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
"dlustig@nvidia.com" <dlustig@nvidia.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"j.alglave@ucl.ac.uk" <j.alglave@ucl.ac.uk>,
"luc.maranget@inria.fr" <luc.maranget@inria.fr>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"paulmck@linux.ibm.com" <paulmck@linux.ibm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: [RFC][PATCH 4/5] mips/atomic: Fix smp_mb__{before,after}_atomic()
Date: Wed, 24 Apr 2019 21:24:31 +0000 [thread overview]
Message-ID: <20190424212422.bykvyho3jqw6jz6w@pburton-laptop> (raw)
In-Reply-To: <20190424124421.751367532@infradead.org>
Hi Peter,
On Wed, Apr 24, 2019 at 02:37:00PM +0200, Peter Zijlstra wrote:
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -230,9 +238,6 @@
> #define nudge_writes() mb()
> #endif
>
> -#define __smp_mb__before_atomic() __smp_mb__before_llsc()
> -#define __smp_mb__after_atomic() smp_llsc_mb()
> -
> /*
> * Some Loongson 3 CPUs have a bug wherein execution of a memory access (load,
> * store or pref) in between an ll & sc can cause the sc instruction to
I think this bit should be part of patch 3, where you currently add a
second definition of these 2 macros.
Otherwise this one looks reasonable to me.
Thanks,
Paul
next prev parent reply other threads:[~2019-04-24 21:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 12:36 [RFC][PATCH 0/5] atomic: Fixes to smp_mb__{before,after}_atomic() and mips Peter Zijlstra
2019-04-24 12:36 ` [RFC][PATCH 1/5] mips/atomic: Fix cmpxchg64 barriers Peter Zijlstra
2019-04-24 21:00 ` Paul Burton
2019-04-25 6:59 ` Peter Zijlstra
2019-04-24 12:36 ` [RFC][PATCH 2/5] mips/atomic: Fix loongson_llsc_mb() wreckage Peter Zijlstra
2019-04-24 12:59 ` Peter Zijlstra
2019-04-24 21:18 ` Paul Burton
2019-04-25 4:58 ` huangpei
2019-04-25 7:33 ` Peter Zijlstra
2019-04-25 9:09 ` Peter Zijlstra
2019-04-25 12:14 ` huangpei
2019-04-25 9:12 ` Peter Zijlstra
2019-05-14 15:58 ` Peter Zijlstra
2019-05-14 16:10 ` Linus Torvalds
2019-05-14 16:56 ` Peter Zijlstra
2019-05-14 17:07 ` Linus Torvalds
2019-05-15 13:50 ` huangpei
2019-04-25 11:32 ` huangpei
2019-04-25 12:26 ` Peter Zijlstra
2019-04-25 12:51 ` huangpei
2019-04-25 13:31 ` Peter Zijlstra
2019-04-26 2:57 ` huangpei
2019-05-14 15:46 ` Peter Zijlstra
2019-04-25 16:12 ` Linus Torvalds
2019-04-25 7:15 ` Peter Zijlstra
2019-04-24 12:36 ` [RFC][PATCH 3/5] mips/atomic: Optimize loongson3_llsc_mb() Peter Zijlstra
2019-04-24 12:37 ` [RFC][PATCH 4/5] mips/atomic: Fix smp_mb__{before,after}_atomic() Peter Zijlstra
2019-04-24 21:24 ` Paul Burton [this message]
2019-04-25 7:34 ` Peter Zijlstra
2019-04-24 12:37 ` [RFC][PATCH 5/5] x86/atomic: " Peter Zijlstra
2019-04-24 13:41 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424212422.bykvyho3jqw6jz6w@pburton-laptop \
--to=paul.burton@mips.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).