* [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
@ 2019-04-04 4:01 Douglas Anderson
2019-04-04 5:20 ` Kalle Valo
2019-04-25 11:05 ` Kalle Valo
0 siblings, 2 replies; 7+ messages in thread
From: Douglas Anderson @ 2019-04-04 4:01 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-rockchip, briannorris, mka, ryandcase, heiko,
Douglas Anderson, David S. Miller, Ganapathi Bhat,
linux-wireless, Amitkumar Karwar, linux-kernel,
Nishant Sarmukadam, netdev, Xinming Hu
The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
adapter status variables") had a fairly straightforward bug in it. It
contained this bit of diff:
- if (!adapter->is_suspended) {
+ if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
As you can see the patch missed the "!" when converting to the atomic
bitops. This meant that the resume hasn't done anything at all since
that commit landed and suspend/resume for mwifiex SDIO cards has been
totally broken.
After fixing this mwifiex suspend/resume appears to work again, at
least with the simple testing I've done.
Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index a85648342d15..d5a70340a945 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -181,7 +181,7 @@ static int mwifiex_sdio_resume(struct device *dev)
adapter = card->adapter;
- if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
+ if (!test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
mwifiex_dbg(adapter, WARN,
"device already resumed\n");
return 0;
--
2.21.0.392.gf8f6787159e-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
2019-04-04 4:01 [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards Douglas Anderson
@ 2019-04-04 5:20 ` Kalle Valo
2019-04-04 20:47 ` Brian Norris
2019-04-25 11:05 ` Kalle Valo
1 sibling, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2019-04-04 5:20 UTC (permalink / raw)
To: Douglas Anderson
Cc: linux-rockchip, briannorris, mka, ryandcase, heiko,
David S. Miller, Ganapathi Bhat, linux-wireless,
Amitkumar Karwar, linux-kernel, Nishant Sarmukadam, netdev,
Xinming Hu
Douglas Anderson <dianders@chromium.org> writes:
> The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
> adapter status variables") had a fairly straightforward bug in it. It
> contained this bit of diff:
>
> - if (!adapter->is_suspended) {
> + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
>
> As you can see the patch missed the "!" when converting to the atomic
> bitops. This meant that the resume hasn't done anything at all since
> that commit landed and suspend/resume for mwifiex SDIO cards has been
> totally broken.
>
> After fixing this mwifiex suspend/resume appears to work again, at
> least with the simple testing I've done.
>
> Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
I'm planning to queue this for 5.1.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
2019-04-04 5:20 ` Kalle Valo
@ 2019-04-04 20:47 ` Brian Norris
2019-04-05 3:35 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Brian Norris @ 2019-04-04 20:47 UTC (permalink / raw)
To: Kalle Valo
Cc: Douglas Anderson, open list:ARM/Rockchip SoC...,
Matthias Kaehlcke, Ryan Case, Heiko Stuebner, David S. Miller,
Ganapathi Bhat, linux-wireless, Amitkumar Karwar, Linux Kernel,
Nishant Sarmukadam, <netdev@vger.kernel.org>,
Xinming Hu
On Wed, Apr 3, 2019 at 10:20 PM Kalle Valo <kvalo@codeaurora.org> wrote:
> Douglas Anderson <dianders@chromium.org> writes:
> > Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> I'm planning to queue this for 5.1.
With an explicit
Cc: <stable@vger.kernel.org>
please? Somebody would likely pick it up anyway, but it's nice to be explicit.
Not that it really matters, but also:
Reviewed-by: Brian Norris <briannorris@chromium.org>
Thanks,
Brian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
2019-04-04 20:47 ` Brian Norris
@ 2019-04-05 3:35 ` Kalle Valo
2019-04-18 16:31 ` Doug Anderson
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2019-04-05 3:35 UTC (permalink / raw)
To: Brian Norris
Cc: Douglas Anderson, open list:ARM/Rockchip SoC...,
Matthias Kaehlcke, Ryan Case, Heiko Stuebner, David S. Miller,
Ganapathi Bhat, linux-wireless, Amitkumar Karwar, Linux Kernel,
Nishant Sarmukadam, <netdev@vger.kernel.org>,
Xinming Hu
Brian Norris <briannorris@chromium.org> writes:
> On Wed, Apr 3, 2019 at 10:20 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>> Douglas Anderson <dianders@chromium.org> writes:
>> > Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
>> > adapter status variables")
>> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>
>> I'm planning to queue this for 5.1.
>
> With an explicit
>
> Cc: <stable@vger.kernel.org>
>
> please? Somebody would likely pick it up anyway, but it's nice to be
> explicit.
Ok, I'll add that.
> Not that it really matters, but also:
>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
This patchwork picks up automatically so I don't have to do anything.
But I so wish it would do the same for Cc and Fixes tags :)
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
2019-04-05 3:35 ` Kalle Valo
@ 2019-04-18 16:31 ` Doug Anderson
2019-04-19 4:03 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Doug Anderson @ 2019-04-18 16:31 UTC (permalink / raw)
To: Kalle Valo
Cc: Brian Norris, open list:ARM/Rockchip SoC...,
Matthias Kaehlcke, Ryan Case, Heiko Stuebner, David S. Miller,
Ganapathi Bhat, linux-wireless, Amitkumar Karwar, Linux Kernel,
Nishant Sarmukadam, <netdev@vger.kernel.org>,
Xinming Hu
Hi,
On Thu, Apr 4, 2019 at 8:35 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Brian Norris <briannorris@chromium.org> writes:
>
> > On Wed, Apr 3, 2019 at 10:20 PM Kalle Valo <kvalo@codeaurora.org> wrote:
> >> Douglas Anderson <dianders@chromium.org> writes:
> >> > Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
> >> > adapter status variables")
> >> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> >>
> >> I'm planning to queue this for 5.1.
Do you know when you plan to queue this? I don't see the patch in
Linus's tree nor in linux-next. Just want to make sure it didn't get
forgotten...
Thanks!
-Doug
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
2019-04-18 16:31 ` Doug Anderson
@ 2019-04-19 4:03 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2019-04-19 4:03 UTC (permalink / raw)
To: Doug Anderson
Cc: Brian Norris, open list:ARM/Rockchip SoC...,
Matthias Kaehlcke, Ryan Case, Heiko Stuebner, David S. Miller,
Ganapathi Bhat, linux-wireless, Amitkumar Karwar, Linux Kernel,
Nishant Sarmukadam, <netdev@vger.kernel.org>,
Xinming Hu
Doug Anderson <dianders@chromium.org> writes:
> On Thu, Apr 4, 2019 at 8:35 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Brian Norris <briannorris@chromium.org> writes:
>>
>> > On Wed, Apr 3, 2019 at 10:20 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>> >> Douglas Anderson <dianders@chromium.org> writes:
>> >> > Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
>> >> > adapter status variables")
>> >> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>> >>
>> >> I'm planning to queue this for 5.1.
>
> Do you know when you plan to queue this? I don't see the patch in
> Linus's tree nor in linux-next. Just want to make sure it didn't get
> forgotten...
It's on my queue and not forgotten:
https://patchwork.kernel.org/patch/10884883/
Due to various reasons I'm really struggling with patches right now,
sorry about that, but I'm slowly catching up. I should be able to apply
this within a week.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards
2019-04-04 4:01 [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards Douglas Anderson
2019-04-04 5:20 ` Kalle Valo
@ 2019-04-25 11:05 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2019-04-25 11:05 UTC (permalink / raw)
To: Douglas Anderson
Cc: linux-rockchip, briannorris, mka, ryandcase, heiko,
Douglas Anderson, David S. Miller, Ganapathi Bhat,
linux-wireless, Amitkumar Karwar, linux-kernel,
Nishant Sarmukadam, netdev, Xinming Hu
Douglas Anderson <dianders@chromium.org> wrote:
> The commit fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent
> adapter status variables") had a fairly straightforward bug in it. It
> contained this bit of diff:
>
> - if (!adapter->is_suspended) {
> + if (test_bit(MWIFIEX_IS_SUSPENDED, &adapter->work_flags)) {
>
> As you can see the patch missed the "!" when converting to the atomic
> bitops. This meant that the resume hasn't done anything at all since
> that commit landed and suspend/resume for mwifiex SDIO cards has been
> totally broken.
>
> After fixing this mwifiex suspend/resume appears to work again, at
> least with the simple testing I've done.
>
> Fixes: fc3a2fcaa1ba ("mwifiex: use atomic bitops to represent adapter status variables")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers.git, thanks.
b82d6c1f8f82 mwifiex: Make resume actually do something useful again on SDIO cards
--
https://patchwork.kernel.org/patch/10884883/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-25 11:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 4:01 [PATCH] mwifiex: Make resume actually do something useful again on SDIO cards Douglas Anderson
2019-04-04 5:20 ` Kalle Valo
2019-04-04 20:47 ` Brian Norris
2019-04-05 3:35 ` Kalle Valo
2019-04-18 16:31 ` Doug Anderson
2019-04-19 4:03 ` Kalle Valo
2019-04-25 11:05 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).