From: Chengguang Xu <cgxu519@gmx.com>
To: jack@suse.com
Cc: linux-kernel@vger.kernel.org, Chengguang Xu <cgxu519@gmx.com>
Subject: [PATCH] quota: set init_needed flag only when successfully getting dquot
Date: Sun, 28 Apr 2019 13:39:21 +0800 [thread overview]
Message-ID: <20190428053921.5984-1-cgxu519@gmx.com> (raw)
Set init_needed flag only when successfully getting dquot,
so that we can skip unnecessary subsequent operation.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/quota/dquot.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index fc20e06c56ba..8d4ce2a2b5c8 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -1449,8 +1449,6 @@ static int __dquot_initialize(struct inode *inode, int type)
if (!sb_has_quota_active(sb, cnt))
continue;
- init_needed = 1;
-
switch (cnt) {
case USRQUOTA:
qid = make_kqid_uid(inode->i_uid);
@@ -1475,6 +1473,9 @@ static int __dquot_initialize(struct inode *inode, int type)
dquot = NULL;
}
got[cnt] = dquot;
+
+ if (got[cnt])
+ init_needed = 1;
}
/* All required i_dquot has been initialized */
--
2.20.1
next reply other threads:[~2019-04-28 5:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 5:39 Chengguang Xu [this message]
2019-04-29 21:49 ` [PATCH] quota: set init_needed flag only when successfully getting dquot Jan Kara
2019-04-30 2:27 ` cgxu519
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428053921.5984-1-cgxu519@gmx.com \
--to=cgxu519@gmx.com \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).