From: cgxu519 <cgxu519@gmx.com>
To: Jan Kara <jack@suse.cz>
Cc: jack@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] quota: set init_needed flag only when successfully getting dquot
Date: Tue, 30 Apr 2019 10:27:15 +0800 [thread overview]
Message-ID: <5d005f7a-0e5b-57a5-44d4-83b12fdfa9e9@gmx.com> (raw)
In-Reply-To: <20190429214956.GA6740@quack2.suse.cz>
On 4/30/19 5:49 AM, Jan Kara wrote:
> On Sun 28-04-19 13:39:21, Chengguang Xu wrote:
>> Set init_needed flag only when successfully getting dquot,
>> so that we can skip unnecessary subsequent operation.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> Thanks for the patch but I don't think it's really useful. It will be very
> rare that we race with quotaoff of dqget() fails due to error. So the
> additional overhead of iterating over dquots doesn't really matter in that
> case.
Hi Jan,
Thanks for the comment, I got it.
Chengguang.
prev parent reply other threads:[~2019-04-30 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 5:39 [PATCH] quota: set init_needed flag only when successfully getting dquot Chengguang Xu
2019-04-29 21:49 ` Jan Kara
2019-04-30 2:27 ` cgxu519 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d005f7a-0e5b-57a5-44d4-83b12fdfa9e9@gmx.com \
--to=cgxu519@gmx.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).