From: Rob Herring <robh@kernel.org>
To: Chuanhua Han <chuanhua.han@nxp.com>
Cc: mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, leoyang.li@nxp.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
kernel@pengutronix.de, linux-imx@nxp.com, festevam@gmail.com,
wsa+renesas@sang-engineering.com, u.kleine-koenig@pengutronix.de,
eha@deif.com, linux@rempel-privat.de, sumit.batra@nxp.com,
l.stach@pengutronix.de, peda@axentia.se
Subject: Re: [PATCH 1/3] dt-bindings: i2c: add optional mul-value property to binding
Date: Thu, 2 May 2019 15:59:01 -0500 [thread overview]
Message-ID: <20190502205901.GA24224@bogus> (raw)
In-Reply-To: <20190430043242.29687-1-chuanhua.han@nxp.com>
On Tue, Apr 30, 2019 at 12:32:40PM +0800, Chuanhua Han wrote:
> NXP Layerscape SoC have up to three MUL options available for all
> divider values, we choice of MUL determines the internal monitor rate
> of the I2C bus (SCL and SDA signals):
> A lower MUL value results in a higher sampling rate of the I2C signals.
> A higher MUL value results in a lower sampling rate of the I2C signals.
>
> So in Optional properties we added our custom mul-value property in the
> binding to select which mul option for the device tree i2c controller
> node.
>
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.txt b/Documentation/devicetree/bindings/i2c/i2c-imx.txt
> index b967544590e8..ba8e7b7b3fa8 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.txt
> @@ -18,6 +18,9 @@ Optional properties:
> - sda-gpios: specify the gpio related to SDA pin
> - pinctrl: add extra pinctrl to configure i2c pins to gpio function for i2c
> bus recovery, call it "gpio" state
> +- mul-value: NXP Layerscape SoC have up to three MUL options available for
> +all I2C divider values, it describes which MUL we choose to use for the driver,
> +the values should be 1,2,4.
Needs a vendor prefix. I don't find 'value' to add anything nor do I
understand what MUL is.
If it is determined by SoC rather than board, then it should perhaps be
implied by compatible.
Rob
next prev parent reply other threads:[~2019-05-02 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 4:32 [PATCH 1/3] dt-bindings: i2c: add optional mul-value property to binding Chuanhua Han
2019-04-30 4:32 ` [PATCH 2/3] i2c: imx: I2C Driver IBC and SCL Divider for MUL=2 and MUL=4 Chuanhua Han
2019-04-30 4:32 ` [PATCH 3/3] arm64: dts: fsl: ls1046a: Add mul-value property of the i2c controller nodes Chuanhua Han
2019-04-30 6:38 ` [PATCH 1/3] dt-bindings: i2c: add optional mul-value property to binding Uwe Kleine-König
2019-04-30 6:56 ` [EXT] " Chuanhua Han
2019-05-02 20:59 ` Rob Herring [this message]
2019-05-07 8:40 ` Wolfram Sang
2019-05-08 11:44 ` [EXT] " Chuanhua Han
2019-05-08 18:53 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502205901.GA24224@bogus \
--to=robh@kernel.org \
--cc=chuanhua.han@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=eha@deif.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sumit.batra@nxp.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).