From: Keith Busch <kbusch@kernel.org>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: "Heitke, Kenneth" <kenneth.heitke@intel.com>,
linux-nvme@lists.infradead.org, Fam Zheng <fam@euphon.net>,
Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
kvm@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liang Cunming <cunming.liang@intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org,
Kirti Wankhede <kwankhede@nvidia.com>, Jens Axboe <axboe@fb.com>,
Alex Williamson <alex.williamson@redhat.com>,
John Ferlan <jferlan@redhat.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Liu Changpeng <changpeng.liu@intel.com>,
"Paul E . McKenney" <paulmck@linux.ibm.com>,
Amnon Ilan <ailan@redhat.com>, Christoph Hellwig <hch@lst.de>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface
Date: Fri, 3 May 2019 06:09:15 -0600 [thread overview]
Message-ID: <20190503120915.GA30013@localhost.localdomain> (raw)
In-Reply-To: <f1f471e0b734413e6c0f7a8bb1a03041b1d12d6d.camel@redhat.com>
On Fri, May 03, 2019 at 12:20:17AM +0300, Maxim Levitsky wrote:
> On Thu, 2019-05-02 at 15:12 -0600, Heitke, Kenneth wrote:
> > On 5/2/2019 5:47 AM, Maxim Levitsky wrote:
> > > +static void nvme_ext_queue_free(struct nvme_ctrl *ctrl, u16 qid)
> > > +{
> > > + struct nvme_dev *dev = to_nvme_dev(ctrl);
> > > + struct nvme_queue *nvmeq;
> > > +
> > > + mutex_lock(&dev->ext_dev_lock);
> > > + nvmeq = &dev->queues[qid];
> > > +
> > > + if (WARN_ON(!test_bit(NVMEQ_EXTERNAL, &nvmeq->flags)))
> > > + return;
> >
> > This condition is probably not expected to happen (since its a warning)
> > but do you need to unlock the ext_dev_lock before returning?
>
> This is true, I will fix this. This used to be BUG_ON, but due to checkpatch.pl
> complains I turned them all to WARN_ON, and missed this.
Gentle reminder to trim your replies to the relevant context. It's
much easier to read when we don't need to scroll through hundreds of
unnecessary lines.
next prev parent reply other threads:[~2019-05-03 12:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 11:47 [PATCH v2 00/10] RFC: NVME MDEV Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 01/10] vfio/mdev: add notifier for map events Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 02/10] vfio/mdev: add .request callback Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 03/10] nvme/core: add some more values from the spec Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 04/10] nvme/core: add NVME_CTRL_SUSPENDED controller state Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 05/10] nvme/pci: use the NVME_CTRL_SUSPENDED state Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 06/10] nvme/core: add mdev interfaces Maxim Levitsky
2019-05-03 12:29 ` Christoph Hellwig
2019-05-03 19:00 ` Max Gurtovoy
2019-05-04 6:49 ` Christoph Hellwig
2019-05-06 8:31 ` Maxim Levitsky
2019-05-06 8:34 ` Maxim Levitsky
2019-05-06 12:59 ` Christoph Hellwig
2019-05-02 11:47 ` [PATCH v2 07/10] nvme/core: add nvme-mdev core driver Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface Maxim Levitsky
2019-05-02 14:20 ` Maxim Levitsky
2019-05-02 21:12 ` Heitke, Kenneth
2019-05-02 21:20 ` Maxim Levitsky
2019-05-03 12:09 ` Keith Busch [this message]
2019-05-06 7:55 ` Maxim Levitsky
2019-05-02 11:48 ` [PATCH v2 09/10] nvme/mdev - Add inline performance measurments Maxim Levitsky
2019-05-02 11:48 ` [PATCH v2 10/10] nvme/mdev - generic block IO code Maxim Levitsky
2019-05-03 12:18 ` [PATCH v2 00/10] RFC: NVME MDEV Christoph Hellwig
2019-05-06 9:04 ` Maxim Levitsky
2019-05-06 12:57 ` Christoph Hellwig
2019-05-06 16:43 ` Keith Busch
2019-05-08 12:39 ` Paolo Bonzini
2019-05-09 9:12 ` Stefan Hajnoczi
2019-05-09 13:49 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503120915.GA30013@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=ailan@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=axboe@fb.com \
--cc=changpeng.liu@intel.com \
--cc=cunming.liang@intel.com \
--cc=davem@davemloft.net \
--cc=fam@euphon.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jferlan@redhat.com \
--cc=keith.busch@intel.com \
--cc=kenneth.heitke@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mchehab+samsung@kernel.org \
--cc=mlevitsk@redhat.com \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=sagi@grimberg.me \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).