From: Christoph Hellwig <hch@lst.de>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Max Gurtovoy <maxg@mellanox.com>,
Fam Zheng <fam@euphon.net>,
kvm@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Keith Busch <keith.busch@intel.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"Paul E . McKenney" <paulmck@linux.ibm.com>,
Sagi Grimberg <sagi@grimberg.me>,
Christoph Hellwig <hch@infradead.org>,
Liang Cunming <cunming.liang@intel.com>,
Jens Axboe <axboe@fb.com>,
Alex Williamson <alex.williamson@redhat.com>,
John Ferlan <jferlan@redhat.com>,
Liu Changpeng <changpeng.liu@intel.com>,
Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Amnon Ilan <ailan@redhat.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 06/10] nvme/core: add mdev interfaces
Date: Mon, 6 May 2019 14:59:09 +0200 [thread overview]
Message-ID: <20190506125909.GB5288@lst.de> (raw)
In-Reply-To: <1cc7efd1852f298b01f09955f2c4bf3b20cead13.camel@redhat.com>
On Mon, May 06, 2019 at 11:31:27AM +0300, Maxim Levitsky wrote:
> Why are you saying that? I actualy prefer to use a sepearate queue per software
> nvme controller, tat because of lower overhead (about half than going through
> the block layer) and it better at QoS as the separate queue (or even few queues
> if needed) will give the guest a mostly guaranteed slice of the bandwidth of the
> device.
The downside is that your create tons of crap code in the core nvme driver
for your specific use case that no one cares about. Which is why it is
completely unacceptable. If you want things to go fast make the block
layer go fast, don't add your very special bypass.
next prev parent reply other threads:[~2019-05-06 12:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 11:47 [PATCH v2 00/10] RFC: NVME MDEV Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 01/10] vfio/mdev: add notifier for map events Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 02/10] vfio/mdev: add .request callback Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 03/10] nvme/core: add some more values from the spec Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 04/10] nvme/core: add NVME_CTRL_SUSPENDED controller state Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 05/10] nvme/pci: use the NVME_CTRL_SUSPENDED state Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 06/10] nvme/core: add mdev interfaces Maxim Levitsky
2019-05-03 12:29 ` Christoph Hellwig
2019-05-03 19:00 ` Max Gurtovoy
2019-05-04 6:49 ` Christoph Hellwig
2019-05-06 8:31 ` Maxim Levitsky
2019-05-06 8:34 ` Maxim Levitsky
2019-05-06 12:59 ` Christoph Hellwig [this message]
2019-05-02 11:47 ` [PATCH v2 07/10] nvme/core: add nvme-mdev core driver Maxim Levitsky
2019-05-02 11:47 ` [PATCH v2 08/10] nvme/pci: implement the mdev external queue allocation interface Maxim Levitsky
2019-05-02 14:20 ` Maxim Levitsky
2019-05-02 21:12 ` Heitke, Kenneth
2019-05-02 21:20 ` Maxim Levitsky
2019-05-03 12:09 ` Keith Busch
2019-05-06 7:55 ` Maxim Levitsky
2019-05-02 11:48 ` [PATCH v2 09/10] nvme/mdev - Add inline performance measurments Maxim Levitsky
2019-05-02 11:48 ` [PATCH v2 10/10] nvme/mdev - generic block IO code Maxim Levitsky
2019-05-03 12:18 ` [PATCH v2 00/10] RFC: NVME MDEV Christoph Hellwig
2019-05-06 9:04 ` Maxim Levitsky
2019-05-06 12:57 ` Christoph Hellwig
2019-05-06 16:43 ` Keith Busch
2019-05-08 12:39 ` Paolo Bonzini
2019-05-09 9:12 ` Stefan Hajnoczi
2019-05-09 13:49 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506125909.GB5288@lst.de \
--to=hch@lst.de \
--cc=ailan@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=changpeng.liu@intel.com \
--cc=cunming.liang@intel.com \
--cc=davem@davemloft.net \
--cc=fam@euphon.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jferlan@redhat.com \
--cc=keith.busch@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=mchehab+samsung@kernel.org \
--cc=mlevitsk@redhat.com \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=sagi@grimberg.me \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).