* [PATCH v3] dpaa_eth: fix SG frame cleanup
@ 2019-05-03 13:03 laurentiu.tudor
2019-05-05 17:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: laurentiu.tudor @ 2019-05-03 13:03 UTC (permalink / raw)
To: netdev, madalin.bucur, camelia.groza, leoyang.li
Cc: Joakim.Tjernlund, davem, linux-arm-kernel, linuxppc-dev,
linux-kernel, Laurentiu Tudor, stable
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Fix issue with the entry indexing in the sg frame cleanup code being
off-by-1. This problem showed up when doing some basic iperf tests and
manifested in traffic coming to a halt.
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
Cc: <stable@vger.kernel.org>
---
v3:
- added cc:stable tag (Joakim)
- pulled from the original patch series and send individually
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index daede7272768..40420edc9ce6 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const struct dpaa_priv *priv,
qm_sg_entry_get_len(&sgt[0]), dma_dir);
/* remaining pages were mapped with skb_frag_dma_map() */
- for (i = 1; i < nr_frags; i++) {
+ for (i = 1; i <= nr_frags; i++) {
WARN_ON(qm_sg_entry_is_ext(&sgt[i]));
dma_unmap_page(dev, qm_sg_addr(&sgt[i]),
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] dpaa_eth: fix SG frame cleanup
2019-05-03 13:03 [PATCH v3] dpaa_eth: fix SG frame cleanup laurentiu.tudor
@ 2019-05-05 17:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-05-05 17:31 UTC (permalink / raw)
To: laurentiu.tudor
Cc: netdev, madalin.bucur, camelia.groza, leoyang.li,
Joakim.Tjernlund, linux-arm-kernel, linuxppc-dev, linux-kernel,
stable
From: laurentiu.tudor@nxp.com
Date: Fri, 3 May 2019 16:03:11 +0300
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> Fix issue with the entry indexing in the sg frame cleanup code being
> off-by-1. This problem showed up when doing some basic iperf tests and
> manifested in traffic coming to a halt.
>
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-05 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-03 13:03 [PATCH v3] dpaa_eth: fix SG frame cleanup laurentiu.tudor
2019-05-05 17:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).