linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
@ 2019-05-03 13:19 Philippe Schenker
  0 siblings, 0 replies; 7+ messages in thread
From: Philippe Schenker @ 2019-05-03 13:19 UTC (permalink / raw)
  To: linux-tegra, Thierry Reding, Jonathan Hunter
  Cc: Philippe Schenker, devicetree, linux-kernel, Rob Herring, Mark Rutland

From: Philippe Schenker <philippe.schenker@toradex.com>

Add the stmpe-adc DT node as found on Toradex T30 modules

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

 arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++--------
 arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++--------
 arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++--------
 3 files changed, 42 insertions(+), 24 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
index 02f8126481a2..8b7a827d604d 100644
--- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
@@ -994,11 +994,17 @@
 			id = <0>;
 			blocks = <0x5>;
 			irq-trigger = <0x1>;
+			/* 3.25 MHz ADC clock speed */
+			st,adc-freq = <1>;
+			/* 12-bit ADC */
+			st,mod-12b = <1>;
+			/* internal ADC reference */
+			st,ref-sel = <0>;
+			/* ADC converstion time: 80 clocks */
+			st,sample-time = <4>;
 
 			stmpe_touchscreen {
 				compatible = "st,stmpe-ts";
-				/* 3.25 MHz ADC clock speed */
-				st,adc-freq = <1>;
 				/* 8 sample average control */
 				st,ave-ctrl = <3>;
 				/* 7 length fractional part in z */
@@ -1008,17 +1014,17 @@
 				 * current limit value
 				 */
 				st,i-drive = <1>;
-				/* 12-bit ADC */
-				st,mod-12b = <1>;
-				/* internal ADC reference */
-				st,ref-sel = <0>;
-				/* ADC converstion time: 80 clocks */
-				st,sample-time = <4>;
 				/* 1 ms panel driver settling time */
 				st,settling = <3>;
 				/* 5 ms touch detect interrupt delay */
 				st,touch-det-delay = <5>;
 			};
+
+			stmpe_adc {
+				compatible = "st,stmpe-adc";
+				/* forbid to use ADC channels 3-0 (touch) */
+				st,norequest-mask = <0x0F>;
+			};
 		};
 
 		/*
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index 7f112f192fe9..c18f6f61d764 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -976,11 +976,17 @@
 			id = <0>;
 			blocks = <0x5>;
 			irq-trigger = <0x1>;
+			/* 3.25 MHz ADC clock speed */
+			st,adc-freq = <1>;
+			/* 12-bit ADC */
+			st,mod-12b = <1>;
+			/* internal ADC reference */
+			st,ref-sel = <0>;
+			/* ADC converstion time: 80 clocks */
+			st,sample-time = <4>;
 
 			stmpe_touchscreen {
 				compatible = "st,stmpe-ts";
-				/* 3.25 MHz ADC clock speed */
-				st,adc-freq = <1>;
 				/* 8 sample average control */
 				st,ave-ctrl = <3>;
 				/* 7 length fractional part in z */
@@ -990,17 +996,17 @@
 				 * current limit value
 				 */
 				st,i-drive = <1>;
-				/* 12-bit ADC */
-				st,mod-12b = <1>;
-				/* internal ADC reference */
-				st,ref-sel = <0>;
-				/* ADC converstion time: 80 clocks */
-				st,sample-time = <4>;
 				/* 1 ms panel driver settling time */
 				st,settling = <3>;
 				/* 5 ms touch detect interrupt delay */
 				st,touch-det-delay = <5>;
 			};
+
+			stmpe_adc {
+				compatible = "st,stmpe-adc";
+				/* forbid to use ADC channels 3-0 (touch) */
+				st,norequest-mask = <0x0F>;
+			};
 		};
 
 		/*
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index 35af03ca9e90..1f9198bb24ff 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -845,11 +845,18 @@
 			id = <0>;
 			blocks = <0x5>;
 			irq-trigger = <0x1>;
+			/* 3.25 MHz ADC clock speed */
+			st,adc-freq = <1>;
+			/* 12-bit ADC */
+			st,mod-12b = <1>;
+			/* internal ADC reference */
+			st,ref-sel = <0>;
+			/* ADC converstion time: 80 clocks */
+			st,sample-time = <4>;
+			/* forbid to use ADC channels 3-0 (touch) */
 
 			stmpe_touchscreen {
 				compatible = "st,stmpe-ts";
-				/* 3.25 MHz ADC clock speed */
-				st,adc-freq = <1>;
 				/* 8 sample average control */
 				st,ave-ctrl = <3>;
 				/* 7 length fractional part in z */
@@ -859,17 +866,16 @@
 				 * current limit value
 				 */
 				st,i-drive = <1>;
-				/* 12-bit ADC */
-				st,mod-12b = <1>;
-				/* internal ADC reference */
-				st,ref-sel = <0>;
-				/* ADC converstion time: 80 clocks */
-				st,sample-time = <4>;
 				/* 1 ms panel driver settling time */
 				st,settling = <3>;
 				/* 5 ms touch detect interrupt delay */
 				st,touch-det-delay = <5>;
 			};
+
+			stmpe_adc {
+				compatible = "st,stmpe-adc";
+				st,norequest-mask = <0x0F>;
+			};
 		};
 
 		/*
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
  2019-10-01 14:35 ` Thierry Reding
@ 2019-10-02 10:23   ` Philippe Schenker
  0 siblings, 0 replies; 7+ messages in thread
From: Philippe Schenker @ 2019-10-02 10:23 UTC (permalink / raw)
  To: thierry.reding
  Cc: jonathanh, devicetree, linux-kernel, mark.rutland, linux-tegra, robh+dt

On Tue, 2019-10-01 at 16:35 +0200, Thierry Reding wrote:
> On Wed, Aug 14, 2019 at 10:53:38AM +0000, Philippe Schenker wrote:
> > Add the stmpe-adc DT node as found on Toradex T30 modules
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> > 
> > ---
> > 
> >  arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++-----
> > ---
> >  arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++-----
> > ---
> >  arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++-----
> > ---
> >  3 files changed, 42 insertions(+), 24 deletions(-)
> 
> Applied to for-5.5/arm/dt , thanks.
> 
> Thierry

Thank you very much!

Philippe

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
  2019-08-14 10:53 Philippe Schenker
  2019-08-15  7:37 ` Oleksandr Suvorov
  2019-09-30 11:54 ` Philippe Schenker
@ 2019-10-01 14:35 ` Thierry Reding
  2019-10-02 10:23   ` Philippe Schenker
  2 siblings, 1 reply; 7+ messages in thread
From: Thierry Reding @ 2019-10-01 14:35 UTC (permalink / raw)
  To: Philippe Schenker
  Cc: linux-tegra, Jonathan Hunter, devicetree, linux-kernel,
	Rob Herring, Mark Rutland

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

On Wed, Aug 14, 2019 at 10:53:38AM +0000, Philippe Schenker wrote:
> Add the stmpe-adc DT node as found on Toradex T30 modules
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> 
> ---
> 
>  arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++--------
>  arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++--------
>  arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++--------
>  3 files changed, 42 insertions(+), 24 deletions(-)

Applied to for-5.5/arm/dt , thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
  2019-09-30 11:54 ` Philippe Schenker
@ 2019-09-30 14:17   ` Thierry Reding
  0 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2019-09-30 14:17 UTC (permalink / raw)
  To: Philippe Schenker
  Cc: jonathanh, linux-tegra, devicetree, linux-kernel, mark.rutland, robh+dt

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On Mon, Sep 30, 2019 at 11:54:59AM +0000, Philippe Schenker wrote:
> On Wed, 2019-08-14 at 10:53 +0000, Philippe Schenker wrote:
> > Add the stmpe-adc DT node as found on Toradex T30 modules
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Hi Thierry, could you please pull this patch for 5.4? Or tell me what is
> holding it back from being pulled?

At this point I'm only waiting for the merge to close. Before that I
can't take any new patches.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
  2019-08-14 10:53 Philippe Schenker
  2019-08-15  7:37 ` Oleksandr Suvorov
@ 2019-09-30 11:54 ` Philippe Schenker
  2019-09-30 14:17   ` Thierry Reding
  2019-10-01 14:35 ` Thierry Reding
  2 siblings, 1 reply; 7+ messages in thread
From: Philippe Schenker @ 2019-09-30 11:54 UTC (permalink / raw)
  To: jonathanh, linux-tegra, thierry.reding
  Cc: devicetree, linux-kernel, mark.rutland, robh+dt

On Wed, 2019-08-14 at 10:53 +0000, Philippe Schenker wrote:
> Add the stmpe-adc DT node as found on Toradex T30 modules
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Hi Thierry, could you please pull this patch for 5.4? Or tell me what is
holding it back from being pulled?

Thanks for your feedback

Philippe

> 
> ---
> 
>  arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++-------
> -
>  arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++-------
> -
>  arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++-------
> -
>  3 files changed, 42 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> index 02f8126481a2..8b7a827d604d 100644
> --- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> @@ -994,11 +994,17 @@
>  			id = <0>;
>  			blocks = <0x5>;
>  			irq-trigger = <0x1>;
> +			/* 3.25 MHz ADC clock speed */
> +			st,adc-freq = <1>;
> +			/* 12-bit ADC */
> +			st,mod-12b = <1>;
> +			/* internal ADC reference */
> +			st,ref-sel = <0>;
> +			/* ADC converstion time: 80 clocks */
> +			st,sample-time = <4>;
>  
>  			stmpe_touchscreen {
>  				compatible = "st,stmpe-ts";
> -				/* 3.25 MHz ADC clock speed */
> -				st,adc-freq = <1>;
>  				/* 8 sample average control */
>  				st,ave-ctrl = <3>;
>  				/* 7 length fractional part in z */
> @@ -1008,17 +1014,17 @@
>  				 * current limit value
>  				 */
>  				st,i-drive = <1>;
> -				/* 12-bit ADC */
> -				st,mod-12b = <1>;
> -				/* internal ADC reference */
> -				st,ref-sel = <0>;
> -				/* ADC converstion time: 80 clocks */
> -				st,sample-time = <4>;
>  				/* 1 ms panel driver settling time */
>  				st,settling = <3>;
>  				/* 5 ms touch detect interrupt delay */
>  				st,touch-det-delay = <5>;
>  			};
> +
> +			stmpe_adc {
> +				compatible = "st,stmpe-adc";
> +				/* forbid to use ADC channels 3-0
> (touch) */
> +				st,norequest-mask = <0x0F>;
> +			};
>  		};
>  
>  		/*
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi
> b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index 7f112f192fe9..c18f6f61d764 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -976,11 +976,17 @@
>  			id = <0>;
>  			blocks = <0x5>;
>  			irq-trigger = <0x1>;
> +			/* 3.25 MHz ADC clock speed */
> +			st,adc-freq = <1>;
> +			/* 12-bit ADC */
> +			st,mod-12b = <1>;
> +			/* internal ADC reference */
> +			st,ref-sel = <0>;
> +			/* ADC converstion time: 80 clocks */
> +			st,sample-time = <4>;
>  
>  			stmpe_touchscreen {
>  				compatible = "st,stmpe-ts";
> -				/* 3.25 MHz ADC clock speed */
> -				st,adc-freq = <1>;
>  				/* 8 sample average control */
>  				st,ave-ctrl = <3>;
>  				/* 7 length fractional part in z */
> @@ -990,17 +996,17 @@
>  				 * current limit value
>  				 */
>  				st,i-drive = <1>;
> -				/* 12-bit ADC */
> -				st,mod-12b = <1>;
> -				/* internal ADC reference */
> -				st,ref-sel = <0>;
> -				/* ADC converstion time: 80 clocks */
> -				st,sample-time = <4>;
>  				/* 1 ms panel driver settling time */
>  				st,settling = <3>;
>  				/* 5 ms touch detect interrupt delay */
>  				st,touch-det-delay = <5>;
>  			};
> +
> +			stmpe_adc {
> +				compatible = "st,stmpe-adc";
> +				/* forbid to use ADC channels 3-0
> (touch) */
> +				st,norequest-mask = <0x0F>;
> +			};
>  		};
>  
>  		/*
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi
> b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index 35af03ca9e90..1f9198bb24ff 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -845,11 +845,18 @@
>  			id = <0>;
>  			blocks = <0x5>;
>  			irq-trigger = <0x1>;
> +			/* 3.25 MHz ADC clock speed */
> +			st,adc-freq = <1>;
> +			/* 12-bit ADC */
> +			st,mod-12b = <1>;
> +			/* internal ADC reference */
> +			st,ref-sel = <0>;
> +			/* ADC converstion time: 80 clocks */
> +			st,sample-time = <4>;
> +			/* forbid to use ADC channels 3-0 (touch) */
>  
>  			stmpe_touchscreen {
>  				compatible = "st,stmpe-ts";
> -				/* 3.25 MHz ADC clock speed */
> -				st,adc-freq = <1>;
>  				/* 8 sample average control */
>  				st,ave-ctrl = <3>;
>  				/* 7 length fractional part in z */
> @@ -859,17 +866,16 @@
>  				 * current limit value
>  				 */
>  				st,i-drive = <1>;
> -				/* 12-bit ADC */
> -				st,mod-12b = <1>;
> -				/* internal ADC reference */
> -				st,ref-sel = <0>;
> -				/* ADC converstion time: 80 clocks */
> -				st,sample-time = <4>;
>  				/* 1 ms panel driver settling time */
>  				st,settling = <3>;
>  				/* 5 ms touch detect interrupt delay */
>  				st,touch-det-delay = <5>;
>  			};
> +
> +			stmpe_adc {
> +				compatible = "st,stmpe-adc";
> +				st,norequest-mask = <0x0F>;
> +			};
>  		};
>  
>  		/*

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
  2019-08-14 10:53 Philippe Schenker
@ 2019-08-15  7:37 ` Oleksandr Suvorov
  2019-09-30 11:54 ` Philippe Schenker
  2019-10-01 14:35 ` Thierry Reding
  2 siblings, 0 replies; 7+ messages in thread
From: Oleksandr Suvorov @ 2019-08-15  7:37 UTC (permalink / raw)
  To: Philippe Schenker
  Cc: linux-tegra, Thierry Reding, Jonathan Hunter, devicetree,
	linux-kernel, Rob Herring, Mark Rutland

On Wed, Aug 14, 2019 at 1:54 PM Philippe Schenker
<philippe.schenker@toradex.com> wrote:
>
> Add the stmpe-adc DT node as found on Toradex T30 modules
>
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

>
> ---
>
>  arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++--------
>  arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++--------
>  arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++--------
>  3 files changed, 42 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> index 02f8126481a2..8b7a827d604d 100644
> --- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
> @@ -994,11 +994,17 @@
>                         id = <0>;
>                         blocks = <0x5>;
>                         irq-trigger = <0x1>;
> +                       /* 3.25 MHz ADC clock speed */
> +                       st,adc-freq = <1>;
> +                       /* 12-bit ADC */
> +                       st,mod-12b = <1>;
> +                       /* internal ADC reference */
> +                       st,ref-sel = <0>;
> +                       /* ADC converstion time: 80 clocks */
> +                       st,sample-time = <4>;
>
>                         stmpe_touchscreen {
>                                 compatible = "st,stmpe-ts";
> -                               /* 3.25 MHz ADC clock speed */
> -                               st,adc-freq = <1>;
>                                 /* 8 sample average control */
>                                 st,ave-ctrl = <3>;
>                                 /* 7 length fractional part in z */
> @@ -1008,17 +1014,17 @@
>                                  * current limit value
>                                  */
>                                 st,i-drive = <1>;
> -                               /* 12-bit ADC */
> -                               st,mod-12b = <1>;
> -                               /* internal ADC reference */
> -                               st,ref-sel = <0>;
> -                               /* ADC converstion time: 80 clocks */
> -                               st,sample-time = <4>;
>                                 /* 1 ms panel driver settling time */
>                                 st,settling = <3>;
>                                 /* 5 ms touch detect interrupt delay */
>                                 st,touch-det-delay = <5>;
>                         };
> +
> +                       stmpe_adc {
> +                               compatible = "st,stmpe-adc";
> +                               /* forbid to use ADC channels 3-0 (touch) */
> +                               st,norequest-mask = <0x0F>;
> +                       };
>                 };
>
>                 /*
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index 7f112f192fe9..c18f6f61d764 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -976,11 +976,17 @@
>                         id = <0>;
>                         blocks = <0x5>;
>                         irq-trigger = <0x1>;
> +                       /* 3.25 MHz ADC clock speed */
> +                       st,adc-freq = <1>;
> +                       /* 12-bit ADC */
> +                       st,mod-12b = <1>;
> +                       /* internal ADC reference */
> +                       st,ref-sel = <0>;
> +                       /* ADC converstion time: 80 clocks */
> +                       st,sample-time = <4>;
>
>                         stmpe_touchscreen {
>                                 compatible = "st,stmpe-ts";
> -                               /* 3.25 MHz ADC clock speed */
> -                               st,adc-freq = <1>;
>                                 /* 8 sample average control */
>                                 st,ave-ctrl = <3>;
>                                 /* 7 length fractional part in z */
> @@ -990,17 +996,17 @@
>                                  * current limit value
>                                  */
>                                 st,i-drive = <1>;
> -                               /* 12-bit ADC */
> -                               st,mod-12b = <1>;
> -                               /* internal ADC reference */
> -                               st,ref-sel = <0>;
> -                               /* ADC converstion time: 80 clocks */
> -                               st,sample-time = <4>;
>                                 /* 1 ms panel driver settling time */
>                                 st,settling = <3>;
>                                 /* 5 ms touch detect interrupt delay */
>                                 st,touch-det-delay = <5>;
>                         };
> +
> +                       stmpe_adc {
> +                               compatible = "st,stmpe-adc";
> +                               /* forbid to use ADC channels 3-0 (touch) */
> +                               st,norequest-mask = <0x0F>;
> +                       };
>                 };
>
>                 /*
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index 35af03ca9e90..1f9198bb24ff 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -845,11 +845,18 @@
>                         id = <0>;
>                         blocks = <0x5>;
>                         irq-trigger = <0x1>;
> +                       /* 3.25 MHz ADC clock speed */
> +                       st,adc-freq = <1>;
> +                       /* 12-bit ADC */
> +                       st,mod-12b = <1>;
> +                       /* internal ADC reference */
> +                       st,ref-sel = <0>;
> +                       /* ADC converstion time: 80 clocks */
> +                       st,sample-time = <4>;
> +                       /* forbid to use ADC channels 3-0 (touch) */
>
>                         stmpe_touchscreen {
>                                 compatible = "st,stmpe-ts";
> -                               /* 3.25 MHz ADC clock speed */
> -                               st,adc-freq = <1>;
>                                 /* 8 sample average control */
>                                 st,ave-ctrl = <3>;
>                                 /* 7 length fractional part in z */
> @@ -859,17 +866,16 @@
>                                  * current limit value
>                                  */
>                                 st,i-drive = <1>;
> -                               /* 12-bit ADC */
> -                               st,mod-12b = <1>;
> -                               /* internal ADC reference */
> -                               st,ref-sel = <0>;
> -                               /* ADC converstion time: 80 clocks */
> -                               st,sample-time = <4>;
>                                 /* 1 ms panel driver settling time */
>                                 st,settling = <3>;
>                                 /* 5 ms touch detect interrupt delay */
>                                 st,touch-det-delay = <5>;
>                         };
> +
> +                       stmpe_adc {
> +                               compatible = "st,stmpe-adc";
> +                               st,norequest-mask = <0x0F>;
> +                       };
>                 };
>
>                 /*
> --
> 2.22.0
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules
@ 2019-08-14 10:53 Philippe Schenker
  2019-08-15  7:37 ` Oleksandr Suvorov
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Philippe Schenker @ 2019-08-14 10:53 UTC (permalink / raw)
  To: linux-tegra, Thierry Reding, Jonathan Hunter
  Cc: Philippe Schenker, devicetree, linux-kernel, Rob Herring, Mark Rutland

Add the stmpe-adc DT node as found on Toradex T30 modules

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

 arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++++++++++++++--------
 arch/arm/boot/dts/tegra30-apalis.dtsi      | 22 ++++++++++++++--------
 arch/arm/boot/dts/tegra30-colibri.dtsi     | 22 ++++++++++++++--------
 3 files changed, 42 insertions(+), 24 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
index 02f8126481a2..8b7a827d604d 100644
--- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi
@@ -994,11 +994,17 @@
 			id = <0>;
 			blocks = <0x5>;
 			irq-trigger = <0x1>;
+			/* 3.25 MHz ADC clock speed */
+			st,adc-freq = <1>;
+			/* 12-bit ADC */
+			st,mod-12b = <1>;
+			/* internal ADC reference */
+			st,ref-sel = <0>;
+			/* ADC converstion time: 80 clocks */
+			st,sample-time = <4>;
 
 			stmpe_touchscreen {
 				compatible = "st,stmpe-ts";
-				/* 3.25 MHz ADC clock speed */
-				st,adc-freq = <1>;
 				/* 8 sample average control */
 				st,ave-ctrl = <3>;
 				/* 7 length fractional part in z */
@@ -1008,17 +1014,17 @@
 				 * current limit value
 				 */
 				st,i-drive = <1>;
-				/* 12-bit ADC */
-				st,mod-12b = <1>;
-				/* internal ADC reference */
-				st,ref-sel = <0>;
-				/* ADC converstion time: 80 clocks */
-				st,sample-time = <4>;
 				/* 1 ms panel driver settling time */
 				st,settling = <3>;
 				/* 5 ms touch detect interrupt delay */
 				st,touch-det-delay = <5>;
 			};
+
+			stmpe_adc {
+				compatible = "st,stmpe-adc";
+				/* forbid to use ADC channels 3-0 (touch) */
+				st,norequest-mask = <0x0F>;
+			};
 		};
 
 		/*
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index 7f112f192fe9..c18f6f61d764 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -976,11 +976,17 @@
 			id = <0>;
 			blocks = <0x5>;
 			irq-trigger = <0x1>;
+			/* 3.25 MHz ADC clock speed */
+			st,adc-freq = <1>;
+			/* 12-bit ADC */
+			st,mod-12b = <1>;
+			/* internal ADC reference */
+			st,ref-sel = <0>;
+			/* ADC converstion time: 80 clocks */
+			st,sample-time = <4>;
 
 			stmpe_touchscreen {
 				compatible = "st,stmpe-ts";
-				/* 3.25 MHz ADC clock speed */
-				st,adc-freq = <1>;
 				/* 8 sample average control */
 				st,ave-ctrl = <3>;
 				/* 7 length fractional part in z */
@@ -990,17 +996,17 @@
 				 * current limit value
 				 */
 				st,i-drive = <1>;
-				/* 12-bit ADC */
-				st,mod-12b = <1>;
-				/* internal ADC reference */
-				st,ref-sel = <0>;
-				/* ADC converstion time: 80 clocks */
-				st,sample-time = <4>;
 				/* 1 ms panel driver settling time */
 				st,settling = <3>;
 				/* 5 ms touch detect interrupt delay */
 				st,touch-det-delay = <5>;
 			};
+
+			stmpe_adc {
+				compatible = "st,stmpe-adc";
+				/* forbid to use ADC channels 3-0 (touch) */
+				st,norequest-mask = <0x0F>;
+			};
 		};
 
 		/*
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index 35af03ca9e90..1f9198bb24ff 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -845,11 +845,18 @@
 			id = <0>;
 			blocks = <0x5>;
 			irq-trigger = <0x1>;
+			/* 3.25 MHz ADC clock speed */
+			st,adc-freq = <1>;
+			/* 12-bit ADC */
+			st,mod-12b = <1>;
+			/* internal ADC reference */
+			st,ref-sel = <0>;
+			/* ADC converstion time: 80 clocks */
+			st,sample-time = <4>;
+			/* forbid to use ADC channels 3-0 (touch) */
 
 			stmpe_touchscreen {
 				compatible = "st,stmpe-ts";
-				/* 3.25 MHz ADC clock speed */
-				st,adc-freq = <1>;
 				/* 8 sample average control */
 				st,ave-ctrl = <3>;
 				/* 7 length fractional part in z */
@@ -859,17 +866,16 @@
 				 * current limit value
 				 */
 				st,i-drive = <1>;
-				/* 12-bit ADC */
-				st,mod-12b = <1>;
-				/* internal ADC reference */
-				st,ref-sel = <0>;
-				/* ADC converstion time: 80 clocks */
-				st,sample-time = <4>;
 				/* 1 ms panel driver settling time */
 				st,settling = <3>;
 				/* 5 ms touch detect interrupt delay */
 				st,touch-det-delay = <5>;
 			};
+
+			stmpe_adc {
+				compatible = "st,stmpe-adc";
+				st,norequest-mask = <0x0F>;
+			};
 		};
 
 		/*
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-10-02 10:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-03 13:19 [RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules Philippe Schenker
2019-08-14 10:53 Philippe Schenker
2019-08-15  7:37 ` Oleksandr Suvorov
2019-09-30 11:54 ` Philippe Schenker
2019-09-30 14:17   ` Thierry Reding
2019-10-01 14:35 ` Thierry Reding
2019-10-02 10:23   ` Philippe Schenker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).