* [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width
@ 2019-05-03 20:49 Krzysztof Kozlowski
[not found] ` <CGME20190506130052eucas1p25afd4e15648e9efc6fd011e46081fbea@eucas1p2.samsung.com>
2019-05-07 6:21 ` [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Minas Harutyunyan
0 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2019-05-03 20:49 UTC (permalink / raw)
To: Jules Maselbas
Cc: Minas Harutyunyan, Felipe Balbi, linux-usb, linux-kernel,
linux-samsung-soc, Marek Szyprowski
Hi,
Bisect pointed commit 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif
with phy_utmi_width") as reason for failures of USB on Exynos4412,
Odroid U3 board (ARMv7, exynos_defconfig, TFTP boot with nfsroot from
NFSv4):
[ 4.333996] usb 1-2: new high-speed USB device number 3 using exynos-ehci
[ 4.503942] usb 1-2: device descriptor read/64, error -71
[ 4.793970] usb 1-2: device descriptor read/64, error -71
[ 4.914748] usb usb1-port2: attempt power cycle
[ 6.224267] usb 1-3: new high-speed USB device number 5 using exynos-ehci
[ 6.393983] usb 1-3: device descriptor read/64, error -71
[ 6.684243] usb 1-3: device descriptor read/64, error -71
[ 6.954259] usb 1-3: new high-speed USB device number 6 using exynos-ehci
[ 7.123980] usb 1-3: device descriptor read/64, error -71
[ 7.413969] usb 1-3: device descriptor read/64, error -71
[ 7.534778] usb usb1-port3: attempt power cycle
The boot failure is effect of lack of network adapter (USB, smsc95xx).
Expected:
[ 4.285831] usb 1-3: New USB device found, idVendor=0424, idProduct=3503, bcdDevice=a1.a0
[ 4.288986] usb 1-3: New USB device strings: Mfr=0, Product=0, SerialNumber=0
[ 4.299596] hub 1-3:1.0: USB hub found
[ 4.300027] hub 1-3:1.0: 3 ports detected
[ 5.895541] smsc95xx 1-2:1.0 eth0: link up, 100Mbps, full-duplex, lpa 0xCDE1
Full kernel log is here:
https://krzk.eu/#/builders/25/builds/1330/steps/14/logs/serial0
https://krzk.eu/#/builders/25/builds/1330
Let me know if you need any more details.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
[not found] ` <CGME20190506130052eucas1p25afd4e15648e9efc6fd011e46081fbea@eucas1p2.samsung.com>
@ 2019-05-06 13:00 ` Marek Szyprowski
2019-05-06 13:40 ` Jules Maselbas
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Marek Szyprowski @ 2019-05-06 13:00 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc, linux-kernel
Cc: Marek Szyprowski, Minas Harutyunyan, Felipe Balbi,
Bartlomiej Zolnierkiewicz, Jules Maselbas, Krzysztof Kozlowski
Samsung Exynos SoCs require to force UTMI width to 8bit, otherwise the
host side of the shared USB2 PHY doesn't work.
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with phy_utmi_width")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/usb/dwc2/params.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 6900eea57526..9ece4affb9d4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -76,6 +76,7 @@ static void dwc2_set_s3c6400_params(struct dwc2_hsotg *hsotg)
struct dwc2_core_params *p = &hsotg->params;
p->power_down = 0;
+ p->phy_utmi_width = 8;
}
static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
@ 2019-05-06 13:40 ` Jules Maselbas
2019-05-07 6:22 ` Minas Harutyunyan
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Jules Maselbas @ 2019-05-06 13:40 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-usb, linux-samsung-soc, linux-kernel, Minas Harutyunyan,
Felipe Balbi, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski
Hi,
On Mon, May 06, 2019 at 03:00:46PM +0200, Marek Szyprowski wrote:
> Samsung Exynos SoCs require to force UTMI width to 8bit, otherwise the
> host side of the shared USB2 PHY doesn't work.
>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with phy_utmi_width")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 6900eea57526..9ece4affb9d4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -76,6 +76,7 @@ static void dwc2_set_s3c6400_params(struct dwc2_hsotg *hsotg)
> struct dwc2_core_params *p = &hsotg->params;
>
> p->power_down = 0;
> + p->phy_utmi_width = 8;
Nice catch.
I though that 8bits would be the default value, I am curious to know why it's not ny default at 8.
Thanks.
---
Jules
> }
>
> static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width
2019-05-03 20:49 [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Krzysztof Kozlowski
[not found] ` <CGME20190506130052eucas1p25afd4e15648e9efc6fd011e46081fbea@eucas1p2.samsung.com>
@ 2019-05-07 6:21 ` Minas Harutyunyan
2019-05-07 6:43 ` Marek Szyprowski
1 sibling, 1 reply; 11+ messages in thread
From: Minas Harutyunyan @ 2019-05-07 6:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jules Maselbas
Cc: Felipe Balbi, linux-usb, linux-kernel, linux-samsung-soc,
Marek Szyprowski
Hi Krzysztof,
On 5/4/2019 12:50 AM, Krzysztof Kozlowski wrote:
> Hi,
>
> Bisect pointed commit 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif
> with phy_utmi_width") as reason for failures of USB on Exynos4412,
> Odroid U3 board (ARMv7, exynos_defconfig, TFTP boot with nfsroot from
> NFSv4):
>
> [ 4.333996] usb 1-2: new high-speed USB device number 3 using exynos-ehci
> [ 4.503942] usb 1-2: device descriptor read/64, error -71
> [ 4.793970] usb 1-2: device descriptor read/64, error -71
> [ 4.914748] usb usb1-port2: attempt power cycle
> [ 6.224267] usb 1-3: new high-speed USB device number 5 using exynos-ehci
> [ 6.393983] usb 1-3: device descriptor read/64, error -71
> [ 6.684243] usb 1-3: device descriptor read/64, error -71
> [ 6.954259] usb 1-3: new high-speed USB device number 6 using exynos-ehci
> [ 7.123980] usb 1-3: device descriptor read/64, error -71
> [ 7.413969] usb 1-3: device descriptor read/64, error -71
> [ 7.534778] usb usb1-port3: attempt power cycle
>
> The boot failure is effect of lack of network adapter (USB, smsc95xx).
> Expected:
> [ 4.285831] usb 1-3: New USB device found, idVendor=0424, idProduct=3503, bcdDevice=a1.a0
> [ 4.288986] usb 1-3: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> [ 4.299596] hub 1-3:1.0: USB hub found
> [ 4.300027] hub 1-3:1.0: 3 ports detected
> [ 5.895541] smsc95xx 1-2:1.0 eth0: link up, 100Mbps, full-duplex, lpa 0xCDE1
>
> Full kernel log is here:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__krzk.eu_-23_builders_25_builds_1330_steps_14_logs_serial0&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=6z9Al9FrHR_ZqbbtSAsD16pvOL2S3XHxQnSzq8kusyI&m=OiD-VOiMNPgl24seQpn5JKZq7f85A4LNzaz8zX0YrKs&s=WBsxDt_1PXo9t9AxxJkUTTLE6zx_UDc7ac_U3EydCzI&e=
> https://urldefense.proofpoint.com/v2/url?u=https-3A__krzk.eu_-23_builders_25_builds_1330&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=6z9Al9FrHR_ZqbbtSAsD16pvOL2S3XHxQnSzq8kusyI&m=OiD-VOiMNPgl24seQpn5JKZq7f85A4LNzaz8zX0YrKs&s=Lxk4ZiitEFaod88HTY0hthrdRy_TtktU53P6UDtaCoE&e=
>
> Let me know if you need any more details.
>
> Best regards,
> Krzysztof
>
>
But fail seen on ehci driver not dwc2.
Thanks,
Minas
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
2019-05-06 13:40 ` Jules Maselbas
@ 2019-05-07 6:22 ` Minas Harutyunyan
2019-05-07 8:12 ` Markus Reichl
2019-06-05 8:57 ` Krzysztof Kozlowski
3 siblings, 0 replies; 11+ messages in thread
From: Minas Harutyunyan @ 2019-05-07 6:22 UTC (permalink / raw)
To: Marek Szyprowski, linux-usb, linux-samsung-soc, linux-kernel
Cc: Felipe Balbi, Bartlomiej Zolnierkiewicz, Jules Maselbas,
Krzysztof Kozlowski
On 5/6/2019 5:01 PM, Marek Szyprowski wrote:
> Samsung Exynos SoCs require to force UTMI width to 8bit, otherwise the
> host side of the shared USB2 PHY doesn't work.
>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with phy_utmi_width")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 6900eea57526..9ece4affb9d4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -76,6 +76,7 @@ static void dwc2_set_s3c6400_params(struct dwc2_hsotg *hsotg)
> struct dwc2_core_params *p = &hsotg->params;
>
> p->power_down = 0;
> + p->phy_utmi_width = 8;
> }
>
> static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width
2019-05-07 6:21 ` [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Minas Harutyunyan
@ 2019-05-07 6:43 ` Marek Szyprowski
0 siblings, 0 replies; 11+ messages in thread
From: Marek Szyprowski @ 2019-05-07 6:43 UTC (permalink / raw)
To: Minas Harutyunyan, Krzysztof Kozlowski, Jules Maselbas
Cc: Felipe Balbi, linux-usb, linux-kernel, linux-samsung-soc
Hi Minas,
On 2019-05-07 08:21, Minas Harutyunyan wrote:
> Hi Krzysztof,
>
> On 5/4/2019 12:50 AM, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Bisect pointed commit 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif
>> with phy_utmi_width") as reason for failures of USB on Exynos4412,
>> Odroid U3 board (ARMv7, exynos_defconfig, TFTP boot with nfsroot from
>> NFSv4):
>>
>> [ 4.333996] usb 1-2: new high-speed USB device number 3 using
>> exynos-ehci
>> [ 4.503942] usb 1-2: device descriptor read/64, error -71
>> [ 4.793970] usb 1-2: device descriptor read/64, error -71
>> [ 4.914748] usb usb1-port2: attempt power cycle
>> [ 6.224267] usb 1-3: new high-speed USB device number 5 using
>> exynos-ehci
>> [ 6.393983] usb 1-3: device descriptor read/64, error -71
>> [ 6.684243] usb 1-3: device descriptor read/64, error -71
>> [ 6.954259] usb 1-3: new high-speed USB device number 6 using
>> exynos-ehci
>> [ 7.123980] usb 1-3: device descriptor read/64, error -71
>> [ 7.413969] usb 1-3: device descriptor read/64, error -71
>> [ 7.534778] usb usb1-port3: attempt power cycle
>>
>> The boot failure is effect of lack of network adapter (USB, smsc95xx).
>> Expected:
>> [ 4.285831] usb 1-3: New USB device found, idVendor=0424,
>> idProduct=3503, bcdDevice=a1.a0
>> [ 4.288986] usb 1-3: New USB device strings: Mfr=0, Product=0,
>> SerialNumber=0
>> [ 4.299596] hub 1-3:1.0: USB hub found
>> [ 4.300027] hub 1-3:1.0: 3 ports detected
>> [ 5.895541] smsc95xx 1-2:1.0 eth0: link up, 100Mbps, full-duplex,
>> lpa 0xCDE1
>>
>> Full kernel log is here:
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__krzk.eu_-23_builders_25_builds_1330_steps_14_logs_serial0&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=6z9Al9FrHR_ZqbbtSAsD16pvOL2S3XHxQnSzq8kusyI&m=OiD-VOiMNPgl24seQpn5JKZq7f85A4LNzaz8zX0YrKs&s=WBsxDt_1PXo9t9AxxJkUTTLE6zx_UDc7ac_U3EydCzI&e=
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__krzk.eu_-23_builders_25_builds_1330&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=6z9Al9FrHR_ZqbbtSAsD16pvOL2S3XHxQnSzq8kusyI&m=OiD-VOiMNPgl24seQpn5JKZq7f85A4LNzaz8zX0YrKs&s=Lxk4ZiitEFaod88HTY0hthrdRy_TtktU53P6UDtaCoE&e=
>>
>>
>> Let me know if you need any more details.
>>
>> Best regards,
>> Krzysztof
>>
>>
>
> But fail seen on ehci driver not dwc2.
Right, but dwc2 and ehci share common USB2 PHY on Exynos4 SoCs, although
they use different ports of it.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
2019-05-06 13:40 ` Jules Maselbas
2019-05-07 6:22 ` Minas Harutyunyan
@ 2019-05-07 8:12 ` Markus Reichl
2019-05-07 9:17 ` Marek Szyprowski
2019-06-05 8:57 ` Krzysztof Kozlowski
3 siblings, 1 reply; 11+ messages in thread
From: Markus Reichl @ 2019-05-07 8:12 UTC (permalink / raw)
To: Marek Szyprowski, linux-usb, linux-samsung-soc, linux-kernel
Cc: Minas Harutyunyan, Felipe Balbi, Bartlomiej Zolnierkiewicz,
Jules Maselbas, Krzysztof Kozlowski
[-- Attachment #1.1: Type: text/plain, Size: 2137 bytes --]
Hi Marek,
your patch did not help on stable v5.1
[ 3.255963] samsung-usb2-phy 125b0000.exynos-usbphy: 125b0000.exynos-usbphy supply vbus not found, using dummy regulator
[ 4.044547] usbcore: registered new interface driver smsc95xx
[ 4.112261] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.01
[ 4.120363] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[ 4.127560] usb usb1: Product: EHCI Host Controller
[ 4.132415] usb usb1: Manufacturer: Linux 5.1.0-00005-geb4efae48eb5 ehci_hcd
[ 4.139446] usb usb1: SerialNumber: 12580000.ehci
[ 4.183056] usb3503 0-0008: switched to HUB mode
[ 4.183121] usb3503 0-0008: usb3503_probe: probed in hub mode
[ 4.488344] usb 1-2: new high-speed USB device number 2 using exynos-ehci
[ 4.675605] usb 1-2: New USB device found, idVendor=0424, idProduct=3503, bcdDevice=a1.a0
[ 4.678166] usb 1-2: New USB device strings: Mfr=0, Product=0, SerialNumber=0
[ 4.686140] usb 1-2: skipping disabled interface 0
root@odroid-x2:~# lsusb
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Am 06.05.19 um 15:00 schrieb Marek Szyprowski:
> Samsung Exynos SoCs require to force UTMI width to 8bit, otherwise the
> host side of the shared USB2 PHY doesn't work.
>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with phy_utmi_width")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 6900eea57526..9ece4affb9d4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -76,6 +76,7 @@ static void dwc2_set_s3c6400_params(struct dwc2_hsotg *hsotg)
> struct dwc2_core_params *p = &hsotg->params;
>
> p->power_down = 0;
> + p->phy_utmi_width = 8;
> }
>
> static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
>
Gruß,
--
Markus Reichl
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-07 8:12 ` Markus Reichl
@ 2019-05-07 9:17 ` Marek Szyprowski
2019-05-07 12:03 ` Marek Szyprowski
0 siblings, 1 reply; 11+ messages in thread
From: Marek Szyprowski @ 2019-05-07 9:17 UTC (permalink / raw)
To: Markus Reichl, linux-usb, linux-samsung-soc, linux-kernel
Cc: Minas Harutyunyan, Felipe Balbi, Bartlomiej Zolnierkiewicz,
Jules Maselbas, Krzysztof Kozlowski
Hi Markus,
On 2019-05-07 10:12, Markus Reichl wrote:
> Hi Marek,
>
> your patch did not help on stable v5.1
>
> [ 3.255963] samsung-usb2-phy 125b0000.exynos-usbphy: 125b0000.exynos-usbphy supply vbus not found, using dummy regulator
> [ 4.044547] usbcore: registered new interface driver smsc95xx
> [ 4.112261] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.01
> [ 4.120363] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
> [ 4.127560] usb usb1: Product: EHCI Host Controller
> [ 4.132415] usb usb1: Manufacturer: Linux 5.1.0-00005-geb4efae48eb5 ehci_hcd
> [ 4.139446] usb usb1: SerialNumber: 12580000.ehci
> [ 4.183056] usb3503 0-0008: switched to HUB mode
> [ 4.183121] usb3503 0-0008: usb3503_probe: probed in hub mode
> [ 4.488344] usb 1-2: new high-speed USB device number 2 using exynos-ehci
> [ 4.675605] usb 1-2: New USB device found, idVendor=0424, idProduct=3503, bcdDevice=a1.a0
> [ 4.678166] usb 1-2: New USB device strings: Mfr=0, Product=0, SerialNumber=0
> [ 4.686140] usb 1-2: skipping disabled interface 0
>
> root@odroid-x2:~# lsusb
> Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
This patch fixes the issue introduced by "usb: dwc2: gadget: Replace
phyif with phy_utmi_width" commit, which is queued only to linux-next so
far. Stable v5.1 doesn't include it, so the fix doesn't change anything
on v5.1.
I've checked and OdroidU3 works fine with v5.1 release, but X2 fails to
detect USB devices. I will investigate this in a few minutes...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-07 9:17 ` Marek Szyprowski
@ 2019-05-07 12:03 ` Marek Szyprowski
2019-05-07 12:38 ` Markus Reichl
0 siblings, 1 reply; 11+ messages in thread
From: Marek Szyprowski @ 2019-05-07 12:03 UTC (permalink / raw)
To: Markus Reichl, linux-usb, linux-samsung-soc, linux-kernel
Cc: Minas Harutyunyan, Felipe Balbi, Bartlomiej Zolnierkiewicz,
Jules Maselbas, Krzysztof Kozlowski
Hi All,
On 2019-05-07 11:17, Marek Szyprowski wrote:
> Hi Markus,
>
> On 2019-05-07 10:12, Markus Reichl wrote:
>> Hi Marek,
>>
>> your patch did not help on stable v5.1
>>
>> [ 3.255963] samsung-usb2-phy 125b0000.exynos-usbphy:
>> 125b0000.exynos-usbphy supply vbus not found, using dummy regulator
>> [ 4.044547] usbcore: registered new interface driver smsc95xx
>> [ 4.112261] usb usb1: New USB device found, idVendor=1d6b,
>> idProduct=0002, bcdDevice= 5.01
>> [ 4.120363] usb usb1: New USB device strings: Mfr=3, Product=2,
>> SerialNumber=1
>> [ 4.127560] usb usb1: Product: EHCI Host Controller
>> [ 4.132415] usb usb1: Manufacturer: Linux
>> 5.1.0-00005-geb4efae48eb5 ehci_hcd
>> [ 4.139446] usb usb1: SerialNumber: 12580000.ehci
>> [ 4.183056] usb3503 0-0008: switched to HUB mode
>> [ 4.183121] usb3503 0-0008: usb3503_probe: probed in hub mode
>> [ 4.488344] usb 1-2: new high-speed USB device number 2 using
>> exynos-ehci
>> [ 4.675605] usb 1-2: New USB device found, idVendor=0424,
>> idProduct=3503, bcdDevice=a1.a0
>> [ 4.678166] usb 1-2: New USB device strings: Mfr=0, Product=0,
>> SerialNumber=0
>> [ 4.686140] usb 1-2: skipping disabled interface 0
>>
>> root@odroid-x2:~# lsusb
>> Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
>> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
>
> This patch fixes the issue introduced by "usb: dwc2: gadget: Replace
> phyif with phy_utmi_width" commit, which is queued only to linux-next
> so far. Stable v5.1 doesn't include it, so the fix doesn't change
> anything on v5.1.
>
> I've checked and OdroidU3 works fine with v5.1 release, but X2 fails
> to detect USB devices. I will investigate this in a few minutes...
Broken USB on X2 is caused by commit
01fdf179f4b064d4c9d30b39aba178caf32649f4 ("usb: core: skip interfaces
disabled in devicetree").
I looks that the mentioned commit conflicts with the Exynos EHCI and
OHCI bindings and the way the PHY ports are defined for those drivers.
It worked on U3 only by the pure coincidence. This is probably a
"minimal" fix for this issue:
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 82239f27c4cc..cd455c4add25 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -2007,6 +2007,7 @@ int usb_set_configuration(struct usb_device *dev,
int configuration)
struct usb_interface *intf = cp->interface[i];
if (intf->dev.of_node &&
+ of_device_is_compatible(intf->dev.of_node, NULL) &&
!of_device_is_available(intf->dev.of_node)) {
dev_info(&dev->dev, "skipping disabled
interface %d\n",
intf->cur_altsetting->desc.bInterfaceNumber);
I will try to describe the problem in details and discuss it on the usb
mailing list.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-07 12:03 ` Marek Szyprowski
@ 2019-05-07 12:38 ` Markus Reichl
0 siblings, 0 replies; 11+ messages in thread
From: Markus Reichl @ 2019-05-07 12:38 UTC (permalink / raw)
To: Marek Szyprowski, linux-usb, linux-samsung-soc, linux-kernel
Cc: Minas Harutyunyan, Felipe Balbi, Bartlomiej Zolnierkiewicz,
Jules Maselbas, Krzysztof Kozlowski
[-- Attachment #1.1: Type: text/plain, Size: 3350 bytes --]
Hi Marek,
Am 07.05.19 um 14:03 schrieb Marek Szyprowski:
> Hi All,
>
> On 2019-05-07 11:17, Marek Szyprowski wrote:
>> Hi Markus,
>>
>> On 2019-05-07 10:12, Markus Reichl wrote:
>>> Hi Marek,
>>>
>>> your patch did not help on stable v5.1
>>>
>>> [ 3.255963] samsung-usb2-phy 125b0000.exynos-usbphy:
>>> 125b0000.exynos-usbphy supply vbus not found, using dummy regulator
>>> [ 4.044547] usbcore: registered new interface driver smsc95xx
>>> [ 4.112261] usb usb1: New USB device found, idVendor=1d6b,
>>> idProduct=0002, bcdDevice= 5.01
>>> [ 4.120363] usb usb1: New USB device strings: Mfr=3, Product=2,
>>> SerialNumber=1
>>> [ 4.127560] usb usb1: Product: EHCI Host Controller
>>> [ 4.132415] usb usb1: Manufacturer: Linux
>>> 5.1.0-00005-geb4efae48eb5 ehci_hcd
>>> [ 4.139446] usb usb1: SerialNumber: 12580000.ehci
>>> [ 4.183056] usb3503 0-0008: switched to HUB mode
>>> [ 4.183121] usb3503 0-0008: usb3503_probe: probed in hub mode
>>> [ 4.488344] usb 1-2: new high-speed USB device number 2 using
>>> exynos-ehci
>>> [ 4.675605] usb 1-2: New USB device found, idVendor=0424,
>>> idProduct=3503, bcdDevice=a1.a0
>>> [ 4.678166] usb 1-2: New USB device strings: Mfr=0, Product=0,
>>> SerialNumber=0
>>> [ 4.686140] usb 1-2: skipping disabled interface 0
>>>
>>> root@odroid-x2:~# lsusb
>>> Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
>>> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
>>
>> This patch fixes the issue introduced by "usb: dwc2: gadget: Replace
>> phyif with phy_utmi_width" commit, which is queued only to linux-next
>> so far. Stable v5.1 doesn't include it, so the fix doesn't change
>> anything on v5.1.
>>
>> I've checked and OdroidU3 works fine with v5.1 release, but X2 fails
>> to detect USB devices. I will investigate this in a few minutes...
>
>
> Broken USB on X2 is caused by commit
> 01fdf179f4b064d4c9d30b39aba178caf32649f4 ("usb: core: skip interfaces
> disabled in devicetree").
>
> I looks that the mentioned commit conflicts with the Exynos EHCI and
> OHCI bindings and the way the PHY ports are defined for those drivers.
> It worked on U3 only by the pure coincidence. This is probably a
> "minimal" fix for this issue:
Thanks Marek, below fix enables USB on Odroid-X2 with stable v5.1.
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 82239f27c4cc..cd455c4add25 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -2007,6 +2007,7 @@ int usb_set_configuration(struct usb_device *dev,
> int configuration)
> struct usb_interface *intf = cp->interface[i];
>
> if (intf->dev.of_node &&
> + of_device_is_compatible(intf->dev.of_node, NULL) &&
> !of_device_is_available(intf->dev.of_node)) {
> dev_info(&dev->dev, "skipping disabled
> interface %d\n",
> intf->cur_altsetting->desc.bInterfaceNumber);
>
> I will try to describe the problem in details and discuss it on the usb
> mailing list.
>
> Best regards
>
Gruß,
--
Markus Reichl
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
` (2 preceding siblings ...)
2019-05-07 8:12 ` Markus Reichl
@ 2019-06-05 8:57 ` Krzysztof Kozlowski
3 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2019-06-05 8:57 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-usb, linux-samsung-soc, linux-kernel, Minas Harutyunyan,
Felipe Balbi, Bartlomiej Zolnierkiewicz, Jules Maselbas
On Mon, 6 May 2019 at 15:00, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Samsung Exynos SoCs require to force UTMI width to 8bit, otherwise the
> host side of the shared USB2 PHY doesn't work.
>
> Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
> Fixes: 707d80f0a3c5 ("usb: dwc2: gadget: Replace phyif with phy_utmi_width")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-06-05 8:57 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-03 20:49 [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Krzysztof Kozlowski
[not found] ` <CGME20190506130052eucas1p25afd4e15648e9efc6fd011e46081fbea@eucas1p2.samsung.com>
2019-05-06 13:00 ` [PATCH] usb: dwc2: Force 8bit UTMI width for Samsung Exynos SoCs Marek Szyprowski
2019-05-06 13:40 ` Jules Maselbas
2019-05-07 6:22 ` Minas Harutyunyan
2019-05-07 8:12 ` Markus Reichl
2019-05-07 9:17 ` Marek Szyprowski
2019-05-07 12:03 ` Marek Szyprowski
2019-05-07 12:38 ` Markus Reichl
2019-06-05 8:57 ` Krzysztof Kozlowski
2019-05-07 6:21 ` [BUG BISECT] USB on Exynos4412 fails after usb: dwc2: gadget: Replace phyif with phy_utmi_width Minas Harutyunyan
2019-05-07 6:43 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).