* [PATCH net-next] netdevsim: Make nsim_num_vf static
@ 2019-05-04 8:12 YueHaibing
2019-05-04 11:07 ` Jakub Kicinski
2019-05-05 17:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-04 8:12 UTC (permalink / raw)
To: davem, jakub.kicinski; +Cc: linux-kernel, netdev, YueHaibing
Fix sparse warning:
drivers/net/netdevsim/bus.c:253:5: warning:
symbol 'nsim_num_vf' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/netdevsim/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c
index ae48234..868fb9a 100644
--- a/drivers/net/netdevsim/bus.c
+++ b/drivers/net/netdevsim/bus.c
@@ -250,7 +250,7 @@ static int nsim_bus_remove(struct device *dev)
return 0;
}
-int nsim_num_vf(struct device *dev)
+static int nsim_num_vf(struct device *dev)
{
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netdevsim: Make nsim_num_vf static
2019-05-04 8:12 [PATCH net-next] netdevsim: Make nsim_num_vf static YueHaibing
@ 2019-05-04 11:07 ` Jakub Kicinski
2019-05-05 17:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-05-04 11:07 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, linux-kernel, netdev
On Sat, 4 May 2019 16:12:07 +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/net/netdevsim/bus.c:253:5: warning:
> symbol 'nsim_num_vf' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netdevsim: Make nsim_num_vf static
2019-05-04 8:12 [PATCH net-next] netdevsim: Make nsim_num_vf static YueHaibing
2019-05-04 11:07 ` Jakub Kicinski
@ 2019-05-05 17:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-05 17:49 UTC (permalink / raw)
To: yuehaibing; +Cc: jakub.kicinski, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 4 May 2019 16:12:07 +0800
> Fix sparse warning:
>
> drivers/net/netdevsim/bus.c:253:5: warning:
> symbol 'nsim_num_vf' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-05 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-04 8:12 [PATCH net-next] netdevsim: Make nsim_num_vf static YueHaibing
2019-05-04 11:07 ` Jakub Kicinski
2019-05-05 17:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).