* [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check
@ 2019-05-05 19:24 Ruslan Babayev
2019-05-11 11:20 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Ruslan Babayev @ 2019-05-05 19:24 UTC (permalink / raw)
To: Andrew Morton
Cc: xe-linux-external, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio,
linux-kernel
The driver doesn't actually rely on any DT properties. Removing this
check makes it usable on ACPI based platforms.
Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
Cc: xe-linux-external@cisco.com
---
drivers/iio/dac/ds4424.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
index 883a47562055..2b3ba1a66fe8 100644
--- a/drivers/iio/dac/ds4424.c
+++ b/drivers/iio/dac/ds4424.c
@@ -236,12 +236,6 @@ static int ds4424_probe(struct i2c_client *client,
indio_dev->dev.of_node = client->dev.of_node;
indio_dev->dev.parent = &client->dev;
- if (!client->dev.of_node) {
- dev_err(&client->dev,
- "Not found DT.\n");
- return -ENODEV;
- }
-
data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
if (IS_ERR(data->vcc_reg)) {
dev_err(&client->dev,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check
2019-05-05 19:24 [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check Ruslan Babayev
@ 2019-05-11 11:20 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-05-11 11:20 UTC (permalink / raw)
To: Ruslan Babayev
Cc: Andrew Morton, xe-linux-external, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio,
linux-kernel
On Sun, 5 May 2019 12:24:36 -0700
Ruslan Babayev <ruslan@babayev.com> wrote:
> The driver doesn't actually rely on any DT properties. Removing this
> check makes it usable on ACPI based platforms.
>
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ds4424.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 883a47562055..2b3ba1a66fe8 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -236,12 +236,6 @@ static int ds4424_probe(struct i2c_client *client,
> indio_dev->dev.of_node = client->dev.of_node;
> indio_dev->dev.parent = &client->dev;
>
> - if (!client->dev.of_node) {
> - dev_err(&client->dev,
> - "Not found DT.\n");
> - return -ENODEV;
> - }
> -
> data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
> if (IS_ERR(data->vcc_reg)) {
> dev_err(&client->dev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-11 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-05 19:24 [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check Ruslan Babayev
2019-05-11 11:20 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).