* linux-next: Fixes tags need some work in the block tree
@ 2019-05-06 20:43 Stephen Rothwell
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2019-05-06 20:43 UTC (permalink / raw)
To: Jens Axboe
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Igor Konopko
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
Hi all,
In commit
486b5aac85f6 ("lightnvm: pblk: fix lock order in pblk_rb_tear_down_check")
Fixes tag
Fixes: a4bd217 ("lightnvm: physical block device (pblk) target")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
In commit
4ca885241950 ("lightnvm: pblk: fix race during put line")
Fixes tag
Fixes: a4bd217 ("lightnvm: physical block device (pblk) target")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tags need some work in the block tree
2019-12-27 20:44 ` Jens Axboe
@ 2019-12-27 21:51 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2019-12-27 21:51 UTC (permalink / raw)
To: Jens Axboe, Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jaedon Shin
On 12/27/2019 12:44 PM, Jens Axboe wrote:
> On 12/27/19 1:39 PM, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> On Fri, 27 Dec 2019 13:29:40 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>>> On 12/27/19 1:27 PM, Florian Fainelli wrote:
>>>> On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
>>>>>
>>>>> In commit
>>>>>
>>>>> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>>>>>
>>>>> Fixes tags
>>>>>
>>>>> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
>>>>> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>>>>>
>>>>> have this problem:
>>>>>
>>>>> - Target SHA1s do not exist
>>>>>
>>>>> Perhaps you meant
>>>>>
>>>>> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
>>>>> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
>>>>
>>>> Yes, those are the two that should have been used, the two commits were
>>>> extracted from a downstream tree where the upstream commits ended up
>>>> looking slightly different, my script does not (yet) rewrite those, Jens
>>>> would you want me to resubmit or can you rewrite the commit message in
>>>> place?
>>>
>>> It's too late unfortunately, Linus already pulled it. So we'll have to
>>> live with it, at least the commit titles are correct so it should be
>>> manageable.
>>
>> Unfortunately, even the titles are not correct, so they took me a
>> little time to find the correct commits :-( This means it will also
>> take the stable maintainers a bit of time.
>
> Yeah I see, the 2nd one is not. Gah, that really sucks. I'll let stable
> know.
>
> Florian, please ensure that future submissions have both the right titles
> and shas.
Definitively, very sorry about that and thank you both.
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tags need some work in the block tree
2019-12-27 20:39 ` Stephen Rothwell
@ 2019-12-27 20:44 ` Jens Axboe
2019-12-27 21:51 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2019-12-27 20:44 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Florian Fainelli, Linux Next Mailing List,
Linux Kernel Mailing List, Jaedon Shin
On 12/27/19 1:39 PM, Stephen Rothwell wrote:
> Hi Jens,
>
> On Fri, 27 Dec 2019 13:29:40 -0700 Jens Axboe <axboe@kernel.dk> wrote:
>> On 12/27/19 1:27 PM, Florian Fainelli wrote:
>>> On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
>>>>
>>>> In commit
>>>>
>>>> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>>>>
>>>> Fixes tags
>>>>
>>>> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
>>>> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>>>>
>>>> have this problem:
>>>>
>>>> - Target SHA1s do not exist
>>>>
>>>> Perhaps you meant
>>>>
>>>> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
>>>> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
>>>
>>> Yes, those are the two that should have been used, the two commits were
>>> extracted from a downstream tree where the upstream commits ended up
>>> looking slightly different, my script does not (yet) rewrite those, Jens
>>> would you want me to resubmit or can you rewrite the commit message in
>>> place?
>>
>> It's too late unfortunately, Linus already pulled it. So we'll have to
>> live with it, at least the commit titles are correct so it should be
>> manageable.
>
> Unfortunately, even the titles are not correct, so they took me a
> little time to find the correct commits :-( This means it will also
> take the stable maintainers a bit of time.
Yeah I see, the 2nd one is not. Gah, that really sucks. I'll let stable
know.
Florian, please ensure that future submissions have both the right titles
and shas.
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tags need some work in the block tree
2019-12-27 20:29 ` Jens Axboe
@ 2019-12-27 20:39 ` Stephen Rothwell
2019-12-27 20:44 ` Jens Axboe
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2019-12-27 20:39 UTC (permalink / raw)
To: Jens Axboe
Cc: Florian Fainelli, Linux Next Mailing List,
Linux Kernel Mailing List, Jaedon Shin
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
Hi Jens,
On Fri, 27 Dec 2019 13:29:40 -0700 Jens Axboe <axboe@kernel.dk> wrote:
> On 12/27/19 1:27 PM, Florian Fainelli wrote:
> > On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
> >>
> >> In commit
> >>
> >> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
> >>
> >> Fixes tags
> >>
> >> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
> >> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
> >>
> >> have this problem:
> >>
> >> - Target SHA1s do not exist
> >>
> >> Perhaps you meant
> >>
> >> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
> >> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
> >
> > Yes, those are the two that should have been used, the two commits were
> > extracted from a downstream tree where the upstream commits ended up
> > looking slightly different, my script does not (yet) rewrite those, Jens
> > would you want me to resubmit or can you rewrite the commit message in
> > place?
>
> It's too late unfortunately, Linus already pulled it. So we'll have to
> live with it, at least the commit titles are correct so it should be
> manageable.
Unfortunately, even the titles are not correct, so they took me a
little time to find the correct commits :-( This means it will also
take the stable maintainers a bit of time.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tags need some work in the block tree
2019-12-27 20:27 ` Florian Fainelli
@ 2019-12-27 20:29 ` Jens Axboe
2019-12-27 20:39 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2019-12-27 20:29 UTC (permalink / raw)
To: Florian Fainelli, Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jaedon Shin
On 12/27/19 1:27 PM, Florian Fainelli wrote:
>
>
> On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>>
>> Fixes tags
>>
>> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
>> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>>
>> have this problem:
>>
>> - Target SHA1s do not exist
>>
>> Perhaps you meant
>>
>> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
>> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
>
> Yes, those are the two that should have been used, the two commits were
> extracted from a downstream tree where the upstream commits ended up
> looking slightly different, my script does not (yet) rewrite those, Jens
> would you want me to resubmit or can you rewrite the commit message in
> place?
It's too late unfortunately, Linus already pulled it. So we'll have to
live with it, at least the commit titles are correct so it should be
manageable.
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Fixes tags need some work in the block tree
2019-12-27 19:55 Stephen Rothwell
@ 2019-12-27 20:27 ` Florian Fainelli
2019-12-27 20:29 ` Jens Axboe
0 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2019-12-27 20:27 UTC (permalink / raw)
To: Stephen Rothwell, Jens Axboe
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jaedon Shin
On 12/27/2019 11:55 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
>
> Fixes tags
>
> Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
> Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
>
> have this problem:
>
> - Target SHA1s do not exist
>
> Perhaps you meant
>
> Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
> Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
Yes, those are the two that should have been used, the two commits were
extracted from a downstream tree where the upstream commits ended up
looking slightly different, my script does not (yet) rewrite those, Jens
would you want me to resubmit or can you rewrite the commit message in
place?
>
> or
>
> Fixes: b46f79bc78e0 ("ata: ahci_brcmstb: add a quirk for MIPS-based platforms")
>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: Fixes tags need some work in the block tree
@ 2019-12-27 19:55 Stephen Rothwell
2019-12-27 20:27 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2019-12-27 19:55 UTC (permalink / raw)
To: Jens Axboe
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Florian Fainelli, Jaedon Shin
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hi all,
In commit
1a3d78cb6e20 ("ata: ahci_brcm: BCM7425 AHCI requires AHCI_HFLAG_DELAY_ENGINE")
Fixes tags
Fixes: 9586114cf1e9 ("ata: ahci_brcmstb: add support MIPS-based platforms")
Fixes: 423be77daabe ("ata: ahci_brcmstb: add quirk for broken ncq")
have this problem:
- Target SHA1s do not exist
Perhaps you meant
Fixes: 1980eb9bd7d7 ("ata: ahci_brcmstb: add support for MIPS-based platforms")
Fixes: 7de3244530bf ("ata: ahci_brcmstb: disable NCQ for MIPS-based platforms")
or
Fixes: b46f79bc78e0 ("ata: ahci_brcmstb: add a quirk for MIPS-based platforms")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-27 21:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06 20:43 linux-next: Fixes tags need some work in the block tree Stephen Rothwell
2019-12-27 19:55 Stephen Rothwell
2019-12-27 20:27 ` Florian Fainelli
2019-12-27 20:29 ` Jens Axboe
2019-12-27 20:39 ` Stephen Rothwell
2019-12-27 20:44 ` Jens Axboe
2019-12-27 21:51 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).