linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3
@ 2019-04-20 14:52 Yangtao Li
  2019-05-02  7:34 ` Maxime Ripard
  2019-05-07  9:42 ` Ondřej Jirman
  0 siblings, 2 replies; 5+ messages in thread
From: Yangtao Li @ 2019-04-20 14:52 UTC (permalink / raw)
  To: maxime.ripard, wens, robh+dt, mark.rutland
  Cc: linux-arm-kernel, devicetree, linux-kernel, Yangtao Li

Orangepi 3 has HDMI type A connector.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
rebase:
sunxi/dt64-for-5.2 arm64: dts: allwinner: a64-amarula-relic: Add OV5640
camera node
---
 .../dts/allwinner/sun50i-h6-orangepi-3.dts    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
index 17d496990108..6ed3a1ee297d 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
@@ -21,6 +21,17 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	connector {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_in: endpoint {
+				remote-endpoint = <&hdmi_out_con>;
+			};
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -50,6 +61,10 @@
 	cpu-supply = <&reg_dcdca>;
 };
 
+&de {
+	status = "okay";
+};
+
 &ehci0 {
 	status = "okay";
 };
@@ -58,6 +73,16 @@
 	status = "okay";
 };
 
+&hdmi {
+	status = "okay";
+};
+
+&hdmi_out {
+	hdmi_out_con: endpoint {
+		remote-endpoint = <&hdmi_con_in>;
+	};
+};
+
 &mmc0 {
 	vmmc-supply = <&reg_cldo1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3
  2019-04-20 14:52 [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3 Yangtao Li
@ 2019-05-02  7:34 ` Maxime Ripard
  2019-05-07  9:35   ` Ondřej Jirman
  2019-05-07  9:42 ` Ondřej Jirman
  1 sibling, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2019-05-02  7:34 UTC (permalink / raw)
  To: Yangtao Li
  Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

On Sat, Apr 20, 2019 at 10:52:40AM -0400, Yangtao Li wrote:
> Orangepi 3 has HDMI type A connector.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>

Queued for 5.3, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3
  2019-05-02  7:34 ` Maxime Ripard
@ 2019-05-07  9:35   ` Ondřej Jirman
  2019-05-07  9:48     ` Maxime Ripard
  0 siblings, 1 reply; 5+ messages in thread
From: Ondřej Jirman @ 2019-05-07  9:35 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Yangtao Li, mark.rutland, devicetree, linux-kernel, wens,
	robh+dt, linux-arm-kernel

Hi Maxime,

On Thu, May 02, 2019 at 09:34:01AM +0200, Maxime Ripard wrote:
> On Sat, Apr 20, 2019 at 10:52:40AM -0400, Yangtao Li wrote:
> > Orangepi 3 has HDMI type A connector.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> 
> Queued for 5.3, thanks!
> Maxime

This patch is not enough. HDMI support on Orange Pi 3 also needs to
enable DDC IO. While the SoC will feed some default output singal
into the display, without DDC enabled it will not work reliably.

That support is part of my Orange Pi 3 series, and will be reworked
for v5 of that series.

While I can rebase on top of this, it would be easier if you dropped
this patch until the propper support is ready. I don't see any reason
why this should be rushed with half-working solution.

regards,
	o.

> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3
  2019-04-20 14:52 [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3 Yangtao Li
  2019-05-02  7:34 ` Maxime Ripard
@ 2019-05-07  9:42 ` Ondřej Jirman
  1 sibling, 0 replies; 5+ messages in thread
From: Ondřej Jirman @ 2019-05-07  9:42 UTC (permalink / raw)
  To: Yangtao Li
  Cc: maxime.ripard, wens, robh+dt, mark.rutland, devicetree,
	linux-kernel, linux-arm-kernel

Hi Yangtao,

On Sat, Apr 20, 2019 at 10:52:40AM -0400, Yangtao Li wrote:
> Orangepi 3 has HDMI type A connector.

It also has DDC-IO-EN, whithout which HDMI will not work as expected
by most users.

I'm working on a proper solution (discussion here):

  https://lkml.org/lkml/2019/4/26/910

regards,
	o.

> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> rebase:
> sunxi/dt64-for-5.2 arm64: dts: allwinner: a64-amarula-relic: Add OV5640
> camera node
> ---
>  .../dts/allwinner/sun50i-h6-orangepi-3.dts    | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> index 17d496990108..6ed3a1ee297d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> @@ -21,6 +21,17 @@
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	connector {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  
> @@ -50,6 +61,10 @@
>  	cpu-supply = <&reg_dcdca>;
>  };
>  
> +&de {
> +	status = "okay";
> +};
> +
>  &ehci0 {
>  	status = "okay";
>  };
> @@ -58,6 +73,16 @@
>  	status = "okay";
>  };
>  
> +&hdmi {
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
>  &mmc0 {
>  	vmmc-supply = <&reg_cldo1>;
>  	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
> -- 
> 2.17.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3
  2019-05-07  9:35   ` Ondřej Jirman
@ 2019-05-07  9:48     ` Maxime Ripard
  0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2019-05-07  9:48 UTC (permalink / raw)
  To: Yangtao Li, mark.rutland, devicetree, linux-kernel, wens,
	robh+dt, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On Tue, May 07, 2019 at 11:35:35AM +0200, Ondřej Jirman wrote:
> Hi Maxime,
>
> On Thu, May 02, 2019 at 09:34:01AM +0200, Maxime Ripard wrote:
> > On Sat, Apr 20, 2019 at 10:52:40AM -0400, Yangtao Li wrote:
> > > Orangepi 3 has HDMI type A connector.
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >
> > Queued for 5.3, thanks!
> > Maxime
>
> This patch is not enough. HDMI support on Orange Pi 3 also needs to
> enable DDC IO. While the SoC will feed some default output singal
> into the display, without DDC enabled it will not work reliably.
>
> That support is part of my Orange Pi 3 series, and will be reworked
> for v5 of that series.
>
> While I can rebase on top of this, it would be easier if you dropped
> this patch until the propper support is ready. I don't see any reason
> why this should be rushed with half-working solution.

ACK, consider it dropped.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-07  9:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-20 14:52 [PATCH] arm64: dts: allwinner: h6: Enable HDMI output on orangepi 3 Yangtao Li
2019-05-02  7:34 ` Maxime Ripard
2019-05-07  9:35   ` Ondřej Jirman
2019-05-07  9:48     ` Maxime Ripard
2019-05-07  9:42 ` Ondřej Jirman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).