[PATCH] livepatch: Remove stale kobj_added entries from kernel-doc descriptions

[PATCH] livepatch: Remove stale kobj_added entries from kernel-doc descriptions

[Miroslav Benes]

Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling")
removed kobj_added members of klp_func, klp_object and klp_patch
structures. kernel-doc descriptions were omitted by accident. Remove
them.

Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 include/linux/livepatch.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
index a14bab1a0a3e..955d46f37b72 100644
--- a/include/linux/livepatch.h
+++ b/include/linux/livepatch.h
@@ -47,7 +47,6 @@
  * @stack_node:	list node for klp_ops func_stack list
  * @old_size:	size of the old function
  * @new_size:	size of the new function
- * @kobj_added: @kobj has been added and needs freeing
  * @nop:        temporary patch to use the original code again; dyn. allocated
  * @patched:	the func has been added to the klp_ops list
  * @transition:	the func is currently being applied or reverted
@@ -125,7 +124,6 @@ struct klp_callbacks {
  * @node:	list node for klp_patch obj_list
  * @mod:	kernel module associated with the patched object
  *		(NULL for vmlinux)
- * @kobj_added: @kobj has been added and needs freeing
  * @dynamic:    temporary object for nop functions; dynamically allocated
  * @patched:	the object's funcs have been added to the klp_ops list
  */
@@ -152,7 +150,6 @@ struct klp_object {
  * @list:	list node for global list of actively used patches
  * @kobj:	kobject for sysfs resources
  * @obj_list:	dynamic list of the object entries
- * @kobj_added: @kobj has been added and needs freeing
  * @enabled:	the patch is enabled (but operation may be incomplete)
  * @forced:	was involved in a forced transition
  * @free_work:	patch cleanup from workqueue-context
-- 
2.21.0

Re: [PATCH] livepatch: Remove stale kobj_added entries from kernel-doc descriptions

[Joe Lawrence]

On 5/7/19 9:08 AM, Miroslav Benes wrote:
> Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling")
> removed kobj_added members of klp_func, klp_object and klp_patch
> structures. kernel-doc descriptions were omitted by accident. Remove
> them.
> 
> Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
>   include/linux/livepatch.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
> index a14bab1a0a3e..955d46f37b72 100644
> --- a/include/linux/livepatch.h
> +++ b/include/linux/livepatch.h
> @@ -47,7 +47,6 @@
>    * @stack_node:	list node for klp_ops func_stack list
>    * @old_size:	size of the old function
>    * @new_size:	size of the new function
> - * @kobj_added: @kobj has been added and needs freeing
>    * @nop:        temporary patch to use the original code again; dyn. allocated
>    * @patched:	the func has been added to the klp_ops list
>    * @transition:	the func is currently being applied or reverted
> @@ -125,7 +124,6 @@ struct klp_callbacks {
>    * @node:	list node for klp_patch obj_list
>    * @mod:	kernel module associated with the patched object
>    *		(NULL for vmlinux)
> - * @kobj_added: @kobj has been added and needs freeing
>    * @dynamic:    temporary object for nop functions; dynamically allocated
>    * @patched:	the object's funcs have been added to the klp_ops list
>    */
> @@ -152,7 +150,6 @@ struct klp_object {
>    * @list:	list node for global list of actively used patches
>    * @kobj:	kobject for sysfs resources
>    * @obj_list:	dynamic list of the object entries
> - * @kobj_added: @kobj has been added and needs freeing
>    * @enabled:	the patch is enabled (but operation may be incomplete)
>    * @forced:	was involved in a forced transition
>    * @free_work:	patch cleanup from workqueue-context
> 

D'oh, missed that in the review.  Good eye, Kamalesh.

Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe

Re: [PATCH] livepatch: Remove stale kobj_added entries from kernel-doc descriptions

[Kamalesh Babulal]

On Tue, May 07, 2019 at 03:08:14PM +0200, Miroslav Benes wrote:
> Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling")
> removed kobj_added members of klp_func, klp_object and klp_patch
> structures. kernel-doc descriptions were omitted by accident. Remove
> them.
> 
> Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>

Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>

-- 
Kamalesh

Re: [PATCH] livepatch: Remove stale kobj_added entries from kernel-doc descriptions

[Jiri Kosina]

On Tue, 7 May 2019, Miroslav Benes wrote:

> Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling")
> removed kobj_added members of klp_func, klp_object and klp_patch
> structures. kernel-doc descriptions were omitted by accident. Remove
> them.

Applied to for-5.2/fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs