From: Keith Busch <kbusch@kernel.org>
To: "Heitke, Kenneth" <kenneth.heitke@intel.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Minwoo Im <minwoo.im.dev@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 6/7] nvme-pci: add device coredump support
Date: Tue, 7 May 2019 15:22:41 -0600 [thread overview]
Message-ID: <20190507212241.GA7113@localhost.localdomain> (raw)
In-Reply-To: <a4ec2c1a-1ff7-52fe-07bd-179613411536@intel.com>
On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote:
> On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > +
> > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf,
> > + size_t bytes, loff_t offset)
> > +{
> > + const size_t chunk_size = ctrl->max_hw_sectors * ctrl->page_size;
>
> Just curious if chunk_size is correct since page size and block size can
> be different.
They're always different. ctrl->page_size is hard-coded to 4k, while
sectors are always 512b.
next prev parent reply other threads:[~2019-05-07 21:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 16:58 [PATCH v2 0/7] nvme-pci: support device coredump Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 1/7] devcoredump: use memory_read_from_buffer Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 2/7] devcoredump: fix typo in comment Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device Akinobu Mita
2019-05-07 17:35 ` Heitke, Kenneth
2019-05-08 15:40 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 4/7] nvme.h: add telemetry log page definisions Akinobu Mita
2019-05-07 17:28 ` Heitke, Kenneth
2019-05-08 15:42 ` Akinobu Mita
2019-05-07 17:52 ` Heitke, Kenneth
2019-05-08 15:54 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 5/7] nvme: add facility to check log page attributes Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 6/7] nvme-pci: add device coredump support Akinobu Mita
2019-05-07 17:07 ` Keith Busch
2019-05-07 17:44 ` Heitke, Kenneth
2019-05-07 20:31 ` Heitke, Kenneth
2019-05-07 21:22 ` Keith Busch [this message]
2019-05-08 15:56 ` Akinobu Mita
[not found] ` <CGME20190507171318epcas5p129bb73b39447d62a7d266ed461687488@epcms2p3>
2019-05-08 0:25 ` Minwoo Im
2019-05-08 16:02 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 7/7] nvme-pci: trigger device coredump on command timeout Akinobu Mita
2019-05-07 17:43 ` [PATCH v2 0/7] nvme-pci: support device coredump Heitke, Kenneth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507212241.GA7113@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=johannes@sipsolutions.net \
--cc=keith.busch@intel.com \
--cc=kenneth.heitke@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).