From: Akinobu Mita <akinobu.mita@gmail.com>
To: "Heitke, Kenneth" <kenneth.heitke@intel.com>
Cc: linux-nvme@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Minwoo Im <minwoo.im.dev@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 4/7] nvme.h: add telemetry log page definisions
Date: Thu, 9 May 2019 00:42:20 +0900 [thread overview]
Message-ID: <CAC5umyjDn579iu4V1pXhKJ_PUQdNgY3LBZWgWgqQw_ZoNd88FQ@mail.gmail.com> (raw)
In-Reply-To: <81c0d1bd-c117-3fcb-959b-4507504021dd@intel.com>
2019年5月8日(水) 2:28 Heitke, Kenneth <kenneth.heitke@intel.com>:
>
>
>
> On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > Copy telemetry log page definisions from nvme-cli.
> >
> > Cc: Johannes Berg <johannes@sipsolutions.net>
> > Cc: Keith Busch <keith.busch@intel.com>
> > Cc: Jens Axboe <axboe@fb.com>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Sagi Grimberg <sagi@grimberg.me>
> > Cc: Minwoo Im <minwoo.im.dev@gmail.com>
> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> > ---
> > * v2
> > - New patch in this version.
> >
> > include/linux/nvme.h | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> > index c40720c..5217fe4 100644
> > --- a/include/linux/nvme.h
> > +++ b/include/linux/nvme.h
> > @@ -396,6 +396,28 @@ enum {
> > NVME_NIDT_UUID = 0x03,
> > };
> >
> > +/* Derived from 1.3a Figure 101: Get Log Page – Telemetry Host
> > + * -Initiated Log (Log Identifier 07h)
> > + */
> > +struct nvme_telemetry_log_page_hdr {
> > + __u8 lpi; /* Log page identifier */
> > + __u8 rsvd[4];
> > + __u8 iee_oui[3];
> > + __le16 dalb1; /* Data area 1 last block */
> > + __le16 dalb2; /* Data area 2 last block */
> > + __le16 dalb3; /* Data area 3 last block */
> > + __u8 rsvd1[368]; /* TODO verify */
>
> Remove the TODO
OK.
> > + __u8 ctrlavail; /* Controller initiated data avail?*/
> > + __u8 ctrldgn; /* Controller initiated telemetry Data Gen # */
> > + __u8 rsnident[128];
> > + /* We'll have to double fetch so we can get the header,
> > + * parse dalb1->3 determine how much size we need for the
> > + * log then alloc below. Or just do a secondary non-struct
> > + * allocation.
> > + */
>
> This comment isn't necessary. You usually can't read the entire
> telemetry log at once and the header is a fixed size. You would likely
> just read the header followed by reads of the different data areas.
This comment is derived from nvme-cli. So firstly, I'll send a patch
for nvme-cli. If the changes are accepted, I'll update this comment, too.
> > + __u8 telemetry_dataarea[0];
> > +};
> > +
> > struct nvme_smart_log {
> > __u8 critical_warning;
> > __u8 temperature[2];
> > @@ -832,6 +854,7 @@ enum {
> > NVME_LOG_FW_SLOT = 0x03,
> > NVME_LOG_CHANGED_NS = 0x04,
> > NVME_LOG_CMD_EFFECTS = 0x05,
> > + NVME_LOG_TELEMETRY_CTRL = 0x08,
> > NVME_LOG_ANA = 0x0c,
> > NVME_LOG_DISC = 0x70,
> > NVME_LOG_RESERVATION = 0x80,
> >
next prev parent reply other threads:[~2019-05-08 15:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 16:58 [PATCH v2 0/7] nvme-pci: support device coredump Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 1/7] devcoredump: use memory_read_from_buffer Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 2/7] devcoredump: fix typo in comment Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device Akinobu Mita
2019-05-07 17:35 ` Heitke, Kenneth
2019-05-08 15:40 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 4/7] nvme.h: add telemetry log page definisions Akinobu Mita
2019-05-07 17:28 ` Heitke, Kenneth
2019-05-08 15:42 ` Akinobu Mita [this message]
2019-05-07 17:52 ` Heitke, Kenneth
2019-05-08 15:54 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 5/7] nvme: add facility to check log page attributes Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 6/7] nvme-pci: add device coredump support Akinobu Mita
2019-05-07 17:07 ` Keith Busch
2019-05-07 17:44 ` Heitke, Kenneth
2019-05-07 20:31 ` Heitke, Kenneth
2019-05-07 21:22 ` Keith Busch
2019-05-08 15:56 ` Akinobu Mita
[not found] ` <CGME20190507171318epcas5p129bb73b39447d62a7d266ed461687488@epcms2p3>
2019-05-08 0:25 ` Minwoo Im
2019-05-08 16:02 ` Akinobu Mita
2019-05-07 16:58 ` [PATCH v2 7/7] nvme-pci: trigger device coredump on command timeout Akinobu Mita
2019-05-07 17:43 ` [PATCH v2 0/7] nvme-pci: support device coredump Heitke, Kenneth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC5umyjDn579iu4V1pXhKJ_PUQdNgY3LBZWgWgqQw_ZoNd88FQ@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=johannes@sipsolutions.net \
--cc=keith.busch@intel.com \
--cc=kenneth.heitke@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).