* [PATCH] x86/events/amd/iommu: Make symbol 'amd_iommu_attr_groups' static
@ 2019-05-08 2:04 Wang Hai
2019-05-08 11:40 ` [tip:perf/urgent] perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static tip-bot for Wang Hai
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2019-05-08 2:04 UTC (permalink / raw)
To: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung, tglx, bp, hpa
Cc: wanghai26, x86, linux-kernel
Fix the following sparse warning:
arch/x86/events/amd/iommu.c:396:30: warning:
symbol 'amd_iommu_attr_groups' was not declared. Should it be static?
Fixes: 51686546304f (x86/events/amd/iommu: Fix sysfs perf attribute groups)
Signed-off-by: Wang Hai <wanghai26@huawei.com>
---
arch/x86/events/amd/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
index 7635c23f7d82..58a6993d7eb3 100644
--- a/arch/x86/events/amd/iommu.c
+++ b/arch/x86/events/amd/iommu.c
@@ -393,7 +393,7 @@ static __init int _init_events_attrs(void)
return 0;
}
-const struct attribute_group *amd_iommu_attr_groups[] = {
+static const struct attribute_group *amd_iommu_attr_groups[] = {
&amd_iommu_format_group,
&amd_iommu_cpumask_group,
&amd_iommu_events_group,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/urgent] perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static
2019-05-08 2:04 [PATCH] x86/events/amd/iommu: Make symbol 'amd_iommu_attr_groups' static Wang Hai
@ 2019-05-08 11:40 ` tip-bot for Wang Hai
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Wang Hai @ 2019-05-08 11:40 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, torvalds, hpa, mingo, wanghai26, peterz, tglx
Commit-ID: 4abf1ee16e25ba97bc9e04ddc64e0cd2a1bc41a8
Gitweb: https://git.kernel.org/tip/4abf1ee16e25ba97bc9e04ddc64e0cd2a1bc41a8
Author: Wang Hai <wanghai26@huawei.com>
AuthorDate: Wed, 8 May 2019 10:04:18 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 8 May 2019 13:35:32 +0200
perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static
Fixes the following sparse warning:
arch/x86/events/amd/iommu.c:396:30: warning:
symbol 'amd_iommu_attr_groups' was not declared. Should it be static?
Signed-off-by: Wang Hai <wanghai26@huawei.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@kernel.org
Cc: alexander.shishkin@linux.intel.com
Cc: bp@alien8.de
Cc: jolsa@redhat.com
Cc: namhyung@kernel.org
Fixes: 51686546304f (x86/events/amd/iommu: Fix sysfs perf attribute groups)
Link: http://lkml.kernel.org/r/20190508020418.19568-1-wanghai26@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/events/amd/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
index 7635c23f7d82..58a6993d7eb3 100644
--- a/arch/x86/events/amd/iommu.c
+++ b/arch/x86/events/amd/iommu.c
@@ -393,7 +393,7 @@ static __init int _init_events_attrs(void)
return 0;
}
-const struct attribute_group *amd_iommu_attr_groups[] = {
+static const struct attribute_group *amd_iommu_attr_groups[] = {
&amd_iommu_format_group,
&amd_iommu_cpumask_group,
&amd_iommu_events_group,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-08 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 2:04 [PATCH] x86/events/amd/iommu: Make symbol 'amd_iommu_attr_groups' static Wang Hai
2019-05-08 11:40 ` [tip:perf/urgent] perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static tip-bot for Wang Hai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).